Commit ac70b5bf authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[liftoff] Do not store any relocation info

Liftoff code is never relocated and never serialized, thus relocation
information is not needed.

This results in slightly less information being printed when
disassembling code, because the disassembler sometimes uses relocation
information to show the kind of a call (e.g. internal wasm call vs.
builtin call). This is an acceptable regression IMO.

R=thibaudm@chromium.org

Bug: v8:10777
Change-Id: I019913a41b47466fba7b7f216ab51b91475cd984
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2412186Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69939}
parent cb85c18a
...@@ -1064,6 +1064,10 @@ std::unique_ptr<WasmCode> NativeModule::AddCodeWithCodeSpace( ...@@ -1064,6 +1064,10 @@ std::unique_ptr<WasmCode> NativeModule::AddCodeWithCodeSpace(
// Flush the i-cache after relocation. // Flush the i-cache after relocation.
FlushInstructionCache(dst_code_bytes.begin(), dst_code_bytes.size()); FlushInstructionCache(dst_code_bytes.begin(), dst_code_bytes.size());
// Liftoff code will not be relocated or serialized, thus do not store any
// relocation information.
if (tier == ExecutionTier::kLiftoff) reloc_info = {};
std::unique_ptr<WasmCode> code{new WasmCode{ std::unique_ptr<WasmCode> code{new WasmCode{
this, index, dst_code_bytes, stack_slots, tagged_parameter_slots, this, index, dst_code_bytes, stack_slots, tagged_parameter_slots,
safepoint_table_offset, handler_table_offset, constant_pool_offset, safepoint_table_offset, handler_table_offset, constant_pool_offset,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment