Commit aaf8d462 authored by Michael Lippautz's avatar Michael Lippautz Committed by Commit Bot

Disable GCStackTest.IteratePointersFindsParameterNesting8 for MSVC

The test gets miscompiled on MSVC >=19.25, see bug.

Bug: v8:10658
Change-Id: I3b75fe45916fa9e59ec78b852b7bdf707f11a2cc
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2443731
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Commit-Queue: Omer Katz <omerkatz@chromium.org>
Auto-Submit: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70278}
parent fe947abf
......@@ -261,6 +261,8 @@ TEST_F(GCStackTest, IteratePointersFindsParameterNesting7) {
EXPECT_TRUE(scanner->found());
}
// Disabled on msvc, due to miscompilation, see https://crbug.com/v8/10658.
#if !defined(_MSC_VER) || defined(__clang__)
TEST_F(GCStackTest, IteratePointersFindsParameterNesting8) {
auto scanner = std::make_unique<StackScanner>();
void* needle = RecursivelyPassOnParameter(8, scanner->needle(), GetStack(),
......@@ -268,6 +270,7 @@ TEST_F(GCStackTest, IteratePointersFindsParameterNesting8) {
EXPECT_EQ(scanner->needle(), needle);
EXPECT_TRUE(scanner->found());
}
#endif // !_MSC_VER || __clang__
// The following test uses inline assembly and has been checked to work on clang
// to verify that the stack-scanning trampoline pushes callee-saved registers.
......
......@@ -58,8 +58,6 @@
# BUG(992783).
'Torque.ConditionalFields': [SKIP],
'Torque.UsingUnderscorePrefixedIdentifierError': [SKIP],
# BUG(10658).
'GCStackTest.IteratePointersFindsParameterNesting8': [SKIP],
}], # system == windows and arch == x64 and mode == release
['tsan == True', {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment