Commit aae3f961 authored by zhengxing.li's avatar zhengxing.li Committed by Commit bot

X87: [turbofan] Desugar JSUnaryNot(x) to Select(x, false, true).

  port 411c5b7f (r32524)

  original commit message:
  Also remove the ResultMode from ToBooleanStub and always return true or
  false and use the same mechanism in fullcodegen.  This is in preparation
  for adding ToBoolean hints to TurboFan.

  Drive-by-fix: We can use the power of the ToBooleanIC in TurboFan now
  that the ResultMode is gone (and the runtime always returns true or
  false from the miss handler).

BUG=

Review URL: https://codereview.chromium.org/1500483002

Cr-Commit-Position: refs/heads/master@{#32543}
parent 36c395ce
...@@ -621,9 +621,8 @@ void FullCodeGenerator::DoTest(Expression* condition, ...@@ -621,9 +621,8 @@ void FullCodeGenerator::DoTest(Expression* condition,
Label* fall_through) { Label* fall_through) {
Handle<Code> ic = ToBooleanStub::GetUninitialized(isolate()); Handle<Code> ic = ToBooleanStub::GetUninitialized(isolate());
CallIC(ic, condition->test_id()); CallIC(ic, condition->test_id());
__ test(result_register(), result_register()); __ CompareRoot(result_register(), Heap::kTrueValueRootIndex);
// The stub returns nonzero for true. Split(equal, if_true, if_false, fall_through);
Split(not_zero, if_true, if_false, fall_through);
} }
...@@ -1977,8 +1976,8 @@ void FullCodeGenerator::VisitYield(Yield* expr) { ...@@ -1977,8 +1976,8 @@ void FullCodeGenerator::VisitYield(Yield* expr) {
CallLoadIC(NOT_INSIDE_TYPEOF); // result.done in eax CallLoadIC(NOT_INSIDE_TYPEOF); // result.done in eax
Handle<Code> bool_ic = ToBooleanStub::GetUninitialized(isolate()); Handle<Code> bool_ic = ToBooleanStub::GetUninitialized(isolate());
CallIC(bool_ic); CallIC(bool_ic);
__ test(eax, eax); __ CompareRoot(result_register(), Heap::kTrueValueRootIndex);
__ j(zero, &l_try); __ j(not_equal, &l_try);
// result.value // result.value
__ pop(load_receiver); // result __ pop(load_receiver); // result
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment