Commit a857e3d0 authored by bjaideep's avatar bjaideep Committed by Commit bot

PPC/s390: [async-iteration] implement AsyncGenerator

Port bf463c4d

Original Commit Message:

    - Introduce new struct AsyncGeneratorRequest, which holds
      information pertinent to resuming execution of an
      AsyncGenerator, such as the Promise associated with the async
      generator request. It is intended to be used as a singly
      linked list, and holds a pointer to the next item in te queue.

    - Introduce JSAsyncGeneratorObject (subclass of
      JSGeneratorObject), which includes several new internal fields
      (`queue` which contains a singly linked list of
      AsyncGeneratorRequest objects, and `await_input` which
      contains the sent value from an Await expression (This is
      necessary to prevent function.sent (used by yield*) from
      having the sent value observably overwritten during
      execution).

    - Modify SuspendGenerator to accept a set of Flags, which
      indicate whether the suspend is for a Yield or Await, and
      whether it takes place on an async generator or ES6
      generator.

    - Introduce interpreter intrinsics and TF intrinsic lowering for
      accessing the await input of an async generator

    - Modify the JSGeneratorStore operator to understand whether or
      not it's suspending for a normal yield, or an AsyncGenerator
      Await. This ensures appropriate registers are stored.

    - Add versions of ResumeGeneratorTrampoline which store the
      input value in a different field depending on wether it's an
      AsyncGenerator Await resume, or an ordinary resume. Also modifies
      whether debug code will assert that the generator object is a
      JSGeneratorObject or a JSAsyncGeneratorObject depending on the
      resume type.

R=caitp@igalia.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=v8:5855
LOG=N

Review-Url: https://codereview.chromium.org/2780283002
Cr-Commit-Position: refs/heads/master@{#44247}
parent 9cbdb715
......@@ -655,19 +655,40 @@ void Builtins::Generate_JSBuiltinsConstructStubForDerived(
// static
void Builtins::Generate_ResumeGeneratorTrampoline(MacroAssembler* masm) {
Generate_ResumeGenerator(masm, ResumeGeneratorType::kGenerator);
}
// static
void Builtins::Generate_ResumeAsyncGeneratorTrampoline(MacroAssembler* masm) {
Generate_ResumeGenerator(masm, ResumeGeneratorType::kAsyncGenerator);
}
// static
void Builtins::Generate_ResumeAwaitedAsyncGeneratorTrampoline(
MacroAssembler* masm) {
Generate_ResumeGenerator(masm, ResumeGeneratorType::kAwaitedAsyncGenerator);
}
void Builtins::Generate_ResumeGenerator(MacroAssembler* masm,
ResumeGeneratorType type) {
// ----------- S t a t e -------------
// -- r3 : the value to pass to the generator
// -- r4 : the JSGeneratorObject to resume
// -- r5 : the resume mode (tagged)
// -- lr : return address
// -----------------------------------
__ AssertGeneratorObject(r4);
if (type == ResumeGeneratorType::kGenerator) {
__ AssertGeneratorObject(r4);
} else {
__ AssertAsyncGeneratorObject(r4);
}
// Store input value into generator object.
__ StoreP(r3, FieldMemOperand(r4, JSGeneratorObject::kInputOrDebugPosOffset),
r0);
__ RecordWriteField(r4, JSGeneratorObject::kInputOrDebugPosOffset, r3, r6,
kLRHasNotBeenSaved, kDontSaveFPRegs);
int offset = type == ResumeGeneratorType::kAwaitedAsyncGenerator
? JSAsyncGeneratorObject::kAwaitInputOrDebugPosOffset
: JSGeneratorObject::kInputOrDebugPosOffset;
__ StoreP(r3, FieldMemOperand(r4, offset), r0);
__ RecordWriteField(r4, offset, r3, r6, kLRHasNotBeenSaved, kDontSaveFPRegs);
// Store resume mode into generator object.
__ StoreP(r5, FieldMemOperand(r4, JSGeneratorObject::kResumeModeOffset), r0);
......
......@@ -653,19 +653,40 @@ void Builtins::Generate_JSBuiltinsConstructStubForDerived(
// static
void Builtins::Generate_ResumeGeneratorTrampoline(MacroAssembler* masm) {
Generate_ResumeGenerator(masm, ResumeGeneratorType::kGenerator);
}
// static
void Builtins::Generate_ResumeAsyncGeneratorTrampoline(MacroAssembler* masm) {
Generate_ResumeGenerator(masm, ResumeGeneratorType::kAsyncGenerator);
}
// static
void Builtins::Generate_ResumeAwaitedAsyncGeneratorTrampoline(
MacroAssembler* masm) {
Generate_ResumeGenerator(masm, ResumeGeneratorType::kAwaitedAsyncGenerator);
}
void Builtins::Generate_ResumeGenerator(MacroAssembler* masm,
ResumeGeneratorType type) {
// ----------- S t a t e -------------
// -- r2 : the value to pass to the generator
// -- r3 : the JSGeneratorObject to resume
// -- r4 : the resume mode (tagged)
// -- lr : return address
// -----------------------------------
__ AssertGeneratorObject(r3);
if (type == ResumeGeneratorType::kGenerator) {
__ AssertGeneratorObject(r3);
} else {
__ AssertAsyncGeneratorObject(r3);
}
// Store input value into generator object.
__ StoreP(r2, FieldMemOperand(r3, JSGeneratorObject::kInputOrDebugPosOffset),
r0);
__ RecordWriteField(r3, JSGeneratorObject::kInputOrDebugPosOffset, r2, r5,
kLRHasNotBeenSaved, kDontSaveFPRegs);
int offset = type == ResumeGeneratorType::kAwaitedAsyncGenerator
? JSAsyncGeneratorObject::kAwaitInputOrDebugPosOffset
: JSGeneratorObject::kInputOrDebugPosOffset;
__ StoreP(r2, FieldMemOperand(r3, offset), r0);
__ RecordWriteField(r3, offset, r2, r5, kLRHasNotBeenSaved, kDontSaveFPRegs);
// Store resume mode into generator object.
__ StoreP(r4, FieldMemOperand(r3, JSGeneratorObject::kResumeModeOffset));
......
......@@ -2637,6 +2637,18 @@ void MacroAssembler::AssertGeneratorObject(Register object) {
}
}
void MacroAssembler::AssertAsyncGeneratorObject(Register object) {
if (emit_debug_code()) {
STATIC_ASSERT(kSmiTag == 0);
TestIfSmi(object, r0);
Check(ne, kOperandIsASmiAndNotAGeneratorObject);
push(object);
CompareObjectType(object, object, object, JS_ASYNC_GENERATOR_OBJECT_TYPE);
pop(object);
Check(eq, kOperandIsNotAGeneratorObject);
}
}
void MacroAssembler::AssertUndefinedOrAllocationSite(Register object,
Register scratch) {
if (emit_debug_code()) {
......
......@@ -1312,6 +1312,7 @@ class MacroAssembler : public Assembler {
// Abort execution if argument is not a JSGeneratorObject,
// enabled via --debug-code.
void AssertGeneratorObject(Register object);
void AssertAsyncGeneratorObject(Register object);
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
......
......@@ -2413,6 +2413,18 @@ void MacroAssembler::AssertGeneratorObject(Register object) {
}
}
void MacroAssembler::AssertAsyncGeneratorObject(Register object) {
if (emit_debug_code()) {
STATIC_ASSERT(kSmiTag == 0);
TestIfSmi(object);
Check(ne, kOperandIsASmiAndNotAGeneratorObject);
push(object);
CompareObjectType(object, object, object, JS_ASYNC_GENERATOR_OBJECT_TYPE);
pop(object);
Check(eq, kOperandIsNotAGeneratorObject);
}
}
void MacroAssembler::AssertUndefinedOrAllocationSite(Register object,
Register scratch) {
if (emit_debug_code()) {
......
......@@ -1630,6 +1630,7 @@ class MacroAssembler : public Assembler {
// Abort execution if argument is not a JSGeneratorObject,
// enabled via --debug-code.
void AssertGeneratorObject(Register object);
void AssertAsyncGeneratorObject(Register object);
// Abort execution if argument is not undefined or an AllocationSite, enabled
// via --debug-code.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment