[wasm] Refactored function to no longer make copies

Bug: v8:8015
Change-Id: I4e4892f49de69b8c6c3347de024708997825cb44
Reviewed-on: https://chromium-review.googlesource.com/1209848Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Commit-Queue: Florian Sattler <sattlerf@google.com>
Cr-Commit-Position: refs/heads/master@{#55704}

src/wasm/module-compiler.cc

@@ -2822,7 +2822,7 @@ void CompilationState::SetNumberOfFunctionsToCompile(size_t num_functions) {
 void CompilationState::SetCallback(
     std::function<void(CompilationEvent, ErrorThrower*)> callback) {
   DCHECK_NULL(callback_);
-  callback_ = callback;
+  callback_ = std::move(callback);
 }
 
 void CompilationState::AddCompilationUnits(

src/wasm/wasm-engine.cc

@@ -186,7 +186,7 @@ std::shared_ptr<NativeModule> WasmEngine::ExportNativeModule(
 }
 
 Handle<WasmModuleObject> WasmEngine::ImportNativeModule(
-    Isolate* isolate, std::shared_ptr<NativeModule> shared_module) {
+    Isolate* isolate, const std::shared_ptr<NativeModule>& shared_module) {
   CHECK_EQ(code_manager(), shared_module->code_manager());
   Vector<const byte> wire_bytes = shared_module->wire_bytes();
   Handle<Script> script = CreateWasmScript(isolate, wire_bytes);

src/wasm/wasm-engine.h

@@ -106,7 +106,7 @@ class V8_EXPORT_PRIVATE WasmEngine {
   // Imports the shared part of a module from a different Context/Isolate using
   // the the same engine, recreating a full module object in the given Isolate.
   Handle<WasmModuleObject> ImportNativeModule(
-      Isolate* isolate, std::shared_ptr<NativeModule> shared_module);
+      Isolate* isolate, const std::shared_ptr<NativeModule>& shared_module);
 
   WasmCodeManager* code_manager() const { return code_manager_.get(); }
 

src/wasm/wasm-result.cc

@@ -149,7 +149,7 @@ ErrorThrower::ErrorThrower(ErrorThrower&& other) V8_NOEXCEPT
     : isolate_(other.isolate_),
       context_(other.context_),
       error_type_(other.error_type_),
-      error_msg_(other.error_msg_) {
+      error_msg_(std::move(other.error_msg_)) {
   other.error_type_ = kNone;
 }