Revert "[sparkplug] Enable shorter builtin calls behind --short-builtin-calls"

This reverts commit 5f9f09f4.

Reason for revert: Broke https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Clusterfuzz%20Linux64%20-%20release%20builder/21079/overview

Original change's description:
> [sparkplug] Enable shorter builtin calls behind --short-builtin-calls
>
> ... on desktop x64 and arm64 if pointer compression is enabled.
>
> Bug: v8:11527
> Change-Id: Ie23b59312c6db34a5f40e23347b3c4f11173612d
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2767222
> Commit-Queue: Igor Sheludko <ishell@chromium.org>
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#73498}

Bug: v8:11527
Change-Id: I48ec54a134a293e31d4d26ce3a82a27a714fde6a
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2770599
Auto-Submit: Zhi An Ng <zhin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#73499}

BUILD.gn

@@ -345,13 +345,10 @@ if (v8_enable_heap_sandbox == "") {
   v8_enable_heap_sandbox = false
 }
 if (v8_enable_short_builtin_calls == "") {
-  v8_enable_short_builtin_calls =
-      v8_current_cpu == "x64" || (!is_android && v8_current_cpu == "arm64")
-}
-if (v8_enable_short_builtin_calls && !v8_enable_pointer_compression) {
-  # Disable short calls when pointer compression is not enabled.
   v8_enable_short_builtin_calls = false
 }
+assert(!v8_enable_short_builtin_calls || v8_enable_pointer_compression,
+       "Short builtin calls feature requires pointer compression")
 if (v8_enable_single_generation == "") {
   v8_enable_single_generation = v8_disable_write_barriers
 }

src/common/globals.h

@@ -106,6 +106,9 @@ STATIC_ASSERT(V8_DEFAULT_STACK_SIZE_KB* KB +
 // and friends.
 #error Short builtin calls feature requires pointer compression
 #endif
+#define V8_SHORT_BUILTIN_CALLS_BOOL true
+#else
+#define V8_SHORT_BUILTIN_CALLS_BOOL false
 #endif
 
 // Determine whether dict mode prototypes feature is enabled.

src/flags/flag-definitions.h

@@ -1535,21 +1535,10 @@ DEFINE_BOOL(adjust_os_scheduling_parameters, true,
             "adjust OS specific scheduling params for the isolate")
 DEFINE_BOOL(experimental_flush_embedded_blob_icache, false,
             "Used in an experiment to evaluate icache flushing on certain CPUs")
-
-// Flags for short builtin calls feature
-#undef FLAG
-#if V8_SHORT_BUILTIN_CALLS
-#define FLAG FLAG_FULL
-#else
-#define FLAG FLAG_READONLY
-#endif
-
-DEFINE_BOOL(short_builtin_calls, false,
-            "Put embedded builtins code into the code range for shorter "
-            "builtin calls/jumps")
-
-#undef FLAG
-#define FLAG FLAG_FULL
+DEFINE_BOOL_READONLY(
+    short_builtin_calls, V8_SHORT_BUILTIN_CALLS_BOOL,
+    "Put embedded builtins code into the code range for shorter "
+    "builtin calls/jumps")
 
 // runtime.cc
 DEFINE_BOOL(runtime_call_stats, false, "report runtime call counts and times")