Commit a6a72735 authored by Clemens Hammacher's avatar Clemens Hammacher Committed by Commit Bot

[foozzie] Move --suppress-asm-messages flag to FLAGS

Instead of repeating it in every configuration, just add it to the
common FLAGS.

R=machenbach@chromium.org

Change-Id: I93e7ef0f0ad55bfe0a0e24f50d5a73d4658d7554
Reviewed-on: https://chromium-review.googlesource.com/1141733
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54552}
parent 9abcfd4c
...@@ -9,9 +9,9 @@ ...@@ -9,9 +9,9 @@
# Compared x64,ignition with x64,ignition_turbo # Compared x64,ignition with x64,ignition_turbo
# #
# Flags of x64,ignition: # Flags of x64,ignition:
--abort_on_stack_or_string_length_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --wasm-num-compilation-tasks=0 --random-seed 12345 --turbo-filter=~ --noopt --suppress-asm-messages --liftoff --no-wasm-tier-up --abort_on_stack_or_string_length_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --wasm-num-compilation-tasks=0 --suppress-asm-messages --random-seed 12345 --turbo-filter=~ --noopt --liftoff --no-wasm-tier-up
# Flags of x64,ignition_turbo: # Flags of x64,ignition_turbo:
--abort_on_stack_or_string_length_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --wasm-num-compilation-tasks=0 --random-seed 12345 --suppress-asm-messages --stress-scavenge=100 --abort_on_stack_or_string_length_overflow --expose-gc --allow-natives-syntax --invoke-weak-callbacks --omit-quit --es-staging --wasm-num-compilation-tasks=0 --suppress-asm-messages --random-seed 12345 --stress-scavenge=100
# #
# Difference: # Difference:
- unknown - unknown
......
...@@ -21,13 +21,10 @@ import v8_commands ...@@ -21,13 +21,10 @@ import v8_commands
import v8_suppressions import v8_suppressions
CONFIGS = dict( CONFIGS = dict(
default=[ default=[],
'--suppress-asm-messages',
],
ignition=[ ignition=[
'--turbo-filter=~', '--turbo-filter=~',
'--noopt', '--noopt',
'--suppress-asm-messages',
'--liftoff', '--liftoff',
'--no-wasm-tier-up', '--no-wasm-tier-up',
], ],
...@@ -36,21 +33,16 @@ CONFIGS = dict( ...@@ -36,21 +33,16 @@ CONFIGS = dict(
'--noopt', '--noopt',
'--validate-asm', '--validate-asm',
'--stress-validate-asm', '--stress-validate-asm',
'--suppress-asm-messages',
], ],
ignition_eager=[ ignition_eager=[
'--turbo-filter=~', '--turbo-filter=~',
'--noopt', '--noopt',
'--no-lazy', '--no-lazy',
'--no-lazy-inner-functions', '--no-lazy-inner-functions',
'--suppress-asm-messages',
],
ignition_turbo=[
'--suppress-asm-messages',
], ],
ignition_turbo=[],
ignition_turbo_opt=[ ignition_turbo_opt=[
'--always-opt', '--always-opt',
'--suppress-asm-messages',
'--no-liftoff', '--no-liftoff',
'--no-wasm-tier-up', '--no-wasm-tier-up',
], ],
...@@ -58,25 +50,20 @@ CONFIGS = dict( ...@@ -58,25 +50,20 @@ CONFIGS = dict(
'--always-opt', '--always-opt',
'--no-lazy', '--no-lazy',
'--no-lazy-inner-functions', '--no-lazy-inner-functions',
'--suppress-asm-messages',
], ],
slow_path=[ slow_path=[
'--force-slow-path', '--force-slow-path',
'--suppress-asm-messages',
], ],
slow_path_opt=[ slow_path_opt=[
'--always-opt', '--always-opt',
'--force-slow-path', '--force-slow-path',
'--suppress-asm-messages',
], ],
trusted=[ trusted=[
'--no-untrusted-code-mitigations', '--no-untrusted-code-mitigations',
'--suppress-asm-messages',
], ],
trusted_opt=[ trusted_opt=[
'--always-opt', '--always-opt',
'--no-untrusted-code-mitigations', '--no-untrusted-code-mitigations',
'--suppress-asm-messages',
], ],
) )
...@@ -106,7 +93,8 @@ ARCH_MOCKS = os.path.join(BASE_PATH, 'v8_mock_archs.js') ...@@ -106,7 +93,8 @@ ARCH_MOCKS = os.path.join(BASE_PATH, 'v8_mock_archs.js')
FLAGS = ['--abort_on_stack_or_string_length_overflow', '--expose-gc', FLAGS = ['--abort_on_stack_or_string_length_overflow', '--expose-gc',
'--allow-natives-syntax', '--invoke-weak-callbacks', '--omit-quit', '--allow-natives-syntax', '--invoke-weak-callbacks', '--omit-quit',
'--es-staging', '--wasm-num-compilation-tasks=0'] '--es-staging', '--wasm-num-compilation-tasks=0',
'--suppress-asm-messages']
SUPPORTED_ARCHS = ['ia32', 'x64', 'arm', 'arm64'] SUPPORTED_ARCHS = ['ia32', 'x64', 'arm', 'arm64']
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment