Commit a596efcc authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[turbofan] Refine a DCHECK

Hole checks are done using a lower level comparison.

Change-Id: I61c5b787f12564ad3553d395a36938a00f5dd554
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2172418
Auto-Submit: Georg Neis <neis@chromium.org>
Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67466}
parent 7a1d7127
...@@ -1249,7 +1249,7 @@ Type OperationTyper::StrictEqual(Type lhs, Type rhs) { ...@@ -1249,7 +1249,7 @@ Type OperationTyper::StrictEqual(Type lhs, Type rhs) {
// Types are equal and are inhabited only by a single semantic value, // Types are equal and are inhabited only by a single semantic value,
// which is not nan due to the earlier check. // which is not nan due to the earlier check.
DCHECK(lhs.Is(rhs)); DCHECK(lhs.Is(rhs));
DCHECK(lhs.Is(Type::NonInternal()) || lhs.Is(Type::Hole())); DCHECK(lhs.Is(Type::NonInternal()));
return singleton_true(); return singleton_true();
} }
if ((lhs.Is(Type::Unique()) || rhs.Is(Type::Unique())) && !lhs.Maybe(rhs)) { if ((lhs.Is(Type::Unique()) || rhs.Is(Type::Unique())) && !lhs.Maybe(rhs)) {
......
...@@ -1083,6 +1083,7 @@ Type Typer::Visitor::JSEqualTyper(Type lhs, Type rhs, Typer* t) { ...@@ -1083,6 +1083,7 @@ Type Typer::Visitor::JSEqualTyper(Type lhs, Type rhs, Typer* t) {
// Types are equal and are inhabited only by a single semantic value, // Types are equal and are inhabited only by a single semantic value,
// which is not nan due to the earlier check. // which is not nan due to the earlier check.
DCHECK(lhs.Is(rhs)); DCHECK(lhs.Is(rhs));
DCHECK(lhs.Is(Type::NonInternal()));
return t->singleton_true_; return t->singleton_true_;
} }
return Type::Boolean(); return Type::Boolean();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment