Commit a3a583db authored by epertoso's avatar epertoso Committed by Commit bot

[turbofan] Re-enables the jump table emission in the mips instruction selector.

Changes MacroAssembler::GenerateSwitchTable to make sure that 'ra' is properly restored.

BUG=

Review URL: https://codereview.chromium.org/1761863002

Cr-Commit-Position: refs/heads/master@{#34460}
parent 2689548e
......@@ -1216,9 +1216,6 @@ void InstructionSelector::VisitSwitch(Node* node, const SwitchInfo& sw) {
MipsOperandGenerator g(this);
InstructionOperand value_operand = g.UseRegister(node->InputAt(0));
// TODO(mips): TableSwitch is broken, as it messes with ra without saving it
// properly (which breaks with frame elision, i.e. inside stubs).
if (false) {
// Emit either ArchTableSwitch or ArchLookupSwitch.
size_t table_space_cost = 9 + sw.value_range;
size_t table_time_cost = 3;
......@@ -1237,7 +1234,6 @@ void InstructionSelector::VisitSwitch(Node* node, const SwitchInfo& sw) {
// Generate a table lookup.
return EmitTableSwitch(sw, index_operand);
}
}
// Generate a sequence of conditional jumps.
return EmitLookupSwitch(sw, value_operand);
......
......@@ -1711,9 +1711,6 @@ void InstructionSelector::VisitSwitch(Node* node, const SwitchInfo& sw) {
Mips64OperandGenerator g(this);
InstructionOperand value_operand = g.UseRegister(node->InputAt(0));
// TODO(mips): TableSwitch is broken, as it messes with ra without saving it
// properly (which breaks with frame elision, i.e. inside stubs).
if (false) {
// Emit either ArchTableSwitch or ArchLookupSwitch.
size_t table_space_cost = 10 + 2 * sw.value_range;
size_t table_time_cost = 3;
......@@ -1732,7 +1729,6 @@ void InstructionSelector::VisitSwitch(Node* node, const SwitchInfo& sw) {
// Generate a table lookup.
return EmitTableSwitch(sw, index_operand);
}
}
// Generate a sequence of conditional jumps.
return EmitLookupSwitch(sw, value_operand);
......
......@@ -1778,12 +1778,14 @@ void MacroAssembler::GenerateSwitchTable(Register index, size_t case_count,
lw(at, MemOperand(at));
} else {
Label here;
BlockTrampolinePoolFor(case_count + 6);
BlockTrampolinePoolFor(case_count + 10);
push(ra);
bal(&here);
sll(at, index, kPointerSizeLog2); // Branch delay slot.
bind(&here);
addu(at, at, ra);
lw(at, MemOperand(at, 4 * v8::internal::Assembler::kInstrSize));
pop(ra);
lw(at, MemOperand(at, 6 * v8::internal::Assembler::kInstrSize));
}
jr(at);
nop(); // Branch delay slot nop.
......
......@@ -1941,13 +1941,15 @@ void MacroAssembler::GenerateSwitchTable(Register index, size_t case_count,
ld(at, MemOperand(at));
} else {
Label here;
BlockTrampolinePoolFor(static_cast<int>(case_count) * 2 + 7);
BlockTrampolinePoolFor(static_cast<int>(case_count) * 2 + 11);
Align(8);
push(ra);
bal(&here);
dsll(at, index, kPointerSizeLog2); // Branch delay slot.
bind(&here);
daddu(at, at, ra);
ld(at, MemOperand(at, 4 * v8::internal::Assembler::kInstrSize));
pop(ra);
ld(at, MemOperand(at, 6 * v8::internal::Assembler::kInstrSize));
}
jr(at);
nop(); // Branch delay slot nop.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment