Commit a23a74a7 authored by machenbach's avatar machenbach Committed by Commit bot

[test] Remove deprecated --ignition test-runner flag

The flag was introduced for ignition development. It can only
be used when running ignition tests in isolation on the bots.

The bots only use ignition_turbo in isolation since a while
and don't pass the --ignition flag anymore.

BUG=v8:5238

Review-Url: https://codereview.chromium.org/2197123002
Cr-Commit-Position: refs/heads/master@{#38206}
parent df61ffea
...@@ -404,7 +404,7 @@ ...@@ -404,7 +404,7 @@
}], # 'arch == ppc64 and simulator_run == True' }], # 'arch == ppc64 and simulator_run == True'
############################################################################## ##############################################################################
['ignition or ignition_turbofan', { ['ignition_turbofan', {
# TODO(rmcilroy,4837): Inlining is currently disabled for the BytecodeGraphBuilder # TODO(rmcilroy,4837): Inlining is currently disabled for the BytecodeGraphBuilder
# (see InliningPhase::Run). Also, we don't set a LoadContextSlot for a function as # (see InliningPhase::Run). Also, we don't set a LoadContextSlot for a function as
# immutable in the BytecodeGraphBuilder, therefore no inlining happens. # immutable in the BytecodeGraphBuilder, therefore no inlining happens.
...@@ -489,6 +489,6 @@ ...@@ -489,6 +489,6 @@
# BUG(4751). Flaky with Ignition. # BUG(4751). Flaky with Ignition.
'test-cpu-profiler/JsNativeJsSample': [SKIP], 'test-cpu-profiler/JsNativeJsSample': [SKIP],
}], # ignition or ignition_turbofan }], # ignition_turbofan
] ]
...@@ -193,15 +193,16 @@ ...@@ -193,15 +193,16 @@
# TODO(titzer): ASM->WASM tests on these platforms # TODO(titzer): ASM->WASM tests on these platforms
'wasm/asm-wasm': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]], 'wasm/asm-wasm': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]],
# TODO(branelson): Figure out why ignition + asm-wasm-stdlib fails. # TODO(branelson): Figure out why ignition + asm-wasm-stdlib fails.
'wasm/asm-wasm-stdlib': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el] or ignition == True', SKIP]], # TODO(branelson): The old status entry was misconfigured as it added
'wasm/asm-wasm-literals': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el] or ignition == True', SKIP]], # "or ignition == True". This was deprecated at some point and was never
# true. Essentially the next lines skip the tests for a bunch of
# architectures.
'wasm/asm-wasm-stdlib': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]],
'wasm/asm-wasm-literals': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]],
'wasm/asm-wasm-copy': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]], 'wasm/asm-wasm-copy': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]],
'wasm/asm-wasm-deopt': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]], 'wasm/asm-wasm-deopt': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]],
'wasm/asm-wasm-switch': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]], 'wasm/asm-wasm-switch': [PASS, ['arch in [arm, arm64, mips, mipsel, mips64, mips64el]', SKIP]],
# TODO(branelson): Figure out why ignition + asm->wasm fails embenchen.
'wasm/embenchen/*': [PASS, ['ignition == True', SKIP]],
# case-insensitive unicode regexp relies on case mapping provided by ICU. # case-insensitive unicode regexp relies on case mapping provided by ICU.
'es6/unicode-regexp-ignore-case': [PASS, ['no_i18n == True', FAIL]], 'es6/unicode-regexp-ignore-case': [PASS, ['no_i18n == True', FAIL]],
'es6/unicode-regexp-ignore-case-noi18n': [FAIL, ['no_i18n == True', PASS]], 'es6/unicode-regexp-ignore-case-noi18n': [FAIL, ['no_i18n == True', PASS]],
...@@ -694,7 +695,7 @@ ...@@ -694,7 +695,7 @@
}], # 'arch == ppc64' }], # 'arch == ppc64'
############################################################################## ##############################################################################
['ignition or ignition_turbofan', { ['ignition_turbofan', {
# TODO(mythria, 4780): Related to type feedback for calls in interpreter. # TODO(mythria, 4780): Related to type feedback for calls in interpreter.
'array-literal-feedback': [FAIL], 'array-literal-feedback': [FAIL],
'regress/regress-4121': [FAIL], 'regress/regress-4121': [FAIL],
...@@ -719,25 +720,25 @@ ...@@ -719,25 +720,25 @@
# TODO(rmcilroy): Flaky OOM. # TODO(rmcilroy): Flaky OOM.
'unicodelctest-no-optimization': [SKIP], 'unicodelctest-no-optimization': [SKIP],
}], # ignition or ignition_turbofan }], # ignition_turbofan
['(ignition or ignition_turbofan) and arch == arm64', { ['ignition_turbofan and arch == arm64', {
# TODO(rmcilroy,4680): Arm64 specific timeouts. # TODO(rmcilroy,4680): Arm64 specific timeouts.
'asm/construct-double': [SKIP], 'asm/construct-double': [SKIP],
'compiler/osr-one': [SKIP], 'compiler/osr-one': [SKIP],
'compiler/osr-two': [SKIP], 'compiler/osr-two': [SKIP],
'wasm/asm-wasm-i32': [SKIP], 'wasm/asm-wasm-i32': [SKIP],
'wasm/asm-wasm-u32': [SKIP], 'wasm/asm-wasm-u32': [SKIP],
}], # (ignition or ignition_turbofan) and arch == arm64 }], # ignition_turbofan and arch == arm64
['(ignition or ignition_turbofan) and arch == arm', { ['ignition_turbofan and arch == arm', {
# TODO(rmcilroy,4680): Arm specific timeouts. # TODO(rmcilroy,4680): Arm specific timeouts.
'compiler/osr-one': [SKIP], 'compiler/osr-one': [SKIP],
'compiler/osr-two': [SKIP], 'compiler/osr-two': [SKIP],
'regress/regress-1257': [SKIP], 'regress/regress-1257': [SKIP],
}], # (ignition or ignition_turbofan) and arch == arm }], # ignition_turbofan and arch == arm
['(ignition or ignition_turbofan) and msan', { ['ignition_turbofan and msan', {
# TODO(mythria,4680): All of these tests have large loops and hence slow # TODO(mythria,4680): All of these tests have large loops and hence slow
# and timeout. # and timeout.
'compiler/osr-big': [SKIP], 'compiler/osr-big': [SKIP],
...@@ -748,7 +749,7 @@ ...@@ -748,7 +749,7 @@
'try': [SKIP], 'try': [SKIP],
# Too slow for interpreter and msan. # Too slow for interpreter and msan.
'es6/tail-call-megatest*': [SKIP], 'es6/tail-call-megatest*': [SKIP],
}], # (ignition or ignition_turbofan) and msan }], # ignition_turbofan and msan
############################################################################## ##############################################################################
['gcov_coverage', { ['gcov_coverage', {
......
...@@ -112,11 +112,11 @@ ...@@ -112,11 +112,11 @@
}], # msan }], # msan
############################################################################## ##############################################################################
['(ignition or ignition_turbofan) and msan', { ['ignition_turbofan and msan', {
# TODO(mythria,4680): Too slow and timeout on ignition. # TODO(mythria,4680): Too slow and timeout on ignition.
'dfg-double-vote-fuzz': [SKIP], 'dfg-double-vote-fuzz': [SKIP],
'dfg-int-overflow-in-loop': [SKIP], 'dfg-int-overflow-in-loop': [SKIP],
}], # (ignition or ignition_turbofan) and msan }], # ignition_turbofan and msan
############################################################################## ##############################################################################
['gcov_coverage', { ['gcov_coverage', {
......
...@@ -394,7 +394,6 @@ def Execute(arch, mode, args, options, suites, workspace): ...@@ -394,7 +394,6 @@ def Execute(arch, mode, args, options, suites, workspace):
"deopt_fuzzer": True, "deopt_fuzzer": True,
"gc_stress": False, "gc_stress": False,
"gcov_coverage": False, "gcov_coverage": False,
"ignition": False,
"ignition_turbofan": False, "ignition_turbofan": False,
"isolates": options.isolates, "isolates": options.isolates,
"mode": mode, "mode": mode,
......
...@@ -260,8 +260,6 @@ def BuildOptions(): ...@@ -260,8 +260,6 @@ def BuildOptions():
result.add_option("--extra-flags", result.add_option("--extra-flags",
help="Additional flags to pass to each test command", help="Additional flags to pass to each test command",
default="") default="")
result.add_option("--ignition", help="Skip tests which don't run in ignition",
default=False, action="store_true")
result.add_option("--ignition-turbofan", result.add_option("--ignition-turbofan",
help="Skip tests which don't run in ignition_turbofan", help="Skip tests which don't run in ignition_turbofan",
default=False, action="store_true") default=False, action="store_true")
...@@ -757,7 +755,6 @@ def Execute(arch, mode, args, options, suites): ...@@ -757,7 +755,6 @@ def Execute(arch, mode, args, options, suites):
"deopt_fuzzer": False, "deopt_fuzzer": False,
"gc_stress": options.gc_stress, "gc_stress": options.gc_stress,
"gcov_coverage": options.gcov_coverage, "gcov_coverage": options.gcov_coverage,
"ignition": options.ignition,
"ignition_turbofan": options.ignition_turbofan, "ignition_turbofan": options.ignition_turbofan,
"isolates": options.isolates, "isolates": options.isolates,
"mode": MODES[mode]["status_mode"], "mode": MODES[mode]["status_mode"],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment