Skip to content

V
V8
Commit a1dcac3d authored by littledan's avatar littledan Committed by Commit bot
Browse files
Options

Include Harmony Array/TypedArray methods unconditionally 

Conditionally including Array and TypedArray methods seems to cause
a slowdown in V8 context creation, possibly due to the new code added.

BUG=chromium:504629
R=adamk@chromium.org
LOG=Y

Review URL: https://codereview.chromium.org/1215863003

Cr-Commit-Position: refs/heads/master@{#29430}
parent a5221d07
Show whitespace changes
Inline Side-by-side
Showing with 13 additions and 48 deletions
BUILD.gn
View file @ a1dcac3d
...@@ -231,6 +231,8 @@ action("js2c") { ...@@ -231,6 +231,8 @@ action("js2c") {
"src/mirror-debugger.js", "src/mirror-debugger.js",
"src/liveedit-debugger.js", "src/liveedit-debugger.js",
"src/templates.js", "src/templates.js",
"src/harmony-array.js",
"src/harmony-typedarray.js",
] ]
outputs = [ outputs = [
...@@ -270,9 +272,7 @@ action("js2c_experimental") { ...@@ -270,9 +272,7 @@ action("js2c_experimental") {
"src/proxy.js", "src/proxy.js",
"src/generator.js", "src/generator.js",
"src/harmony-atomics.js", "src/harmony-atomics.js",
"src/harmony-array.js",
"src/harmony-array-includes.js", "src/harmony-array-includes.js",
"src/harmony-typedarray.js",
"src/harmony-tostring.js", "src/harmony-tostring.js",
"src/harmony-regexp.js", "src/harmony-regexp.js",
"src/harmony-reflect.js", "src/harmony-reflect.js",
......
src/bootstrapper.cc
View file @ a1dcac3d
...@@ -1798,7 +1798,6 @@ void Genesis::InitializeBuiltinTypedArrays() { ...@@ -1798,7 +1798,6 @@ void Genesis::InitializeBuiltinTypedArrays() {
void Genesis::InstallNativeFunctions_##id() {} void Genesis::InstallNativeFunctions_##id() {}
EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_modules) EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_modules)
EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_arrays)
EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_array_includes) EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_array_includes)
EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_regexps) EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_regexps)
EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_arrow_functions) EMPTY_NATIVE_FUNCTIONS_FOR_FEATURE(harmony_arrow_functions)
...@@ -1834,7 +1833,6 @@ void Genesis::InstallNativeFunctions_harmony_proxies() { ...@@ -1834,7 +1833,6 @@ void Genesis::InstallNativeFunctions_harmony_proxies() {
void Genesis::InitializeGlobal_##id() {} void Genesis::InitializeGlobal_##id() {}
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_modules) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_modules)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_arrays)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_array_includes) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_array_includes)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_arrow_functions) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_arrow_functions)
EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_proxies) EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_proxies)
...@@ -2464,8 +2462,6 @@ bool Genesis::InstallNatives() { ...@@ -2464,8 +2462,6 @@ bool Genesis::InstallNatives() {
bool Genesis::InstallExperimentalNatives() { bool Genesis::InstallExperimentalNatives() {
static const char* harmony_arrays_natives[] = {
"native harmony-array.js", "native harmony-typedarray.js", nullptr};
static const char* harmony_array_includes_natives[] = { static const char* harmony_array_includes_natives[] = {
"native harmony-array-includes.js", nullptr}; "native harmony-array-includes.js", nullptr};
static const char* harmony_proxies_natives[] = {"native proxy.js", nullptr}; static const char* harmony_proxies_natives[] = {"native proxy.js", nullptr};
......
src/flag-definitions.h
View file @ a1dcac3d
...@@ -202,7 +202,6 @@ DEFINE_IMPLICATION(es_staging, harmony) ...@@ -202,7 +202,6 @@ DEFINE_IMPLICATION(es_staging, harmony)
// Features that are shipping (turned on by default, but internal flag remains). // Features that are shipping (turned on by default, but internal flag remains).
#define HARMONY_SHIPPING(V) \ #define HARMONY_SHIPPING(V) \
V(harmony_arrays, "harmony array methods") \
V(harmony_arrow_functions, "harmony arrow functions") \ V(harmony_arrow_functions, "harmony arrow functions") \
V(harmony_computed_property_names, "harmony computed property names") \ V(harmony_computed_property_names, "harmony computed property names") \
V(harmony_spreadcalls, "harmony spread-calls") \ V(harmony_spreadcalls, "harmony spread-calls") \
......
src/runtime/runtime-array.cc
View file @ a1dcac3d
...@@ -726,7 +726,6 @@ static bool IterateElements(Isolate* isolate, Handle<JSObject> receiver, ...@@ -726,7 +726,6 @@ static bool IterateElements(Isolate* isolate, Handle<JSObject> receiver,
static bool IsConcatSpreadable(Isolate* isolate, Handle<Object> obj) { static bool IsConcatSpreadable(Isolate* isolate, Handle<Object> obj) {
HandleScope handle_scope(isolate); HandleScope handle_scope(isolate);
if (!obj->IsSpecObject()) return false; if (!obj->IsSpecObject()) return false;
if (FLAG_harmony_arrays) {
Handle<Symbol> key(isolate->factory()->is_concat_spreadable_symbol()); Handle<Symbol> key(isolate->factory()->is_concat_spreadable_symbol());
Handle<Object> value; Handle<Object> value;
MaybeHandle<Object> maybeValue = MaybeHandle<Object> maybeValue =
...@@ -736,7 +735,6 @@ static bool IsConcatSpreadable(Isolate* isolate, Handle<Object> obj) { ...@@ -736,7 +735,6 @@ static bool IsConcatSpreadable(Isolate* isolate, Handle<Object> obj) {
return value->BooleanValue(); return value->BooleanValue();
} }
} }
}
return obj->IsJSArray(); return obj->IsJSArray();
} }
......
test/mjsunit/harmony/typedarray-copywithin.js → test/mjsunit/es6/typedarray-copywithin.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarrays-every.js → test/mjsunit/es6/typedarray-every.js
View file @ a1dcac3d
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays --allow-natives-syntax // Flags: --allow-natives-syntax
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
......
test/mjsunit/harmony/typedarray-fill.js → test/mjsunit/es6/typedarray-fill.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarray-find.js → test/mjsunit/es6/typedarray-find.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarray-findindex.js → test/mjsunit/es6/typedarray-findindex.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarrays-foreach.js → test/mjsunit/es6/typedarray-foreach.js
View file @ a1dcac3d
...@@ -2,7 +2,7 @@ ...@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays --allow-natives-syntax // Flags: --allow-natives-syntax
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
......
test/mjsunit/harmony/typedarray-from.js → test/mjsunit/es6/typedarray-from.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarray-indexing.js → test/mjsunit/es6/typedarray-indexing.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarray-iteration.js → test/mjsunit/es6/typedarray-iteration.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
// Tests for standard TypedArray array iteration functions. // Tests for standard TypedArray array iteration functions.
var typedArrayConstructors = [ var typedArrayConstructors = [
......
test/mjsunit/harmony/typedarrays-of.js → test/mjsunit/es6/typedarray-of.js
View file @ a1dcac3d
...@@ -4,8 +4,6 @@ ...@@ -4,8 +4,6 @@
// Based on Mozilla Array.of() tests at http://dxr.mozilla.org/mozilla-central/source/js/src/jit-test/tests/collections // Based on Mozilla Array.of() tests at http://dxr.mozilla.org/mozilla-central/source/js/src/jit-test/tests/collections
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarray-proto.js → test/mjsunit/es6/typedarray-proto.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
// Test that the methods for different TypedArray types have the same // Test that the methods for different TypedArray types have the same
// identity. // identity.
// TODO(dehrenberg): Test that the TypedArray proto hierarchy is set // TODO(dehrenberg): Test that the TypedArray proto hierarchy is set
......
test/mjsunit/harmony/typedarray-reduce.js → test/mjsunit/es6/typedarray-reduce.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarray-reverse.js → test/mjsunit/es6/typedarray-reverse.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
function ArrayMaker(x) { function ArrayMaker(x) {
return x; return x;
} }
......
test/mjsunit/harmony/typedarray-slice.js → test/mjsunit/es6/typedarray-slice.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarray-sort.js → test/mjsunit/es6/typedarray-sort.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
var typedArrayConstructors = [ var typedArrayConstructors = [
Uint8Array, Uint8Array,
Int8Array, Int8Array,
......
test/mjsunit/harmony/typedarray-tostring.js → test/mjsunit/es6/typedarray-tostring.js
View file @ a1dcac3d
...@@ -2,8 +2,6 @@ ...@@ -2,8 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Flags: --harmony-arrays
// Array's toString should call the object's own join method, if one exists and // Array's toString should call the object's own join method, if one exists and
// is callable. Otherwise, just use the original Object.toString function. // is callable. Otherwise, just use the original Object.toString function.
......
tools/gyp/v8.gyp
View file @ a1dcac3d
...@@ -1770,6 +1770,8 @@ ...@@ -1770,6 +1770,8 @@
'../../src/mirror-debugger.js', '../../src/mirror-debugger.js',
'../../src/liveedit-debugger.js', '../../src/liveedit-debugger.js',
'../../src/templates.js', '../../src/templates.js',
'../../src/harmony-array.js',
'../../src/harmony-typedarray.js',
], ],
'experimental_library_files': [ 'experimental_library_files': [
'../../src/macros.py', '../../src/macros.py',
...@@ -1777,10 +1779,8 @@ ...@@ -1777,10 +1779,8 @@
'../../src/proxy.js', '../../src/proxy.js',
'../../src/generator.js', '../../src/generator.js',
'../../src/harmony-atomics.js', '../../src/harmony-atomics.js',
'../../src/harmony-array.js',
'../../src/harmony-array-includes.js', '../../src/harmony-array-includes.js',
'../../src/harmony-tostring.js', '../../src/harmony-tostring.js',
'../../src/harmony-typedarray.js',
'../../src/harmony-regexp.js', '../../src/harmony-regexp.js',
'../../src/harmony-reflect.js', '../../src/harmony-reflect.js',
'../../src/harmony-spread.js', '../../src/harmony-spread.js',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment