Commit 9fd97a5f authored by Georg Neis's avatar Georg Neis Committed by Commit Bot

[compiler] Fix a comment.

R=jarin@chromium.org

Bug: v8:6048
Change-Id: Ia80a403f647b176ef02807f6d15b3198b55234bc
Reviewed-on: https://chromium-review.googlesource.com/506013
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#45329}
parent 73d21080
......@@ -1617,19 +1617,14 @@ bool PipelineImpl::OptimizeGraph(Linkage* linkage) {
Run<SimplifiedLoweringPhase>();
RunPrintAndVerify("Simplified lowering", true);
// From now on it is invalid to look at types on the nodes, because the types
// on the nodes might not make sense after representation selection due to the
// way we handle truncations; if we'd want to look at types afterwards we'd
// essentially need to re-type (large portions of) the graph.
// In order to catch bugs related to type access after this point, we now
// remove the types from the nodes (currently only in Debug builds).
#ifdef DEBUG
// From now on it is invalid to look at types on the nodes, because:
//
// (a) The remaining passes (might) run concurrent to the main thread and
// therefore must not access the Heap or the Isolate in an uncontrolled
// way (as done by the type system), and
// (b) the types on the nodes might not make sense after representation
// selection due to the way we handle truncations; if we'd want to look
// at types afterwards we'd essentially need to re-type (large portions
// of) the graph.
//
// In order to catch bugs related to type access after this point we remove
// the types from the nodes at this point (currently only in Debug builds).
Run<UntyperPhase>();
RunPrintAndVerify("Untyped", true);
#endif
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment