Commit 9f545ea9 authored by littledan's avatar littledan Committed by Commit bot

[test] Remove local-tests from test262 archive and add to .isolate

This might help fix the bots, which are broken in e.g.,
https://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng_triggered/builds/14011

The archive was added in order to transmit test262 tests more rapidly.
It doesn't serve much of a purpose for local-tests. I naively added
local-tests there out of symmetry. However, the BUILD.gn file does not
regenerate an archive when files are only deleted and not added or
changed. Since the performance concern is not present for the small
volume of local-tests, this patch reverts to the more normal mechanism
for sending over dependencies, with test262.isolate.

R=adamk

Review-Url: https://codereview.chromium.org/2643983002
Cr-Commit-Position: refs/heads/master@{#42485}
parent 89b7a4d7
......@@ -29,7 +29,6 @@ def filter_git(tar_info):
with tarfile.open('data.tar', 'w') as tar:
tar.add('data', filter=filter_git)
tar.add('harness', filter=filter_git)
tar.add('local-tests')
# Workaround for GN. We can't specify the tarfile as output because it's
# not in the product directory. Therefore we track running of this script
......
......@@ -10,8 +10,7 @@ from itertools import chain
os.chdir(os.path.dirname(os.path.abspath(__file__)))
for root, dirs, files in chain(os.walk("data"), os.walk("harness"),
os.walk("local-tests")):
for root, dirs, files in chain(os.walk("data"), os.walk("harness")):
dirs[:] = [d for d in dirs if not d.endswith('.git')]
for name in files:
# These names are for gyp, which expects slashes on all platforms.
......
......@@ -9,6 +9,7 @@
'harness-adapt.js',
'test262.status',
'testcfg.py',
'local-tests/',
],
},
'includes': [
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment