Commit 9dc37ed0 authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

[wasm][debug] Reenable skipped debug-step-into-wasm test

The underlying issue was fixed in https://crrev.com/c/2144116 and
https://crrev.com/c/2142259. This reenabled the test generally. Note
that it's still skipped in special configurations. I will reevaluate
which of those can also be unskipped via separate CLs.

Drive-by: Fix the order of "expected" and "actual" values.

R=thibaudm@chromium.org

Bug: v8:10410
Change-Id: Idbdcc73d641661e96e12110dcf10b060e0cf47a1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2144070Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67145}
parent 1c3c5882
......@@ -85,8 +85,8 @@ Debug.setListener(listener2);
f();
Debug.setListener(null);
assertEquals(break_count, 3);
assertEquals(js_break_line, 3);
assertEquals(wasm_break_count, 4);
assertEquals(break_count2, 2);
assertEquals(3, break_count);
assertEquals(3, js_break_line);
assertEquals(4, wasm_break_count);
assertEquals(2, break_count2);
assertNull(exception);
......@@ -32,10 +32,6 @@
# forcing weak callback in asan build change break order
'debug/debug-stepin-builtin-callback': [['asan == True or msan == True', SKIP]],
# Flakes in different configurations, so skipped overall for now.
# clemensb is working on that: https://crbug.com/v8/10410
'debug/wasm/debug-step-into-wasm': [SKIP],
}], # ALWAYS
##############################################################################
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment