Commit 9d0a0936 authored by Milad Fa's avatar Milad Fa Committed by V8 LUCI CQ

PPC [flags] Protect individual flag updates

Port: f149912f

Drive-by: Defined EnqueueFunction under baseline-batch-compiler
for platforms without spakrplug support, currently getting
a link error when making a debug build.

Bug: v8:12887

Change-Id: I4fc8584ef09ad024280f7e40554a5e73a207b64f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3688474Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80972}
parent 4903f94c
......@@ -399,6 +399,10 @@ BaselineBatchCompiler::~BaselineBatchCompiler() {
void BaselineBatchCompiler::InstallBatch() { UNREACHABLE(); }
void BaselineBatchCompiler::EnqueueFunction(Handle<JSFunction> function) {
UNREACHABLE();
}
} // namespace baseline
} // namespace internal
} // namespace v8
......
......@@ -310,9 +310,10 @@ class Assembler : public AssemblerBase {
static constexpr int kMovInstructionsNoConstantPool = 2;
static constexpr int kTaggedLoadInstructions = 1;
#endif
static constexpr int kMovInstructions = FLAG_enable_embedded_constant_pool
? kMovInstructionsConstantPool
: kMovInstructionsNoConstantPool;
static constexpr int kMovInstructions =
FLAG_enable_embedded_constant_pool.value()
? kMovInstructionsConstantPool
: kMovInstructionsNoConstantPool;
static inline int encode_crbit(const CRegister& cr, enum CRBit crbit) {
return ((cr.code() * CRWIDTH) + crbit);
......
......@@ -16,9 +16,9 @@ namespace internal {
class EntryFrameConstants : public AllStatic {
public:
// Need to take constant pool into account.
static constexpr int kCallerFPOffset = FLAG_enable_embedded_constant_pool
? -4 * kSystemPointerSize
: -3 * kSystemPointerSize;
static constexpr int kCallerFPOffset =
FLAG_enable_embedded_constant_pool.value() ? -4 * kSystemPointerSize
: -3 * kSystemPointerSize;
};
class WasmCompileLazyFrameConstants : public TypedFrameConstants {
......
......@@ -46,11 +46,11 @@ namespace liftoff {
//
constexpr int32_t kInstanceOffset =
(FLAG_enable_embedded_constant_pool ? 3 : 2) * kSystemPointerSize;
(FLAG_enable_embedded_constant_pool.value() ? 3 : 2) * kSystemPointerSize;
constexpr int kFeedbackVectorOffset =
(FLAG_enable_embedded_constant_pool ? 4 : 3) * kSystemPointerSize;
(FLAG_enable_embedded_constant_pool.value() ? 4 : 3) * kSystemPointerSize;
constexpr int kTierupBudgetOffset =
(FLAG_enable_embedded_constant_pool ? 5 : 4) * kSystemPointerSize;
(FLAG_enable_embedded_constant_pool.value() ? 5 : 4) * kSystemPointerSize;
inline MemOperand GetHalfStackSlot(int offset, RegPairHalf half) {
int32_t half_offset =
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment