Commit 9c95863d authored by Michael Achenbach's avatar Michael Achenbach Committed by V8 LUCI CQ

[test] Better finish terminating workers

A call to cancel_join_thread() is removed as it is suspected to leave
the done_queue with garbled data on process join.

Bug: v8:13113
Change-Id: I85a736cee98d1c2a315efdd468cde216ad848c99
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3891251Reviewed-by: 's avatarLiviu Rau <liviurau@google.com>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/main@{#83132}
parent 053c172d
...@@ -93,11 +93,6 @@ def Worker(fn, work_queue, done_queue, ...@@ -93,11 +93,6 @@ def Worker(fn, work_queue, done_queue,
except Exception as e: except Exception as e:
logging.exception('Unhandled error during worker execution.') logging.exception('Unhandled error during worker execution.')
done_queue.put(ExceptionResult(e)) done_queue.put(ExceptionResult(e))
# When we reach here on normal tear down, all items have been pulled from
# the done_queue before and this should have no effect. On fast abort, it's
# possible that a fast worker left items on the done_queue in memory, which
# will never be pulled. This call purges those to avoid a deadlock.
done_queue.cancel_join_thread()
except KeyboardInterrupt: except KeyboardInterrupt:
assert False, 'Unreachable' assert False, 'Unreachable'
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment