Commit 9ba2a0a2 authored by Frank Tang's avatar Frank Tang Committed by Commit Bot

[Intl] Update the toStringTag for Intl.{List,RelativeTime}Format

Bug: v8:7993,v8:7994
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I058a2b8181b933dce9f71dab2b03304a424ae0ea
Reviewed-on: https://chromium-review.googlesource.com/1154237
Commit-Queue: Frank Tang <ftang@chromium.org>
Reviewed-by: 's avatarDaniel Ehrenberg <littledan@chromium.org>
Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54795}
parent c9525de5
...@@ -4531,7 +4531,7 @@ void Genesis::InitializeGlobal_harmony_intl_list_format() { ...@@ -4531,7 +4531,7 @@ void Genesis::InitializeGlobal_harmony_intl_list_format() {
// Install the @@toStringTag property on the {prototype}. // Install the @@toStringTag property on the {prototype}.
JSObject::AddProperty(isolate(), prototype, factory()->to_string_tag_symbol(), JSObject::AddProperty(isolate(), prototype, factory()->to_string_tag_symbol(),
factory()->Object_string(), factory()->NewStringFromStaticChars("Intl.ListFormat"),
static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY)); static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY));
SimpleInstallFunction(isolate(), prototype, "resolvedOptions", SimpleInstallFunction(isolate(), prototype, "resolvedOptions",
...@@ -4628,9 +4628,10 @@ void Genesis::InitializeGlobal_harmony_intl_relative_time_format() { ...@@ -4628,9 +4628,10 @@ void Genesis::InitializeGlobal_harmony_intl_relative_time_format() {
isolate()); isolate());
// Install the @@toStringTag property on the {prototype}. // Install the @@toStringTag property on the {prototype}.
JSObject::AddProperty(isolate(), prototype, factory()->to_string_tag_symbol(), JSObject::AddProperty(
factory()->Object_string(), isolate(), prototype, factory()->to_string_tag_symbol(),
static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY)); factory()->NewStringFromStaticChars("Intl.RelativeTimeFormat"),
static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY));
SimpleInstallFunction(isolate(), prototype, "resolvedOptions", SimpleInstallFunction(isolate(), prototype, "resolvedOptions",
Builtins::kRelativeTimeFormatPrototypeResolvedOptions, Builtins::kRelativeTimeFormatPrototypeResolvedOptions,
......
...@@ -476,6 +476,9 @@ ...@@ -476,6 +476,9 @@
'intl402/RelativeTimeFormat/constructor/supportedLocalesOf/name': [FAIL], 'intl402/RelativeTimeFormat/constructor/supportedLocalesOf/name': [FAIL],
'intl402/RelativeTimeFormat/constructor/supportedLocalesOf/prop-desc': [FAIL], 'intl402/RelativeTimeFormat/constructor/supportedLocalesOf/prop-desc': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7993
'intl402/RelativeTimeFormat/prototype/toStringTag/toStringTag': [FAIL],
# https://bugs.chromium.org/p/v8/issues/detail?id=7813 # https://bugs.chromium.org/p/v8/issues/detail?id=7813
'built-ins/Array/prototype/lastIndexOf/calls-only-has-on-prototype-after-length-zeroed': [FAIL], 'built-ins/Array/prototype/lastIndexOf/calls-only-has-on-prototype-after-length-zeroed': [FAIL],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment