Commit 9b8c71ea authored by yangguo@chromium.org's avatar yangguo@chromium.org

Add warning to cctest when running multiple tests in sequence.

R=mstarzinger@chromium.org
BUG=v8:2848

Review URL: https://codereview.chromium.org/23067008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16247 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 383a1672
...@@ -106,6 +106,13 @@ class CcTestArrayBufferAllocator : public v8::ArrayBuffer::Allocator { ...@@ -106,6 +106,13 @@ class CcTestArrayBufferAllocator : public v8::ArrayBuffer::Allocator {
}; };
static void SuggestTestHarness(int tests) {
if (tests == 0) return;
printf("Running multiple tests in sequence is deprecated and may cause "
"bogus failure. Consider using tools/run-tests.py instead.\n");
}
int main(int argc, char* argv[]) { int main(int argc, char* argv[]) {
v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true); v8::internal::FlagList::SetFlagsFromCommandLine(&argc, argv, true);
v8::internal::FLAG_harmony_array_buffer = true; v8::internal::FLAG_harmony_array_buffer = true;
...@@ -138,8 +145,8 @@ int main(int argc, char* argv[]) { ...@@ -138,8 +145,8 @@ int main(int argc, char* argv[]) {
if (test->enabled() if (test->enabled()
&& strcmp(test->file(), file) == 0 && strcmp(test->file(), file) == 0
&& strcmp(test->name(), name) == 0) { && strcmp(test->name(), name) == 0) {
SuggestTestHarness(tests_run++);
test->Run(); test->Run();
tests_run++;
} }
test = test->prev(); test = test->prev();
} }
...@@ -152,8 +159,8 @@ int main(int argc, char* argv[]) { ...@@ -152,8 +159,8 @@ int main(int argc, char* argv[]) {
if (test->enabled() if (test->enabled()
&& (strcmp(test->file(), file_or_name) == 0 && (strcmp(test->file(), file_or_name) == 0
|| strcmp(test->name(), file_or_name) == 0)) { || strcmp(test->name(), file_or_name) == 0)) {
SuggestTestHarness(tests_run++);
test->Run(); test->Run();
tests_run++;
} }
test = test->prev(); test = test->prev();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment