[turbofan] Pass CallFrequency by reference to work around GCC bug

This work-around got lost in the recent refactorings.

Bug: v8:8193
Change-Id: I81d22e0702666d1d8ef954cd3d074e22c89378cd
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609806
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#61468}

src/compiler/bytecode-graph-builder.cc

@@ -36,7 +36,7 @@ class BytecodeGraphBuilder {
                        Handle<SharedFunctionInfo> shared,
                        Handle<FeedbackVector> feedback_vector,
                        BailoutId osr_offset, JSGraph* jsgraph,
-                       CallFrequency invocation_frequency,
+                       CallFrequency const& invocation_frequency,
                        SourcePositionTable* source_positions,
                        Handle<Context> native_context, int inlining_id,
                        BytecodeGraphBuilderFlags flags);
@@ -942,7 +942,7 @@ BytecodeGraphBuilder::BytecodeGraphBuilder(
     Handle<BytecodeArray> bytecode_array,
     Handle<SharedFunctionInfo> shared_info,
     Handle<FeedbackVector> feedback_vector, BailoutId osr_offset,
-    JSGraph* jsgraph, CallFrequency invocation_frequency,
+    JSGraph* jsgraph, CallFrequency const& invocation_frequency,
     SourcePositionTable* source_positions, Handle<Context> native_context,
     int inlining_id, BytecodeGraphBuilderFlags flags)
     : broker_(broker),
@@ -4037,7 +4037,7 @@ void BuildGraphFromBytecode(JSHeapBroker* broker, Zone* local_zone,
                             Handle<SharedFunctionInfo> shared,
                             Handle<FeedbackVector> feedback_vector,
                             BailoutId osr_offset, JSGraph* jsgraph,
-                            CallFrequency invocation_frequency,
+                            CallFrequency const& invocation_frequency,
                             SourcePositionTable* source_positions,
                             Handle<Context> native_context, int inlining_id,
                             BytecodeGraphBuilderFlags flags) {

src/compiler/bytecode-graph-builder.h

@@ -30,12 +30,14 @@ enum class BytecodeGraphBuilderFlag : uint8_t {
 };
 using BytecodeGraphBuilderFlags = base::Flags<BytecodeGraphBuilderFlag>;
 
+// Note: {invocation_frequency} is taken by reference to work around a GCC bug
+// on AIX (v8:8193).
 void BuildGraphFromBytecode(JSHeapBroker* broker, Zone* local_zone,
                             Handle<BytecodeArray> bytecode_array,
                             Handle<SharedFunctionInfo> shared,
                             Handle<FeedbackVector> feedback_vector,
                             BailoutId osr_offset, JSGraph* jsgraph,
-                            CallFrequency invocation_frequency,
+                            CallFrequency const& invocation_frequency,
                             SourcePositionTable* source_positions,
                             Handle<Context> native_context, int inlining_id,
                             BytecodeGraphBuilderFlags flags);

src/compiler/js-inlining.cc

@@ -74,7 +74,7 @@ class JSCallAccessor {
     return call_->op()->ValueInputCount() - 2;
   }
 
-  CallFrequency frequency() const {
+  CallFrequency const& frequency() const {
     return (call_->opcode() == IrOpcode::kJSCall)
                ? CallParametersOf(call_->op()).frequency()
                : ConstructParametersOf(call_->op()).frequency();

src/compiler/js-operator.h

@@ -106,7 +106,7 @@ class ConstructParameters final {
       : arity_(arity), frequency_(frequency), feedback_(feedback) {}
 
   uint32_t arity() const { return arity_; }
-  CallFrequency frequency() const { return frequency_; }
+  CallFrequency const& frequency() const { return frequency_; }
   VectorSlotPair const& feedback() const { return feedback_; }
 
  private:

src/compiler/pipeline.cc

@@ -1071,11 +1071,12 @@ struct GraphBuilderPhase {
     if (data->info()->is_bailout_on_uninitialized()) {
       flags |= BytecodeGraphBuilderFlag::kBailoutOnUninitialized;
     }
+    CallFrequency frequency(1.0f);
     BuildGraphFromBytecode(
         data->broker(), temp_zone, data->info()->bytecode_array(),
         data->info()->shared_info(),
         handle(data->info()->closure()->feedback_vector(), data->isolate()),
-        data->info()->osr_offset(), data->jsgraph(), CallFrequency(1.0f),
+        data->info()->osr_offset(), data->jsgraph(), frequency,
         data->source_positions(), data->native_context(),
         SourcePosition::kNotInlined, flags);
   }