Commit 99d8b1fc authored by Clemens Backes's avatar Clemens Backes Committed by Commit Bot

Improve error message for unavailable --perf-prof

This currently runs into UNIMPLEMENTED. Since the fuzzer starts hitting
this, make the error message a bit nicer to spot this more easily.

R=ahaas@chromium.org

Bug: chromium:1035233
Change-Id: I63caac37e9b767fba9d6e4b71cb54a8a77b87ab9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991493Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65655}
parent 53dfeb88
...@@ -35,7 +35,7 @@ namespace internal { ...@@ -35,7 +35,7 @@ namespace internal {
#if V8_OS_LINUX #if V8_OS_LINUX
// Linux perf tool logging support // Linux perf tool logging support.
class PerfJitLogger : public CodeEventLogger { class PerfJitLogger : public CodeEventLogger {
public: public:
explicit PerfJitLogger(Isolate* isolate); explicit PerfJitLogger(Isolate* isolate);
...@@ -123,33 +123,34 @@ class PerfJitLogger : public CodeEventLogger { ...@@ -123,33 +123,34 @@ class PerfJitLogger : public CodeEventLogger {
#else #else
// PerfJitLogger is only implemented on Linux // PerfJitLogger is only implemented on Linux.
class PerfJitLogger : public CodeEventLogger { class PerfJitLogger : public CodeEventLogger {
public: public:
explicit PerfJitLogger(Isolate* isolate) : CodeEventLogger(isolate) {} explicit PerfJitLogger(Isolate* isolate) : CodeEventLogger(isolate) {}
void CodeMoveEvent(AbstractCode from, AbstractCode to) override { void CodeMoveEvent(AbstractCode from, AbstractCode to) override {
UNIMPLEMENTED(); FATAL("--perf-prof is only available on Linux");
} }
void CodeDisableOptEvent(Handle<AbstractCode> code, void CodeDisableOptEvent(Handle<AbstractCode> code,
Handle<SharedFunctionInfo> shared) override { Handle<SharedFunctionInfo> shared) override {
UNIMPLEMENTED(); FATAL("--perf-prof is only available on Linux");
} }
void LogRecordedBuffer(Handle<AbstractCode> code, void LogRecordedBuffer(Handle<AbstractCode> code,
MaybeHandle<SharedFunctionInfo> maybe_shared, MaybeHandle<SharedFunctionInfo> maybe_shared,
const char* name, int length) override { const char* name, int length) override {
UNIMPLEMENTED(); FATAL("--perf-prof is only available on Linux");
} }
void LogRecordedBuffer(const wasm::WasmCode* code, const char* name, void LogRecordedBuffer(const wasm::WasmCode* code, const char* name,
int length) override { int length) override {
UNIMPLEMENTED(); FATAL("--perf-prof is only available on Linux");
} }
}; };
#endif // V8_OS_LINUX #endif // V8_OS_LINUX
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment