Commit 98ba192d authored by Seth Brenith's avatar Seth Brenith Committed by Commit Bot

Use Torque-generated verifier for AllocationMemento

I originally marked AllocationMemento::allocation_site as @noVerifier
out of an abundance of caution because AllocationMemento::IsValid checks
whether allocation_site is an AllocationSite. However, I can't find any
way for allocation_site to not be an AllocationSite.

Bug: v8:9311
Change-Id: I8b7ab51978c90d9baff42dace28d176a1cd2921a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1653520Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#62120}
parent c6a16c10
...@@ -1284,7 +1284,7 @@ extern class FeedbackCell extends Struct { ...@@ -1284,7 +1284,7 @@ extern class FeedbackCell extends Struct {
type AllocationSite extends Struct; type AllocationSite extends Struct;
extern class AllocationMemento extends Struct { extern class AllocationMemento extends Struct {
@noVerifier allocation_site: AllocationSite; allocation_site: AllocationSite;
} }
extern class WasmModuleObject extends JSObject { extern class WasmModuleObject extends JSObject {
......
...@@ -1798,11 +1798,7 @@ void AllocationSite::AllocationSiteVerify(Isolate* isolate) { ...@@ -1798,11 +1798,7 @@ void AllocationSite::AllocationSiteVerify(Isolate* isolate) {
CHECK(nested_site().IsAllocationSite() || nested_site() == Smi::kZero); CHECK(nested_site().IsAllocationSite() || nested_site() == Smi::kZero);
} }
void AllocationMemento::AllocationMementoVerify(Isolate* isolate) { USE_TORQUE_VERIFIER(AllocationMemento)
TorqueGeneratedClassVerifiers::AllocationMementoVerify(*this, isolate);
VerifyHeapPointer(isolate, allocation_site());
CHECK(!IsValid() || GetAllocationSite().IsAllocationSite());
}
void Script::ScriptVerify(Isolate* isolate) { void Script::ScriptVerify(Isolate* isolate) {
TorqueGeneratedClassVerifiers::ScriptVerify(*this, isolate); TorqueGeneratedClassVerifiers::ScriptVerify(*this, isolate);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment