[wasm][cleanup] Using 'using' instead of 'typedef'

Even though both are allowed in the style guide, it recommends to use
'using', as its syntax is more consistent with the rest of C++.
This CL turns all typedefs in wasm code to 'using' declarations.

R=ahaas@chromium.org

Bug: v8:8834
Change-Id: Ibdce88a5cc31e0785cbc1b34088bd39aa3ec84b3
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1545890Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60519}

src/compiler/wasm-compiler.h

@@ -37,8 +37,8 @@ enum class TrapId : uint32_t;
 namespace wasm {
 struct DecodeStruct;
 // Expose {Node} and {Graph} opaquely as {wasm::TFNode} and {wasm::TFGraph}.
-typedef compiler::Node TFNode;
-typedef compiler::MachineGraph TFGraph;
+using TFNode = compiler::Node;
+using TFGraph = compiler::MachineGraph;
 class WasmCode;
 struct WasmFeatures;
 }  // namespace wasm

src/wasm/decoder.h

@@ -341,7 +341,7 @@ class Decoder {
       DCHECK_LT(pc, end_);
       b = *pc;
       TRACE_IF(trace, "%02x ", b);
-      typedef typename std::make_unsigned<IntType>::type Unsigned;
+      using Unsigned = typename std::make_unsigned<IntType>::type;
       result = result |
                (static_cast<Unsigned>(static_cast<IntType>(b) & 0x7f) << shift);
     }

src/wasm/module-decoder.h

@@ -27,18 +27,18 @@ inline bool IsValidSectionCode(uint8_t byte) {
 
 const char* SectionName(SectionCode code);
 
-typedef Result<std::shared_ptr<WasmModule>> ModuleResult;
-typedef Result<std::unique_ptr<WasmFunction>> FunctionResult;
-typedef std::vector<std::pair<int, int>> FunctionOffsets;
-typedef Result<FunctionOffsets> FunctionOffsetsResult;
+using ModuleResult = Result<std::shared_ptr<WasmModule>>;
+using FunctionResult = Result<std::unique_ptr<WasmFunction>>;
+using FunctionOffsets = std::vector<std::pair<int, int>>;
+using FunctionOffsetsResult = Result<FunctionOffsets>;
 
 struct AsmJsOffsetEntry {
   int byte_offset;
   int source_position_call;
   int source_position_number_conversion;
 };
-typedef std::vector<std::vector<AsmJsOffsetEntry>> AsmJsOffsets;
-typedef Result<AsmJsOffsets> AsmJsOffsetsResult;
+using AsmJsOffsets = std::vector<std::vector<AsmJsOffsetEntry>>;
+using AsmJsOffsetsResult = Result<AsmJsOffsets>;
 
 struct LocalName {
   int local_index;

src/wasm/wasm-external-refs.h

@@ -71,7 +71,7 @@ void memory_copy_wrapper(Address dst, Address src, uint32_t size);
 
 void memory_fill_wrapper(Address dst, uint32_t value, uint32_t size);
 
-typedef void (*WasmTrapCallbackForTesting)();
+using WasmTrapCallbackForTesting = void (*)();
 
 V8_EXPORT_PRIVATE void set_trap_callback_for_testing(
     WasmTrapCallbackForTesting callback);

src/wasm/wasm-module.h

@@ -72,7 +72,7 @@ struct WasmGlobal {
 
 // Note: An exception signature only uses the params portion of a
 // function signature.
-typedef FunctionSig WasmExceptionSig;
+using WasmExceptionSig = FunctionSig;
 
 // Static representation of a wasm exception type.
 struct WasmException {

test/cctest/wasm/test-run-wasm-simd.cc

@@ -19,21 +19,21 @@ namespace test_run_wasm_simd {
 
 namespace {
 
-typedef float (*FloatUnOp)(float);
-typedef float (*FloatBinOp)(float, float);
-typedef int (*FloatCompareOp)(float, float);
-typedef int32_t (*Int32UnOp)(int32_t);
-typedef int32_t (*Int32BinOp)(int32_t, int32_t);
-typedef int (*Int32CompareOp)(int32_t, int32_t);
-typedef int32_t (*Int32ShiftOp)(int32_t, int);
-typedef int16_t (*Int16UnOp)(int16_t);
-typedef int16_t (*Int16BinOp)(int16_t, int16_t);
-typedef int (*Int16CompareOp)(int16_t, int16_t);
-typedef int16_t (*Int16ShiftOp)(int16_t, int);
-typedef int8_t (*Int8UnOp)(int8_t);
-typedef int8_t (*Int8BinOp)(int8_t, int8_t);
-typedef int (*Int8CompareOp)(int8_t, int8_t);
-typedef int8_t (*Int8ShiftOp)(int8_t, int);
+using FloatUnOp = float (*)(float);
+using FloatBinOp = float (*)(float, float);
+using FloatCompareOp = int (*)(float, float);
+using Int32UnOp = int32_t (*)(int32_t);
+using Int32BinOp = int32_t (*)(int32_t, int32_t);
+using Int32CompareOp = int (*)(int32_t, int32_t);
+using Int32ShiftOp = int32_t (*)(int32_t, int);
+using Int16UnOp = int16_t (*)(int16_t);
+using Int16BinOp = int16_t (*)(int16_t, int16_t);
+using Int16CompareOp = int (*)(int16_t, int16_t);
+using Int16ShiftOp = int16_t (*)(int16_t, int);
+using Int8UnOp = int8_t (*)(int8_t);
+using Int8BinOp = int8_t (*)(int8_t, int8_t);
+using Int8CompareOp = int (*)(int8_t, int8_t);
+using Int8ShiftOp = int8_t (*)(int8_t, int);
 
 #define WASM_SIMD_TEST(name)                                          \
   void RunWasm_##name##_Impl(LowerSimd lower_simd,                    \

test/cctest/wasm/test-wasm-codegen.cc

@@ -47,7 +47,7 @@ bool TrueCallback(Local<v8::Context>, Local<v8::String>) { return true; }
 
 bool FalseCallback(Local<v8::Context>, Local<v8::String>) { return false; }
 
-typedef bool (*CallbackFn)(Local<v8::Context>, Local<v8::String>);
+using CallbackFn = bool (*)(Local<v8::Context>, Local<v8::String>);
 
 // Defines the Callback to use for the corresponding TestValue.
 CallbackFn Callback[kNumTestValues] = {nullptr, FalseCallback, TrueCallback};

test/cctest/wasm/wasm-atomics-utils.h

@@ -21,10 +21,10 @@ namespace wasm {
   V(Xor)                  \
   V(Exchange)
 
-typedef uint64_t (*Uint64BinOp)(uint64_t, uint64_t);
-typedef uint32_t (*Uint32BinOp)(uint32_t, uint32_t);
-typedef uint16_t (*Uint16BinOp)(uint16_t, uint16_t);
-typedef uint8_t (*Uint8BinOp)(uint8_t, uint8_t);
+using Uint64BinOp = uint64_t (*)(uint64_t, uint64_t);
+using Uint32BinOp = uint32_t (*)(uint32_t, uint32_t);
+using Uint16BinOp = uint16_t (*)(uint16_t, uint16_t);
+using Uint8BinOp = uint8_t (*)(uint8_t, uint8_t);
 
 template <typename T>
 T Add(T a, T b) {

test/fuzzer/wasm-compile.cc

@@ -21,8 +21,6 @@
 #include "test/fuzzer/fuzzer-support.h"
 #include "test/fuzzer/wasm-fuzzer-common.h"
 
-typedef uint8_t byte;
-
 namespace v8 {
 namespace internal {
 namespace wasm {

test/unittests/wasm/function-body-decoder-unittest.cc

@@ -57,7 +57,7 @@ static const WasmOpcode kInt32BinopOpcodes[] = {
 
 class FunctionBodyDecoderTest : public TestWithZone {
  public:
-  typedef std::pair<uint32_t, ValueType> LocalsDecl;
+  using LocalsDecl = std::pair<uint32_t, ValueType>;
   // All features are disabled by default and must be activated with
   // a WASM_FEATURE_SCOPE in individual tests.
   WasmFeatures enabled_features_;
@@ -3384,7 +3384,7 @@ TEST_F(WasmOpcodeLengthTest, SimdExpressions) {
   ExpectLength(2, kSimdPrefix, 0xFF);
 }
 
-typedef ZoneVector<ValueType> TypesOfLocals;
+using TypesOfLocals = ZoneVector<ValueType>;
 
 class LocalDeclDecoderTest : public TestWithZone {
  public: