Commit 989285b7 authored by Sergiy Byelozyorov's avatar Sergiy Byelozyorov Committed by Commit Bot

[tools] Add benchmark owners to the config

R=machenbach@chromium.org

No-Try: true
Bug: chromium:826280
Change-Id: Ic34d13170dfecdd9e791974a34c33ba0248c7a38
Reviewed-on: https://chromium-review.googlesource.com/1053809Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53138}
parent b2dc9468
{ {
"owners": ["jarin@chromium.org", "mvstanston@chromium.org"],
"name": "JSTests", "name": "JSTests",
"run_count": 3, "run_count": 3,
"run_count_arm": 1, "run_count_arm": 1,
......
{ {
"owners": ["jgruber@chromium.org", "yangguo@chromium.org"],
"name": "RegExp", "name": "RegExp",
"run_count": 3, "run_count": 3,
"run_count_arm": 1, "run_count_arm": 1,
......
{ {
"owners": ["jarin@chromium.org", "mvstanston@chromium.org"],
"name": "SixSpeed", "name": "SixSpeed",
"run_count": 3, "run_count": 3,
"run_count_arm": 1, "run_count_arm": 1,
......
{ {
"owners": ["yangguo@chromium.org"],
"name": "Memory", "name": "Memory",
"run_count": 5, "run_count": 5,
"units": "bytes", "units": "bytes",
......
...@@ -11,6 +11,7 @@ Call e.g. with tools/run-perf.py --arch ia32 some_suite.json ...@@ -11,6 +11,7 @@ Call e.g. with tools/run-perf.py --arch ia32 some_suite.json
The suite json format is expected to be: The suite json format is expected to be:
{ {
"path": <relative path chunks to perf resources and main file>, "path": <relative path chunks to perf resources and main file>,
"owners": [<list of email addresses of benchmark owners (required)>],
"name": <optional suite name, file name is default>, "name": <optional suite name, file name is default>,
"archs": [<architecture name for which this suite is run>, ...], "archs": [<architecture name for which this suite is run>, ...],
"binary": <name of binary to run, default "d8">, "binary": <name of binary to run, default "d8">,
...@@ -55,6 +56,7 @@ A suite without "tests" is considered a performance test itself. ...@@ -55,6 +56,7 @@ A suite without "tests" is considered a performance test itself.
Full example (suite with one runner): Full example (suite with one runner):
{ {
"path": ["."], "path": ["."],
"owner": ["username@chromium.org"],
"flags": ["--expose-gc"], "flags": ["--expose-gc"],
"test_flags": ["5"], "test_flags": ["5"],
"archs": ["ia32", "x64"], "archs": ["ia32", "x64"],
...@@ -74,6 +76,7 @@ Full example (suite with one runner): ...@@ -74,6 +76,7 @@ Full example (suite with one runner):
Full example (suite with several runners): Full example (suite with several runners):
{ {
"path": ["."], "path": ["."],
"owner": ["username@chromium.org", "otherowner@google.com"],
"flags": ["--expose-gc"], "flags": ["--expose-gc"],
"archs": ["ia32", "x64"], "archs": ["ia32", "x64"],
"run_count": 5, "run_count": 5,
...@@ -401,6 +404,7 @@ class GraphConfig(Node): ...@@ -401,6 +404,7 @@ class GraphConfig(Node):
self._suite = suite self._suite = suite
assert isinstance(suite.get("path", []), list) assert isinstance(suite.get("path", []), list)
assert isinstance(suite.get("owners", []), list)
assert isinstance(suite["name"], basestring) assert isinstance(suite["name"], basestring)
assert isinstance(suite.get("flags", []), list) assert isinstance(suite.get("flags", []), list)
assert isinstance(suite.get("test_flags", []), list) assert isinstance(suite.get("test_flags", []), list)
...@@ -411,6 +415,7 @@ class GraphConfig(Node): ...@@ -411,6 +415,7 @@ class GraphConfig(Node):
self.graphs = parent.graphs[:] + [suite["name"]] self.graphs = parent.graphs[:] + [suite["name"]]
self.flags = parent.flags[:] + suite.get("flags", []) self.flags = parent.flags[:] + suite.get("flags", [])
self.test_flags = parent.test_flags[:] + suite.get("test_flags", []) self.test_flags = parent.test_flags[:] + suite.get("test_flags", [])
self.owners = parent.owners[:] + suite.get("owners", [])
# Values independent of parent node. # Values independent of parent node.
self.resources = suite.get("resources", []) self.resources = suite.get("resources", [])
...@@ -451,6 +456,7 @@ class TraceConfig(GraphConfig): ...@@ -451,6 +456,7 @@ class TraceConfig(GraphConfig):
def __init__(self, suite, parent, arch): def __init__(self, suite, parent, arch):
super(TraceConfig, self).__init__(suite, parent, arch) super(TraceConfig, self).__init__(suite, parent, arch)
assert self.results_regexp assert self.results_regexp
assert self.owners
def CreateMeasurement(self, perform_measurement): def CreateMeasurement(self, perform_measurement):
if not perform_measurement: if not perform_measurement:
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment