[builtins] Properly mark transitioning external macros.

Change-Id: Ic31b33ef4c290aee31be2d66295978908f568775
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1563410Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Peter Wong <peter.wm.wong@gmail.com>
Cr-Commit-Position: refs/heads/master@{#60775}

src/builtins/array-lastindexof.tq

@@ -58,8 +58,8 @@ namespace array_lastindexof {
     return -1;
   }
 
-  macro GetFromIndex(context: Context, length: Number, arguments: Arguments):
-      Number {
+  transitioning macro
+  GetFromIndex(context: Context, length: Number, arguments: Arguments): Number {
     // 4. If fromIndex is present, let n be ? ToInteger(fromIndex);
     //    else let n be len - 1.
     const n: Number = arguments.length < 2 ?

src/builtins/base.tq

@@ -925,17 +925,18 @@ extern macro Print(constexpr string, Object);
 extern macro Comment(constexpr string);
 extern macro Print(Object);
 extern macro DebugBreak();
-extern macro ToInteger_Inline(Context, Object): Number;
-extern macro ToInteger_Inline(
+extern transitioning macro ToInteger_Inline(Context, Object): Number;
+extern transitioning macro ToInteger_Inline(
     Context, Object, constexpr ToIntegerTruncationMode): Number;
-extern macro ToLength_Inline(Context, Object): Number;
-extern macro ToNumber_Inline(Context, Object): Number;
-extern macro ToSmiIndex(implicit context: Context)(Object): PositiveSmi
-    labels IfRangeError;
-extern macro ToSmiLength(implicit context: Context)(Object): PositiveSmi
-    labels IfRangeError;
-extern macro ToString_Inline(Context, Object): String;
-extern macro ToThisString(implicit context: Context)(Object, String): String;
+extern transitioning macro ToLength_Inline(Context, Object): Number;
+extern transitioning macro ToNumber_Inline(Context, Object): Number;
+extern transitioning macro ToSmiIndex(implicit context: Context)(Object):
+    PositiveSmi labels IfRangeError;
+extern transitioning macro ToSmiLength(implicit context: Context)(Object):
+    PositiveSmi labels IfRangeError;
+extern transitioning macro ToString_Inline(Context, Object): String;
+extern transitioning macro ToThisString(implicit context: Context)(
+    Object, String): String;
 extern transitioning macro GetProperty(implicit context: Context)(
     Object, Object): Object;
 extern transitioning builtin SetProperty(implicit context: Context)(
@@ -2149,7 +2150,7 @@ macro ToBoolean(obj: Object): bool {
   }
 }
 
-macro ToIndex(input: Object, context: Context): Number
+transitioning macro ToIndex(input: Object, context: Context): Number
     labels RangeError {
   if (input == Undefined) {
     return 0;

src/builtins/data-view.tq

@@ -382,7 +382,7 @@ namespace data_view {
   extern macro DataViewBuiltinsAssembler::DataViewElementSize(
       constexpr ElementsKind): constexpr int31;
 
-  macro DataViewGet(
+  transitioning macro DataViewGet(
       context: Context, receiver: Object, offset: Object,
       requestedLittleEndian: Object, kind: constexpr ElementsKind): Numeric {
     let dataView: JSDataView =
@@ -441,19 +441,19 @@ namespace data_view {
     }
   }
 
-  javascript builtin DataViewPrototypeGetUint8(
+  transitioning javascript builtin DataViewPrototypeGetUint8(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     return DataViewGet(context, receiver, offset, Undefined, UINT8_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetInt8(
+  transitioning javascript builtin DataViewPrototypeGetInt8(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     return DataViewGet(context, receiver, offset, Undefined, INT8_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetUint16(
+  transitioning javascript builtin DataViewPrototypeGetUint16(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let isLittleEndian: Object =
@@ -462,7 +462,7 @@ namespace data_view {
         context, receiver, offset, isLittleEndian, UINT16_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetInt16(
+  transitioning javascript builtin DataViewPrototypeGetInt16(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let isLittleEndian: Object =
@@ -471,7 +471,7 @@ namespace data_view {
         context, receiver, offset, isLittleEndian, INT16_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetUint32(
+  transitioning javascript builtin DataViewPrototypeGetUint32(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let isLittleEndian: Object =
@@ -480,7 +480,7 @@ namespace data_view {
         context, receiver, offset, isLittleEndian, UINT32_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetInt32(
+  transitioning javascript builtin DataViewPrototypeGetInt32(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let isLittleEndian: Object =
@@ -489,7 +489,7 @@ namespace data_view {
         context, receiver, offset, isLittleEndian, INT32_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetFloat32(
+  transitioning javascript builtin DataViewPrototypeGetFloat32(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let isLittleEndian: Object =
@@ -498,7 +498,7 @@ namespace data_view {
         context, receiver, offset, isLittleEndian, FLOAT32_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetFloat64(
+  transitioning javascript builtin DataViewPrototypeGetFloat64(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let isLittleEndian: Object =
@@ -507,7 +507,7 @@ namespace data_view {
         context, receiver, offset, isLittleEndian, FLOAT64_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetBigUint64(
+  transitioning javascript builtin DataViewPrototypeGetBigUint64(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let isLittleEndian: Object =
@@ -516,7 +516,7 @@ namespace data_view {
         context, receiver, offset, isLittleEndian, BIGUINT64_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeGetBigInt64(
+  transitioning javascript builtin DataViewPrototypeGetBigInt64(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let isLittleEndian: Object =
@@ -659,7 +659,7 @@ namespace data_view {
     StoreDataView64(buffer, offset, lowWord, highWord, requestedLittleEndian);
   }
 
-  macro DataViewSet(
+  transitioning macro DataViewSet(
       context: Context, receiver: Object, offset: Object, value: Object,
       requestedLittleEndian: Object, kind: constexpr ElementsKind): Object {
     let dataView: JSDataView =
@@ -745,7 +745,7 @@ namespace data_view {
     return Undefined;
   }
 
-  javascript builtin DataViewPrototypeSetUint8(
+  transitioning javascript builtin DataViewPrototypeSetUint8(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -753,7 +753,7 @@ namespace data_view {
         context, receiver, offset, value, Undefined, UINT8_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetInt8(
+  transitioning javascript builtin DataViewPrototypeSetInt8(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -761,7 +761,7 @@ namespace data_view {
         context, receiver, offset, value, Undefined, INT8_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetUint16(
+  transitioning javascript builtin DataViewPrototypeSetUint16(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -771,7 +771,7 @@ namespace data_view {
         context, receiver, offset, value, isLittleEndian, UINT16_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetInt16(
+  transitioning javascript builtin DataViewPrototypeSetInt16(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -781,7 +781,7 @@ namespace data_view {
         context, receiver, offset, value, isLittleEndian, INT16_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetUint32(
+  transitioning javascript builtin DataViewPrototypeSetUint32(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -791,7 +791,7 @@ namespace data_view {
         context, receiver, offset, value, isLittleEndian, UINT32_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetInt32(
+  transitioning javascript builtin DataViewPrototypeSetInt32(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -801,7 +801,7 @@ namespace data_view {
         context, receiver, offset, value, isLittleEndian, INT32_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetFloat32(
+  transitioning javascript builtin DataViewPrototypeSetFloat32(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -811,7 +811,7 @@ namespace data_view {
         context, receiver, offset, value, isLittleEndian, FLOAT32_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetFloat64(
+  transitioning javascript builtin DataViewPrototypeSetFloat64(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -821,7 +821,7 @@ namespace data_view {
         context, receiver, offset, value, isLittleEndian, FLOAT64_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetBigUint64(
+  transitioning javascript builtin DataViewPrototypeSetBigUint64(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;
@@ -831,7 +831,7 @@ namespace data_view {
         context, receiver, offset, value, isLittleEndian, BIGUINT64_ELEMENTS);
   }
 
-  javascript builtin DataViewPrototypeSetBigInt64(
+  transitioning javascript builtin DataViewPrototypeSetBigInt64(
       context: Context, receiver: Object, ...arguments): Object {
     let offset: Object = arguments.length > 0 ? arguments[0] : Undefined;
     let value: Object = arguments.length > 1 ? arguments[1] : Undefined;

src/builtins/string-html.tq

@@ -6,7 +6,7 @@ namespace string_html {
   extern runtime StringEscapeQuotes(Context, String): String;
 
   // https://tc39.github.io/ecma262/#sec-createhtml
-  builtin CreateHTML(implicit context: Context)(
+  transitioning builtin CreateHTML(implicit context: Context)(
       receiver: Object, methodName: String, tagName: String, attr: String,
       attrValue: Object): String {
     const tagContents: String = ToThisString(receiver, methodName);
@@ -21,21 +21,21 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.anchor
-  javascript builtin StringPrototypeAnchor(
+  transitioning javascript builtin StringPrototypeAnchor(
       context: Context, receiver: Object, ...arguments): String {
     return CreateHTML(
         receiver, 'String.prototype.anchor', 'a', 'name', arguments[0]);
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.big
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeBig(context: Context, receiver: Object, ...arguments): String {
     return CreateHTML(
         receiver, 'String.prototype.big', 'big', kEmptyString, kEmptyString);
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.blink
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeBlink(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -44,7 +44,7 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.bold
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeBold(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -52,7 +52,7 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.fontcolor
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeFontcolor(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -60,7 +60,7 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.fontsize
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeFontsize(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -68,7 +68,7 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.fixed
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeFixed(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -76,7 +76,7 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.italics
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeItalics(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -84,7 +84,7 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.link
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeLink(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -92,7 +92,7 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.small
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeSmall(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -101,7 +101,7 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.strike
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeStrike(context: Context, receiver: Object, ...arguments):
       String {
     return CreateHTML(
@@ -110,14 +110,14 @@ namespace string_html {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.sub
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeSub(context: Context, receiver: Object, ...arguments): String {
     return CreateHTML(
         receiver, 'String.prototype.sub', 'sub', kEmptyString, kEmptyString);
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.sup
-  javascript builtin
+  transitioning javascript builtin
   StringPrototypeSup(context: Context, receiver: Object, ...arguments): String {
     return CreateHTML(
         receiver, 'String.prototype.sup', 'sup', kEmptyString, kEmptyString);

src/builtins/string-repeat.tq

@@ -27,7 +27,7 @@ namespace string_repeat {
   }
 
   // https://tc39.github.io/ecma262/#sec-string.prototype.repeat
-  javascript builtin StringPrototypeRepeat(
+  transitioning javascript builtin StringPrototypeRepeat(
       context: Context, receiver: Object, count: Object): String {
     // 1. Let O be ? RequireObjectCoercible(this value).
     // 2. Let S be ? ToString(O).

src/builtins/typed-array-createtypedarray.tq

@@ -171,7 +171,7 @@ namespace typed_array_createtypedarray {
 
   // 22.2.4.5 TypedArray ( buffer, byteOffset, length )
   // ES #sec-typedarray-buffer-byteoffset-length
-  macro ConstructByArrayBuffer(implicit context: Context)(
+  transitioning macro ConstructByArrayBuffer(implicit context: Context)(
       typedArray: JSTypedArray, buffer: JSArrayBuffer, byteOffset: Object,
       length: Object, elementsInfo: typed_array::TypedArrayElementsInfo): void {
     try {

third_party/v8/builtins/array-sort.tq

@@ -92,7 +92,7 @@ namespace array {
     tempArray: FixedArray;
   }
 
-  macro NewSortState(implicit context: Context)(
+  transitioning macro NewSortState(implicit context: Context)(
       receiver: JSReceiver, comparefn: Undefined | Callable,
       initialReceiverLength: Number, sortLength: Smi,
       forceGeneric: constexpr bool): SortState {
@@ -291,7 +291,7 @@ namespace array {
     }
   }
 
-  builtin SortCompareDefault(
+  transitioning builtin SortCompareDefault(
       context: Context, comparefn: Object, x: Object, y: Object): Number {
     assert(comparefn == Undefined);