Commit 97204f8e authored by Mythri A's avatar Mythri A Committed by Commit Bot

[lite] Don't skip tests that need feedback vector in lite mode

Tests that expect type feedback vector ensure it by using
%EnsureFeedbackVector intrinsic. These tests now work with lazy feedback
allocation as well. Hence it is no longer required to initialize the
shared function info with a special bailout id.

Bug: v8:8394
Change-Id: Iba2f94be7e5651b4faeb8b3bf604d17fb4b146ef
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1609542Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61509}
parent c7ca8dac
......@@ -471,23 +471,6 @@
##############################################################################
['lite_mode or variant == jitless', {
# TODO(8394): First execution events don't work in lite_mode. Enable this after
# we fix the lite mode to track the first execution.
'test-log/LogFunctionEvents': [SKIP],
# Skip tests for weak references in feedback vector.
'test-weak-references/WeakReferencesBasic': [SKIP],
'test-weak-references/WeakReferencesOldToOld': [SKIP],
'test-weak-references/WeakReferencesOldToNew': [SKIP],
'test-weak-references/WeakReferencesOldToNewScavenged': [SKIP],
'test-weak-references/WeakReferencesOldToCleared': [SKIP],
'test-weak-references/ObjectMovesBeforeClearingWeakField': [SKIP],
'test-weak-references/ObjectWithWeakFieldDies': [SKIP],
'test-weak-references/ObjectWithWeakReferencePromoted': [SKIP],
'test-weak-references/ObjectWithClearedWeakReferencePromoted': [SKIP],
'test-weak-references/WeakReferenceWriteBarrier': [SKIP],
'test-heap-profiler/WeakReference': [SKIP],
# Slow tests
'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [SKIP],
......
......@@ -3861,8 +3861,6 @@ void CheckNumberOfAllocations(Heap* heap, const char* source,
}
TEST(AllocationSiteCreation) {
// No feedback vectors and hence no allocation sites.
if (FLAG_lite_mode) return;
FLAG_always_opt = false;
CcTest::InitializeVM();
Isolate* isolate = CcTest::i_isolate();
......@@ -4374,7 +4372,6 @@ static void ClearWeakIC(
TEST(WeakFunctionInConstructor) {
if (FLAG_lite_mode) return;
if (FLAG_always_opt) return;
FLAG_stress_compaction = false;
FLAG_stress_incremental_marking = false;
......
......@@ -31,10 +31,8 @@ InterpreterTester::InterpreterTester(
InterpreterTester::InterpreterTester(
Isolate* isolate, Handle<BytecodeArray> bytecode,
MaybeHandle<FeedbackMetadata> feedback_metadata, const char* filter)
: InterpreterTester(
isolate, nullptr, bytecode,
FLAG_lite_mode ? MaybeHandle<FeedbackMetadata>() : feedback_metadata,
filter) {}
: InterpreterTester(isolate, nullptr, bytecode, feedback_metadata, filter) {
}
InterpreterTester::InterpreterTester(Isolate* isolate, const char* source,
const char* filter)
......
......@@ -628,8 +628,6 @@ TEST(InterpreterParameter8) {
}
TEST(InterpreterBinaryOpTypeFeedback) {
if (FLAG_lite_mode) return;
HandleAndZoneScope handles;
i::Isolate* isolate = handles.main_isolate();
Zone* zone = handles.main_zone();
......@@ -762,8 +760,6 @@ TEST(InterpreterBinaryOpTypeFeedback) {
}
TEST(InterpreterBinaryOpSmiTypeFeedback) {
if (FLAG_lite_mode) return;
HandleAndZoneScope handles;
i::Isolate* isolate = handles.main_isolate();
Zone* zone = handles.main_zone();
......@@ -870,8 +866,6 @@ TEST(InterpreterBinaryOpSmiTypeFeedback) {
}
TEST(InterpreterUnaryOpFeedback) {
if (FLAG_lite_mode) return;
HandleAndZoneScope handles;
i::Isolate* isolate = handles.main_isolate();
Zone* zone = handles.main_zone();
......@@ -958,8 +952,6 @@ TEST(InterpreterUnaryOpFeedback) {
}
TEST(InterpreterBitwiseTypeFeedback) {
if (FLAG_lite_mode) return;
HandleAndZoneScope handles;
i::Isolate* isolate = handles.main_isolate();
Zone* zone = handles.main_zone();
......
......@@ -4067,8 +4067,6 @@ UNINITIALIZED_TEST(DebugSetOutOfMemoryListener) {
}
TEST(DebugCoverage) {
// Coverage needs feedback vectors.
if (i::FLAG_lite_mode) return;
i::FLAG_always_opt = false;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
......@@ -4123,8 +4121,6 @@ v8::debug::Coverage::ScriptData GetScriptDataAndDeleteCoverage(
} // namespace
TEST(DebugCoverageWithCoverageOutOfScope) {
// Coverage needs feedback vectors.
if (i::FLAG_lite_mode) return;
i::FLAG_always_opt = false;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
......@@ -4195,8 +4191,6 @@ v8::debug::Coverage::FunctionData GetFunctionDataAndDeleteCoverage(
} // namespace
TEST(DebugCoverageWithScriptDataOutOfScope) {
// Coverage needs feedback vectors.
if (i::FLAG_lite_mode) return;
i::FLAG_always_opt = false;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
......
......@@ -2447,8 +2447,6 @@ TEST(ManyLocalsInSharedContext) {
TEST(AllocationSitesAreVisible) {
if (i::FLAG_lite_mode) return;
LocalContext env;
v8::Isolate* isolate = env->GetIsolate();
v8::HandleScope scope(isolate);
......
......@@ -332,23 +332,6 @@
['lite_mode or variant == jitless', {
# Skip tests not suitable for lite_mode.
# TODO(8596): We cache the templates in the feedback vector. In lite mode
# without feedback vectors we need to implement some other mechanism to cache
# them. Enable this test after fixing it.
'es6/templates': [SKIP],
# code coverage needs feedback vectors
'code-coverage-ad-hoc': [SKIP],
'code-coverage-class-fields': [SKIP],
'code-coverage-block-noopt': [SKIP],
'code-coverage-block': [SKIP],
'code-coverage-precise': [SKIP],
# Needs feedback vector - tests for allocation sites
'array-constructor-feedback': [SKIP],
'regress/regress-trap-allocation-memento': [SKIP],
'regress/regress-4121': [SKIP],
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
'regress/regress-5888': [SKIP],
'regress/regress-5911': [SKIP],
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment