[object-stats] Fix heap visualizer

R: hpayer@chromium.org
No-try: true
Bug: v8:7266
Change-Id: Icc8f254d4f4e7c220cc322b3c98749da5e5ea3e6
Reviewed-on: https://chromium-review.googlesource.com/866831
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#50594}

tools/heap-stats/categories.js

@@ -102,7 +102,7 @@ const CATEGORIES = new Map([
       'INTERCEPTOR_INFO_TYPE',
       'JS_API_OBJECT_TYPE',
       'JS_ARRAY_BOILERPLATE_TYPE',
-      'JS_OBJECT_BOILERPLATE_TYPE'
+      'JS_OBJECT_BOILERPLATE_TYPE',
       'JS_SPECIAL_API_OBJECT_TYPE',
       'MAP_TYPE',
       'OBJECT_TEMPLATE_INFO_TYPE',

tools/heap-stats/details-selection.js

@@ -84,6 +84,11 @@ class DetailsSelection extends HTMLElement {
 
   handleIsolateChange(e) {
     this.selection.isolate = this.isolateSelect.value;
+    if (this.selection.isolate.length === 0) {
+      this.selection.isolate = null;
+      return;
+    }
+
     this.populateSelect(
         '#dataset-select', this.data[this.selection.isolate].data_sets, 'live');
     this.populateCategories();

tools/heap-stats/global-timeline.js

@@ -44,8 +44,20 @@ class GlobalTimeline extends HTMLElement {
     return this.data && this.selection;
   }
 
+  hide() {
+    this.$('#container').style.display = 'none';
+  }
+
+  show() {
+    this.$('#container').style.display = 'block';
+  }
+
   stateChanged() {
-    if (this.isValid()) this.drawChart();
+    if (this.isValid()) {
+      this.drawChart();
+    } else {
+      this.hide();
+    }
   }
 
   getCategoryData() {
@@ -115,7 +127,7 @@ class GlobalTimeline extends HTMLElement {
       explorer: {},
     };
     const chart = new google.visualization.AreaChart(this.$('#chart'));
-    this.$('#container').style.display = 'block';
+    this.show();
     chart.draw(data, google.charts.Line.convertOptions(options));
   }
 }