Commit 94a9ebb0 authored by kasperl@chromium.org's avatar kasperl@chromium.org

Change the name of the Object.prototype.inherits function in

the DeltaBlue benchmark to inheritsFrom to avoid name clashes
when running in Chromium with extensions enabled.

See http://crbug.com/11797. 
Review URL: http://codereview.chromium.org/155205

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2386 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent d4511a3a
...@@ -57,4 +57,7 @@ of the benchmark. ...@@ -57,4 +57,7 @@ of the benchmark.
Changes from Version 4 to Version 5 Changes from Version 4 to Version 5
=================================== ===================================
Removed duplicate line in random seed code. Removed duplicate line in random seed code, and changed the name of
the Object.prototype.inherits function in the DeltaBlue benchmark to
inheritsFrom to avoid name clashes when running in Chromium with
extensions enabled.
...@@ -46,7 +46,7 @@ var DeltaBlue = new BenchmarkSuite('DeltaBlue', 71104, [ ...@@ -46,7 +46,7 @@ var DeltaBlue = new BenchmarkSuite('DeltaBlue', 71104, [
/* --- O b j e c t M o d e l --- */ /* --- O b j e c t M o d e l --- */
Object.prototype.inherits = function (shuper) { Object.prototype.inheritsFrom = function (shuper) {
function Inheriter() { } function Inheriter() { }
Inheriter.prototype = shuper.prototype; Inheriter.prototype = shuper.prototype;
this.prototype = new Inheriter(); this.prototype = new Inheriter();
...@@ -216,7 +216,7 @@ function UnaryConstraint(v, strength) { ...@@ -216,7 +216,7 @@ function UnaryConstraint(v, strength) {
this.addConstraint(); this.addConstraint();
} }
UnaryConstraint.inherits(Constraint); UnaryConstraint.inheritsFrom(Constraint);
/** /**
* Adds this constraint to the constraint graph * Adds this constraint to the constraint graph
...@@ -294,7 +294,7 @@ function StayConstraint(v, str) { ...@@ -294,7 +294,7 @@ function StayConstraint(v, str) {
StayConstraint.superConstructor.call(this, v, str); StayConstraint.superConstructor.call(this, v, str);
} }
StayConstraint.inherits(UnaryConstraint); StayConstraint.inheritsFrom(UnaryConstraint);
StayConstraint.prototype.execute = function () { StayConstraint.prototype.execute = function () {
// Stay constraints do nothing // Stay constraints do nothing
...@@ -312,7 +312,7 @@ function EditConstraint(v, str) { ...@@ -312,7 +312,7 @@ function EditConstraint(v, str) {
EditConstraint.superConstructor.call(this, v, str); EditConstraint.superConstructor.call(this, v, str);
} }
EditConstraint.inherits(UnaryConstraint); EditConstraint.inheritsFrom(UnaryConstraint);
/** /**
* Edits indicate that a variable is to be changed by imperative code. * Edits indicate that a variable is to be changed by imperative code.
...@@ -346,7 +346,7 @@ function BinaryConstraint(var1, var2, strength) { ...@@ -346,7 +346,7 @@ function BinaryConstraint(var1, var2, strength) {
this.addConstraint(); this.addConstraint();
} }
BinaryConstraint.inherits(Constraint); BinaryConstraint.inheritsFrom(Constraint);
/** /**
* Decides if this constratint can be satisfied and which way it * Decides if this constratint can be satisfied and which way it
...@@ -459,7 +459,7 @@ function ScaleConstraint(src, scale, offset, dest, strength) { ...@@ -459,7 +459,7 @@ function ScaleConstraint(src, scale, offset, dest, strength) {
ScaleConstraint.superConstructor.call(this, src, dest, strength); ScaleConstraint.superConstructor.call(this, src, dest, strength);
} }
ScaleConstraint.inherits(BinaryConstraint); ScaleConstraint.inheritsFrom(BinaryConstraint);
/** /**
* Adds this constraint to the constraint graph. * Adds this constraint to the constraint graph.
...@@ -515,7 +515,7 @@ function EqualityConstraint(var1, var2, strength) { ...@@ -515,7 +515,7 @@ function EqualityConstraint(var1, var2, strength) {
EqualityConstraint.superConstructor.call(this, var1, var2, strength); EqualityConstraint.superConstructor.call(this, var1, var2, strength);
} }
EqualityConstraint.inherits(BinaryConstraint); EqualityConstraint.inheritsFrom(BinaryConstraint);
/** /**
* Enforce this constraint. Assume that it is satisfied. * Enforce this constraint. Assume that it is satisfied.
......
...@@ -22,7 +22,10 @@ the benchmark suite. ...@@ -22,7 +22,10 @@ the benchmark suite.
<div class="subtitle"><h3>Version 5 (<a href="http://v8.googlecode.com/svn/data/benchmarks/v5/run.html">link</a>)</h3></div> <div class="subtitle"><h3>Version 5 (<a href="http://v8.googlecode.com/svn/data/benchmarks/v5/run.html">link</a>)</h3></div>
<p>Removed a duplicate line in the base random seed code. <p>Removed duplicate line in random seed code, and changed the name of
the Object.prototype.inherits function in the DeltaBlue benchmark to
inheritsFrom to avoid name clashes when running in Chromium with
extensions enabled.
</p> </p>
<div class="subtitle"><h3>Version 4 (<a href="http://v8.googlecode.com/svn/data/benchmarks/v4/run.html">link</a>)</h3></div> <div class="subtitle"><h3>Version 4 (<a href="http://v8.googlecode.com/svn/data/benchmarks/v4/run.html">link</a>)</h3></div>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment