Commit 946c59bd authored by Dan Elphick's avatar Dan Elphick Committed by Commit Bot

[cleanup] Remove redundant RuntimeCallTimerScope constructor

The constructor taking an Isolate and HeapObject never uses the
HeapObject value and just calls through to the Isolate constructor.

Bug: v8:9810
Change-Id: Ia2553b4d1f31cf24549980dbb5c2bfa38fe91f8c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918247
Auto-Submit: Dan Elphick <delphick@chromium.org>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64986}
parent c9c2471e
...@@ -57,11 +57,6 @@ void RuntimeCallTimer::CommitTimeToCounter() { ...@@ -57,11 +57,6 @@ void RuntimeCallTimer::CommitTimeToCounter() {
bool RuntimeCallTimer::IsStarted() { return start_ticks_ != base::TimeTicks(); } bool RuntimeCallTimer::IsStarted() { return start_ticks_ != base::TimeTicks(); }
RuntimeCallTimerScope::RuntimeCallTimerScope(Isolate* isolate,
HeapObject heap_object,
RuntimeCallCounterId counter_id)
: RuntimeCallTimerScope(isolate, counter_id) {}
} // namespace internal } // namespace internal
} // namespace v8 } // namespace v8
......
...@@ -1173,10 +1173,6 @@ class RuntimeCallTimerScope { ...@@ -1173,10 +1173,6 @@ class RuntimeCallTimerScope {
public: public:
inline RuntimeCallTimerScope(Isolate* isolate, inline RuntimeCallTimerScope(Isolate* isolate,
RuntimeCallCounterId counter_id); RuntimeCallCounterId counter_id);
// This constructor is here just to avoid calling GetIsolate() when the
// stats are disabled and the isolate is not directly available.
inline RuntimeCallTimerScope(Isolate* isolate, HeapObject heap_object,
RuntimeCallCounterId counter_id);
inline RuntimeCallTimerScope(RuntimeCallStats* stats, inline RuntimeCallTimerScope(RuntimeCallStats* stats,
RuntimeCallCounterId counter_id) { RuntimeCallCounterId counter_id) {
if (V8_LIKELY(!TracingFlags::is_runtime_stats_enabled() || if (V8_LIKELY(!TracingFlags::is_runtime_stats_enabled() ||
......
...@@ -2119,7 +2119,7 @@ Handle<Map> Map::TransitionToDataProperty(Isolate* isolate, Handle<Map> map, ...@@ -2119,7 +2119,7 @@ Handle<Map> Map::TransitionToDataProperty(Isolate* isolate, Handle<Map> map,
PropertyConstness constness, PropertyConstness constness,
StoreOrigin store_origin) { StoreOrigin store_origin) {
RuntimeCallTimerScope stats_scope( RuntimeCallTimerScope stats_scope(
isolate, *map, isolate,
map->is_prototype_map() map->is_prototype_map()
? RuntimeCallCounterId::kPrototypeMap_TransitionToDataProperty ? RuntimeCallCounterId::kPrototypeMap_TransitionToDataProperty
: RuntimeCallCounterId::kMap_TransitionToDataProperty); : RuntimeCallCounterId::kMap_TransitionToDataProperty);
...@@ -2634,7 +2634,7 @@ bool Map::IsPrototypeChainInvalidated(Map map) { ...@@ -2634,7 +2634,7 @@ bool Map::IsPrototypeChainInvalidated(Map map) {
void Map::SetPrototype(Isolate* isolate, Handle<Map> map, void Map::SetPrototype(Isolate* isolate, Handle<Map> map,
Handle<HeapObject> prototype, Handle<HeapObject> prototype,
bool enable_prototype_setup_mode) { bool enable_prototype_setup_mode) {
RuntimeCallTimerScope stats_scope(isolate, *map, RuntimeCallTimerScope stats_scope(isolate,
RuntimeCallCounterId::kMap_SetPrototype); RuntimeCallCounterId::kMap_SetPrototype);
if (prototype->IsJSObject()) { if (prototype->IsJSObject()) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment