Commit 92bbf759 authored by erik.corry@gmail.com's avatar erik.corry@gmail.com

Don't panic if tickprocessor can't find a shared library.

Don't swallow exceptions so we can't see where they are really
thrown.
Review URL: http://codereview.chromium.org/126200

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2192 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 977ad650
...@@ -157,7 +157,6 @@ TickProcessor.prototype.processLogFile = function(fileName) { ...@@ -157,7 +157,6 @@ TickProcessor.prototype.processLogFile = function(fileName) {
TickProcessor.prototype.processLog = function(lines) { TickProcessor.prototype.processLog = function(lines) {
var csvParser = new devtools.profiler.CsvParser(); var csvParser = new devtools.profiler.CsvParser();
try {
for (var i = 0, n = lines.length; i < n; ++i) { for (var i = 0, n = lines.length; i < n; ++i) {
var line = lines[i]; var line = lines[i];
if (!line) { if (!line) {
...@@ -166,10 +165,6 @@ TickProcessor.prototype.processLog = function(lines) { ...@@ -166,10 +165,6 @@ TickProcessor.prototype.processLog = function(lines) {
var fields = csvParser.parseLine(line); var fields = csvParser.parseLine(line);
this.dispatchLogRow(fields); this.dispatchLogRow(fields);
} }
} catch (e) {
print('line ' + (i + 1) + ': ' + (e.message || e));
throw e;
}
}; };
...@@ -487,11 +482,16 @@ UnixCppEntriesProvider.FUNC_RE = /^([0-9a-fA-F]{8}) . (.*)$/; ...@@ -487,11 +482,16 @@ UnixCppEntriesProvider.FUNC_RE = /^([0-9a-fA-F]{8}) . (.*)$/;
UnixCppEntriesProvider.prototype.loadSymbols = function(libName) { UnixCppEntriesProvider.prototype.loadSymbols = function(libName) {
this.parsePos = 0;
try {
this.symbols = [ this.symbols = [
os.system('nm', ['-C', '-n', libName], -1, -1), os.system('nm', ['-C', '-n', libName], -1, -1),
os.system('nm', ['-C', '-n', '-D', libName], -1, -1) os.system('nm', ['-C', '-n', '-D', libName], -1, -1)
]; ];
this.parsePos = 0; } catch (e) {
// If the library cannot be found on this system let's not panic.
this.symbols = [ '', '' ];
}
}; };
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment