Split message tests in failing and non-failing

This way, we can also check the return code of d8. We currently have a
bug (6981) which makes failing tests not being detected, even though
the failure message is (sometimes) being printed.
After this refactoring, we can write tests for our mjsunit test
functions.

R=machenbach@chromium.org

Bug: v8:6981
Change-Id: I0aa0abcb0f9a4f622a1e1d1a4d826da1e6eb4f07
Reviewed-on: https://chromium-review.googlesource.com/737991Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#48951}

test/message/modules-star-conflict1.js → test/message/fail/modules-star-conflict1.js

@@ -4,4 +4,4 @@
 //
 // MODULE
 
-import {a} from "../mjsunit/modules-skip-7.js";
+import {a} from "../../mjsunit/modules-skip-7.js";

test/message/modules-star-conflict1.out → test/message/fail/modules-star-conflict1.out

 *%(basename)s:7: SyntaxError: The requested module contains conflicting star exports for name 'a'
-import {a} from "../mjsunit/modules-skip-7.js";
+import {a} from "../../mjsunit/modules-skip-7.js";
         ^
 SyntaxError: The requested module contains conflicting star exports for name 'a'
 

test/message/modules-star-conflict2.js → test/message/fail/modules-star-conflict2.js

@@ -4,7 +4,7 @@
 //
 // MODULE
 
-export * from "../mjsunit/modules-skip-star-exports-conflict.js";
-export * from "../mjsunit/modules-skip-6.js";
+export * from "../../mjsunit/modules-skip-star-exports-conflict.js";
+export * from "../../mjsunit/modules-skip-6.js";
 
 import {a} from "modules-star-conflict2.js";

test/message/modules-star-conflict2.out → test/message/fail/modules-star-conflict2.out

 *%(basename)s:7: SyntaxError: The requested module contains conflicting star exports for name 'a'
-export * from "../mjsunit/modules-skip-star-exports-conflict.js";
+export * from "../../mjsunit/modules-skip-star-exports-conflict.js";
        ^
 SyntaxError: The requested module contains conflicting star exports for name 'a'
 

test/message/message.status

@@ -34,6 +34,6 @@
 
   # Modules which are only meant to be imported from by other tests, not to be
   # tested standalone.
-  'modules-skip*': [SKIP],
+  'fail/modules-skip*': [SKIP],
 }],  # ALWAYS
 ]

test/message/testcfg.py

@@ -88,9 +88,22 @@ class MessageTestSuite(testsuite.TestSuite):
     return (string.startswith("==") or string.startswith("**") or
             string.startswith("ANDROID"))
 
+  def _GetExpectedFail(self, testcase):
+    path = testcase.path
+    while path:
+      (head, tail) = os.path.split(path)
+      if tail == "fail":
+        return True
+      path = head
+    return False
+
   def IsFailureOutput(self, testcase):
     output = testcase.output
     testpath = testcase.path
+    expected_fail = self._GetExpectedFail(testcase)
+    fail = testcase.output.exit_code != 0
+    if expected_fail != fail:
+      return True
     expected_path = os.path.join(self.root, testpath + ".out")
     expected_lines = []
     # Can't use utils.ReadLinesFrom() here because it strips whitespace.