[refactoring] Drop roots.h -> handles.h #include

This makes it possible for handles.h to #include objects.h, which
upcoming changes will need.

Bug: v8:3770
Change-Id: I4f500736028668749bb73fb24f9732df757e97d0
Reviewed-on: https://chromium-review.googlesource.com/c/1278487Reviewed-by: Michael Stanton <mvstanton@chromium.org>
Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56615}

src/allocation-site-scopes.h

@@ -7,6 +7,7 @@
 
 #include "src/handles.h"
 #include "src/objects.h"
+#include "src/objects/allocation-site.h"
 #include "src/objects/map.h"
 
 namespace v8 {

src/arguments.h

@@ -6,6 +6,7 @@
 #define V8_ARGUMENTS_H_
 
 #include "src/allocation.h"
+#include "src/handles.h"
 #include "src/objects.h"
 #include "src/tracing/trace-event.h"
 

src/compiler/js-heap-broker.h

@@ -9,6 +9,7 @@
 #include "src/base/optional.h"
 #include "src/compiler/refs-map.h"
 #include "src/globals.h"
+#include "src/handles.h"
 #include "src/objects.h"
 #include "src/objects/builtin-function-id.h"
 #include "src/zone/zone-containers.h"

src/compiler/x64/instruction-selector-x64.cc

@@ -8,6 +8,7 @@
 #include "src/compiler/instruction-selector-impl.h"
 #include "src/compiler/node-matchers.h"
 #include "src/compiler/node-properties.h"
+#include "src/roots-inl.h"
 #include "src/turbo-assembler.h"
 
 namespace v8 {

src/debug/debug-coverage.h

@@ -8,6 +8,7 @@
 #include <vector>
 
 #include "src/debug/debug-interface.h"
+#include "src/handles.h"
 #include "src/objects.h"
 
 namespace v8 {

src/debug/debug-type-profile.h

@@ -8,6 +8,7 @@
 #include <vector>
 
 #include "src/debug/debug-interface.h"
+#include "src/handles.h"
 #include "src/objects.h"
 
 namespace v8 {

src/isolate-inl.h

@@ -7,6 +7,7 @@
 
 #include "src/isolate.h"
 #include "src/objects-inl.h"
+#include "src/objects/regexp-match-info.h"
 
 namespace v8 {
 namespace internal {

src/roots-inl.h

@@ -7,6 +7,7 @@
 
 #include "src/roots.h"
 
+#include "src/handles.h"
 #include "src/heap/heap-inl.h"
 
 namespace v8 {
@@ -23,6 +24,12 @@ V8_INLINE RootIndex operator++(RootIndex& index) {
   return index;
 }
 
+template <typename T>
+bool RootsTable::IsRootHandle(Handle<T> handle, RootIndex* index) const {
+  Object** handle_location = bit_cast<Object**>(handle.address());
+  return IsRootHandleLocation(handle_location, index);
+}
+
 ReadOnlyRoots::ReadOnlyRoots(Heap* heap)
     : roots_table_(heap->isolate()->roots_table()) {}
 

src/roots.h

@@ -7,7 +7,6 @@
 
 #include "src/accessors.h"
 #include "src/globals.h"
-#include "src/handles.h"
 #include "src/heap-symbols.h"
 #include "src/objects-definitions.h"
 
@@ -17,6 +16,8 @@ namespace internal {
 // Forward declarations.
 enum ElementsKind : uint8_t;
 class FixedTypedArrayBase;
+template <typename T>
+class Handle;
 class Heap;
 class Isolate;
 class Map;
@@ -393,10 +394,7 @@ class RootsTable {
   }
 
   template <typename T>
-  bool IsRootHandle(Handle<T> handle, RootIndex* index) const {
-    Object** handle_location = bit_cast<Object**>(handle.address());
-    return IsRootHandleLocation(handle_location, index);
-  }
+  bool IsRootHandle(Handle<T> handle, RootIndex* index) const;
 
   Object* const& operator[](RootIndex root_index) const {
     size_t index = static_cast<size_t>(root_index);

src/string-constants.h

@@ -5,6 +5,7 @@
 #ifndef V8_STRING_CONSTANTS_H_
 #define V8_STRING_CONSTANTS_H_
 
+#include "src/handles.h"
 #include "src/objects/string.h"
 #include "src/zone/zone.h"