Commit 90f9dece authored by Zhao Jiazhong's avatar Zhao Jiazhong Committed by Commit Bot

[mips] Fix floating point abs operation

Float32/64 abs operation should only clear the sign bit, but abs.s
and abs.d instructions of mips64r2 would convert nan to canonical
nan.

Change-Id: Ibbd05cdb3a73acfe0e532030d1815d262c3ac433
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2439768
Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70214}
parent 75b8c238
......@@ -1239,7 +1239,13 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
break;
}
case kMipsAbsS:
__ abs_s(i.OutputSingleRegister(), i.InputSingleRegister(0));
if (IsMipsArchVariant(kMips32r6)) {
__ abs_s(i.OutputSingleRegister(), i.InputSingleRegister(0));
} else {
__ mfc1(kScratchReg, i.InputSingleRegister(0));
__ Ins(kScratchReg, zero_reg, 31, 1);
__ mtc1(kScratchReg, i.OutputSingleRegister());
}
break;
case kMipsSqrtS: {
__ sqrt_s(i.OutputDoubleRegister(), i.InputDoubleRegister(0));
......@@ -1331,7 +1337,13 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
break;
}
case kMipsAbsD:
__ abs_d(i.OutputDoubleRegister(), i.InputDoubleRegister(0));
if (IsMipsArchVariant(kMips32r6)) {
__ abs_d(i.OutputDoubleRegister(), i.InputDoubleRegister(0));
} else {
__ mfhc1(kScratchReg, i.InputDoubleRegister(0));
__ Ins(kScratchReg, zero_reg, 31, 1);
__ mthc1(kScratchReg, i.OutputDoubleRegister());
}
break;
case kMipsNegS:
__ Neg_s(i.OutputSingleRegister(), i.InputSingleRegister(0));
......
......@@ -1318,7 +1318,13 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
break;
}
case kMips64AbsS:
__ abs_s(i.OutputSingleRegister(), i.InputSingleRegister(0));
if (kArchVariant == kMips64r6) {
__ abs_s(i.OutputSingleRegister(), i.InputSingleRegister(0));
} else {
__ mfc1(kScratchReg, i.InputSingleRegister(0));
__ Dins(kScratchReg, zero_reg, 31, 1);
__ mtc1(kScratchReg, i.OutputSingleRegister());
}
break;
case kMips64NegS:
__ Neg_s(i.OutputSingleRegister(), i.InputSingleRegister(0));
......@@ -1378,7 +1384,13 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
break;
}
case kMips64AbsD:
__ abs_d(i.OutputDoubleRegister(), i.InputDoubleRegister(0));
if (kArchVariant == kMips64r6) {
__ abs_d(i.OutputDoubleRegister(), i.InputDoubleRegister(0));
} else {
__ dmfc1(kScratchReg, i.InputDoubleRegister(0));
__ Dins(kScratchReg, zero_reg, 63, 1);
__ dmtc1(kScratchReg, i.OutputDoubleRegister());
}
break;
case kMips64NegD:
__ Neg_d(i.OutputDoubleRegister(), i.InputDoubleRegister(0));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment