Remove the experimental perf jit support until the license is clarified.

BUG=

Review URL: https://codereview.chromium.org/1148293009

Cr-Commit-Position: refs/heads/master@{#28697}

BUILD.gn

@@ -970,8 +970,6 @@ source_set("v8_base") {
     "src/parser.h",
     "src/pending-compilation-error-handler.cc",
     "src/pending-compilation-error-handler.h",
-    "src/perf-jit.cc",
-    "src/perf-jit.h",
     "src/preparse-data-format.h",
     "src/preparse-data.cc",
     "src/preparse-data.h",

src/flag-definitions.h

@@ -931,9 +931,6 @@ DEFINE_BOOL(ll_prof, false, "Enable low-level linux profiler.")
 DEFINE_BOOL(perf_basic_prof, false,
             "Enable perf linux profiler (basic support).")
 DEFINE_NEG_IMPLICATION(perf_basic_prof, compact_code_space)
-DEFINE_BOOL(perf_jit_prof, false,
-            "Enable perf linux profiler (experimental annotate support).")
-DEFINE_NEG_IMPLICATION(perf_jit_prof, compact_code_space)
 DEFINE_STRING(gc_fake_mmap, "/tmp/__v8_gc__",
               "Specify the name of the file for fake gc mmap used in ll_prof")
 DEFINE_BOOL(log_internal_timer_events, false, "Time internal events.")

src/log-utils.h

@@ -24,7 +24,7 @@ class Log {
   static bool InitLogAtStart() {
     return FLAG_log || FLAG_log_api || FLAG_log_code || FLAG_log_gc ||
            FLAG_log_handles || FLAG_log_suspect || FLAG_log_regexp ||
-           FLAG_ll_prof || FLAG_perf_basic_prof || FLAG_perf_jit_prof ||
+           FLAG_ll_prof || FLAG_perf_basic_prof ||
            FLAG_log_internal_timer_events || FLAG_prof_cpp;
   }
 

src/log.cc

@@ -19,7 +19,6 @@
 #include "src/log-inl.h"
 #include "src/log-utils.h"
 #include "src/macro-assembler.h"
-#include "src/perf-jit.h"
 #include "src/runtime-profiler.h"
 #include "src/string-stream.h"
 #include "src/vm-state-inl.h"
@@ -778,7 +777,6 @@ Logger::Logger(Isolate* isolate)
     is_logging_(false),
     log_(new Log(this)),
     perf_basic_logger_(NULL),
-    perf_jit_logger_(NULL),
     ll_logger_(NULL),
     jit_logger_(NULL),
     listeners_(5),
@@ -1819,11 +1817,6 @@ bool Logger::SetUp(Isolate* isolate) {
     addCodeEventListener(perf_basic_logger_);
   }
 
-  if (FLAG_perf_jit_prof) {
-    perf_jit_logger_ = new PerfJitLogger();
-    addCodeEventListener(perf_jit_logger_);
-  }
-
   if (FLAG_ll_prof) {
     ll_logger_ = new LowLevelLogger(log_file_name.str().c_str());
     addCodeEventListener(ll_logger_);
@@ -1892,12 +1885,6 @@ FILE* Logger::TearDown() {
     perf_basic_logger_ = NULL;
   }
 
-  if (perf_jit_logger_) {
-    removeCodeEventListener(perf_jit_logger_);
-    delete perf_jit_logger_;
-    perf_jit_logger_ = NULL;
-  }
-
   if (ll_logger_) {
     removeCodeEventListener(ll_logger_);
     delete ll_logger_;

src/log.h

@@ -146,7 +146,6 @@ struct TickSample;
 class JitLogger;
 class PerfBasicLogger;
 class LowLevelLogger;
-class PerfJitLogger;
 class Sampler;
 
 class Logger {
@@ -401,7 +400,6 @@ class Logger {
   bool is_logging_;
   Log* log_;
   PerfBasicLogger* perf_basic_logger_;
-  PerfJitLogger* perf_jit_logger_;
   LowLevelLogger* ll_logger_;
   JitLogger* jit_logger_;
   List<CodeEventListener*> listeners_;

src/perf-jit.cc

-// Copyright 2014 the V8 project authors. All rights reserved.
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-//     * Redistributions of source code must retain the above copyright
-//       notice, this list of conditions and the following disclaimer.
-//     * Redistributions in binary form must reproduce the above
-//       copyright notice, this list of conditions and the following
-//       disclaimer in the documentation and/or other materials provided
-//       with the distribution.
-//     * Neither the name of Google Inc. nor the names of its
-//       contributors may be used to endorse or promote products derived
-//       from this software without specific prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-#include "src/perf-jit.h"
-
-#if V8_OS_LINUX
-#include <fcntl.h>
-#include <unistd.h>
-#include "src/third_party/kernel/tools/perf/util/jitdump.h"
-#endif  // V8_OS_LINUX
-
-namespace v8 {
-namespace internal {
-
-#if V8_OS_LINUX
-
-const char PerfJitLogger::kFilenameFormatString[] = "perfjit-%d.dump";
-
-// Extra padding for the PID in the filename
-const int PerfJitLogger::kFilenameBufferPadding = 16;
-
-
-PerfJitLogger::PerfJitLogger() : perf_output_handle_(NULL), code_index_(0) {
-  if (!base::TimeTicks::KernelTimestampAvailable()) {
-    FATAL("Cannot profile with perf JIT - kernel timestamps not available.");
-  }
-
-  // Open the perf JIT dump file.
-  int bufferSize = sizeof(kFilenameFormatString) + kFilenameBufferPadding;
-  ScopedVector<char> perf_dump_name(bufferSize);
-  int size = SNPrintF(perf_dump_name, kFilenameFormatString,
-                      base::OS::GetCurrentProcessId());
-  CHECK_NE(size, -1);
-  perf_output_handle_ =
-      base::OS::FOpen(perf_dump_name.start(), base::OS::LogFileOpenMode);
-  CHECK_NOT_NULL(perf_output_handle_);
-  setvbuf(perf_output_handle_, NULL, _IOFBF, kLogBufferSize);
-
-  LogWriteHeader();
-}
-
-
-PerfJitLogger::~PerfJitLogger() {
-  fclose(perf_output_handle_);
-  perf_output_handle_ = NULL;
-}
-
-
-uint64_t PerfJitLogger::GetTimestamp() {
-  return static_cast<int64_t>(
-      base::TimeTicks::KernelTimestampNow().ToInternalValue());
-}
-
-
-void PerfJitLogger::LogRecordedBuffer(Code* code, SharedFunctionInfo*,
-                                      const char* name, int length) {
-  DCHECK(code->instruction_start() == code->address() + Code::kHeaderSize);
-  DCHECK(perf_output_handle_ != NULL);
-
-  const char* code_name = name;
-  uint8_t* code_pointer = reinterpret_cast<uint8_t*>(code->instruction_start());
-  uint32_t code_size = code->is_crankshafted() ? code->safepoint_table_offset()
-                                               : code->instruction_size();
-
-  static const char string_terminator[] = "\0";
-
-  jr_code_load code_load;
-  code_load.p.id = JIT_CODE_LOAD;
-  code_load.p.total_size = sizeof(code_load) + length + 1 + code_size;
-  code_load.p.timestamp = GetTimestamp();
-  code_load.pid = static_cast<uint32_t>(base::OS::GetCurrentProcessId());
-  code_load.tid = static_cast<uint32_t>(base::OS::GetCurrentThreadId());
-  code_load.vma = 0x0;  //  Our addresses are absolute.
-  code_load.code_addr = reinterpret_cast<uint64_t>(code_pointer);
-  code_load.code_size = code_size;
-  code_load.code_index = code_index_;
-
-  code_index_++;
-
-  LogWriteBytes(reinterpret_cast<const char*>(&code_load), sizeof(code_load));
-  LogWriteBytes(code_name, length);
-  LogWriteBytes(string_terminator, 1);
-  LogWriteBytes(reinterpret_cast<const char*>(code_pointer), code_size);
-}
-
-
-void PerfJitLogger::CodeMoveEvent(Address from, Address to) {
-  // Code relocation not supported.
-  UNREACHABLE();
-}
-
-
-void PerfJitLogger::CodeDeleteEvent(Address from) {
-  // V8 does not send notification on code unload
-}
-
-
-void PerfJitLogger::SnapshotPositionEvent(Address addr, int pos) {}
-
-
-void PerfJitLogger::LogWriteBytes(const char* bytes, int size) {
-  size_t rv = fwrite(bytes, 1, size, perf_output_handle_);
-  DCHECK(static_cast<size_t>(size) == rv);
-  USE(rv);
-}
-
-
-void PerfJitLogger::LogWriteHeader() {
-  DCHECK(perf_output_handle_ != NULL);
-  jitheader header;
-  header.magic = JITHEADER_MAGIC;
-  header.version = JITHEADER_VERSION;
-  header.total_size = sizeof(jitheader);
-  header.pad1 = 0xdeadbeef;
-  header.elf_mach = GetElfMach();
-  header.pid = base::OS::GetCurrentProcessId();
-  header.timestamp =
-      static_cast<uint64_t>(base::OS::TimeCurrentMillis() * 1000.0);
-  LogWriteBytes(reinterpret_cast<const char*>(&header), sizeof(header));
-}
-
-#endif  // V8_OS_LINUX
-}
-}  // namespace v8::internal

src/perf-jit.h

-// Copyright 2014 the V8 project authors. All rights reserved.
-// Redistribution and use in source and binary forms, with or without
-// modification, are permitted provided that the following conditions are
-// met:
-//
-//     * Redistributions of source code must retain the above copyright
-//       notice, this list of conditions and the following disclaimer.
-//     * Redistributions in binary form must reproduce the above
-//       copyright notice, this list of conditions and the following
-//       disclaimer in the documentation and/or other materials provided
-//       with the distribution.
-//     * Neither the name of Google Inc. nor the names of its
-//       contributors may be used to endorse or promote products derived
-//       from this software without specific prior written permission.
-//
-// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-
-#ifndef V8_PERF_JIT_H_
-#define V8_PERF_JIT_H_
-
-#include "src/v8.h"
-
-namespace v8 {
-namespace internal {
-
-#if V8_OS_LINUX
-
-// Linux perf tool logging support
-class PerfJitLogger : public CodeEventLogger {
- public:
-  PerfJitLogger();
-  virtual ~PerfJitLogger();
-
-  virtual void CodeMoveEvent(Address from, Address to);
-  virtual void CodeDeleteEvent(Address from);
-  virtual void CodeDisableOptEvent(Code* code, SharedFunctionInfo* shared) {}
-  virtual void SnapshotPositionEvent(Address addr, int pos);
-
- private:
-  uint64_t GetTimestamp();
-  virtual void LogRecordedBuffer(Code* code, SharedFunctionInfo* shared,
-                                 const char* name, int length);
-
-  // Extension added to V8 log file name to get the low-level log name.
-  static const char kFilenameFormatString[];
-  static const int kFilenameBufferPadding;
-
-  // File buffer size of the low-level log. We don't use the default to
-  // minimize the associated overhead.
-  static const int kLogBufferSize = 2 * MB;
-
-  void LogWriteBytes(const char* bytes, int size);
-  void LogWriteHeader();
-
-  static const uint32_t kElfMachIA32 = 3;
-  static const uint32_t kElfMachX64 = 62;
-  static const uint32_t kElfMachARM = 40;
-  static const uint32_t kElfMachMIPS = 10;
-
-  uint32_t GetElfMach() {
-#if V8_TARGET_ARCH_IA32
-    return kElfMachIA32;
-#elif V8_TARGET_ARCH_X64
-    return kElfMachX64;
-#elif V8_TARGET_ARCH_ARM
-    return kElfMachARM;
-#elif V8_TARGET_ARCH_MIPS
-    return kElfMachMIPS;
-#else
-    UNIMPLEMENTED();
-    return 0;
-#endif
-  }
-
-  FILE* perf_output_handle_;
-  uint64_t code_index_;
-};
-
-#else
-
-// PerfJitLogger is only implemented on Linux
-class PerfJitLogger : public CodeEventLogger {
- public:
-  virtual void CodeMoveEvent(Address from, Address to) { UNIMPLEMENTED(); }
-
-  virtual void CodeDeleteEvent(Address from) { UNIMPLEMENTED(); }
-
-  virtual void CodeDisableOptEvent(Code* code, SharedFunctionInfo* shared) {
-    UNIMPLEMENTED();
-  }
-
-  virtual void SnapshotPositionEvent(Address addr, int pos) { UNIMPLEMENTED(); }
-
-  virtual void LogRecordedBuffer(Code* code, SharedFunctionInfo* shared,
-                                 const char* name, int length) {
-    UNIMPLEMENTED();
-  }
-};
-
-#endif  // V8_OS_LINUX
-}
-}  // namespace v8::internal
-#endif

src/third_party/kernel/tools/perf/util/jitdump.h

-#ifndef JITDUMP_H
-#define JITDUMP_H
-
-#include <sys/time.h>
-#include <time.h>
-#include <stdint.h>
-
-/* JiTD */
-#define JITHEADER_MAGIC 0x4A695444
-#define JITHEADER_MAGIC_SW 0x4454694A
-
-#define PADDING_8ALIGNED(x) ((((x) + 7) & 7) ^ 7)
-
-#define JITHEADER_VERSION 1
-
-struct jitheader {
-  uint32_t magic;      /* characters "jItD" */
-  uint32_t version;    /* header version */
-  uint32_t total_size; /* total size of header */
-  uint32_t elf_mach;   /* elf mach target */
-  uint32_t pad1;       /* reserved */
-  uint32_t pid;        /* JIT process id */
-  uint64_t timestamp;  /* timestamp */
-};
-
-enum jit_record_type {
-  JIT_CODE_LOAD = 0,
-  JIT_CODE_MOVE = 1,
-  JIT_CODE_DEBUG_INFO = 2,
-  JIT_CODE_CLOSE = 3,
-  JIT_CODE_MAX
-};
-
-/* record prefix (mandatory in each record) */
-struct jr_prefix {
-  uint32_t id;
-  uint32_t total_size;
-  uint64_t timestamp;
-};
-
-struct jr_code_load {
-  struct jr_prefix p;
-
-  uint32_t pid;
-  uint32_t tid;
-  uint64_t vma;
-  uint64_t code_addr;
-  uint64_t code_size;
-  uint64_t code_index;
-};
-
-struct jr_code_close {
-  struct jr_prefix p;
-};
-
-struct jr_code_move {
-  struct jr_prefix p;
-
-  uint32_t pid;
-  uint32_t tid;
-  uint64_t vma;
-  uint64_t old_code_addr;
-  uint64_t new_code_addr;
-  uint64_t code_size;
-  uint64_t code_index;
-};
-
-struct jr_code_debug_info {
-  struct jr_prefix p;
-
-  uint64_t code_addr;
-  uint64_t nr_entry;
-};
-
-union jr_entry {
-  struct jr_code_debug_info info;
-  struct jr_code_close close;
-  struct jr_code_load load;
-  struct jr_code_move move;
-  struct jr_prefix prefix;
-};
-
-#endif /* !JITDUMP_H */

tools/gyp/v8.gyp

@@ -801,8 +801,6 @@
         '../../src/parser.h',
         '../../src/pending-compilation-error-handler.cc',
         '../../src/pending-compilation-error-handler.h',
-        '../../src/perf-jit.cc',
-        '../../src/perf-jit.h',
         '../../src/preparse-data-format.h',
         '../../src/preparse-data.cc',
         '../../src/preparse-data.h',