Skip to content

V
V8
Commit 8f8f074f authored by Ujjwal Sharma's avatar Ujjwal Sharma Committed by Commit Bot
Browse files
Options

[intl] rename all BreakIterator builtins 

Rename all BreakIterator builtins from BreakIterator to V8BreakIterator.

Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: I49437096e5a53d85f229421ddae8d61a7164d9a9
Reviewed-on: https://chromium-review.googlesource.com/1207410
Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#55661}
parent 00de0e8b
Hide whitespace changes
Inline Side-by-side
Showing with 44 additions and 42 deletions
src/bootstrapper.cc
View file @ 8f8f074f
......@@ -2989,7 +2989,7 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Handle<JSFunction> v8_break_iterator_constructor = InstallFunction(
isolate_, intl, "v8BreakIterator", JS_INTL_V8_BREAK_ITERATOR_TYPE,
JSV8BreakIterator::kSize, 0, factory->the_hole_value(),
Builtins::kBreakIteratorConstructor);
Builtins::kV8BreakIteratorConstructor);
v8_break_iterator_constructor->shared()->DontAdaptArguments();
InstallWithIntrinsicDefaultProto(
isolate_, v8_break_iterator_constructor,
......@@ -2997,7 +2997,7 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
SimpleInstallFunction(
isolate_, v8_break_iterator_constructor, "supportedLocalesOf",
Builtins::kv8BreakIteratorSupportedLocalesOf, 1, false);
Builtins::kV8BreakIteratorSupportedLocalesOf, 1, false);
Handle<JSObject> prototype(
JSObject::cast(v8_break_iterator_constructor->prototype()), isolate_);
......@@ -3009,28 +3009,28 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
static_cast<PropertyAttributes>(DONT_ENUM | READ_ONLY));
SimpleInstallFunction(isolate_, prototype, "resolvedOptions",
Builtins::kBreakIteratorPrototypeResolvedOptions, 0,
false);
Builtins::kV8BreakIteratorPrototypeResolvedOptions,
0, false);
SimpleInstallGetter(isolate_, prototype,
factory->InternalizeUtf8String("adoptText"),
Builtins::kBreakIteratorPrototypeAdoptText, false);
Builtins::kV8BreakIteratorPrototypeAdoptText, false);
SimpleInstallGetter(isolate_, prototype,
factory->InternalizeUtf8String("first"),
Builtins::kBreakIteratorPrototypeFirst, false);
Builtins::kV8BreakIteratorPrototypeFirst, false);
SimpleInstallGetter(isolate_, prototype,
factory->InternalizeUtf8String("next"),
Builtins::kBreakIteratorPrototypeNext, false);
Builtins::kV8BreakIteratorPrototypeNext, false);
SimpleInstallGetter(isolate_, prototype,
factory->InternalizeUtf8String("current"),
Builtins::kBreakIteratorPrototypeCurrent, false);
Builtins::kV8BreakIteratorPrototypeCurrent, false);
SimpleInstallGetter(isolate_, prototype,
factory->InternalizeUtf8String("breakType"),
Builtins::kBreakIteratorPrototypeBreakType, false);
Builtins::kV8BreakIteratorPrototypeBreakType, false);
}
{
......
src/builtins/builtins-definitions.h
View file @ 8f8f074f
......@@ -1331,7 +1331,7 @@ namespace internal {
/* ecma402 #sec-intl.collator */ \
CPP(CollatorConstructor) \
/* ecma402 #sec-intl.v8breakiterator.supportedlocalesof */ \
CPP(v8BreakIteratorSupportedLocalesOf) \
CPP(V8BreakIteratorSupportedLocalesOf) \
/* ecma402 #sec-intl.collator.supportedlocalesof */ \
CPP(CollatorSupportedLocalesOf) \
TFS(StringToLowerCaseIntl, kString) \
......@@ -1417,18 +1417,18 @@ namespace internal {
CPP(CollatorPrototypeCompare) \
/* ecma 402 #sec-collator-compare-functions*/ \
CPP(CollatorInternalCompare) \
CPP(BreakIteratorInternalAdoptText) \
CPP(BreakIteratorPrototypeAdoptText) \
CPP(BreakIteratorInternalFirst) \
CPP(BreakIteratorPrototypeFirst) \
CPP(BreakIteratorInternalNext) \
CPP(BreakIteratorPrototypeNext) \
CPP(BreakIteratorInternalCurrent) \
CPP(BreakIteratorPrototypeCurrent) \
CPP(BreakIteratorInternalBreakType) \
CPP(BreakIteratorPrototypeBreakType) \
CPP(BreakIteratorConstructor) \
CPP(BreakIteratorPrototypeResolvedOptions)
CPP(V8BreakIteratorInternalAdoptText) \
CPP(V8BreakIteratorPrototypeAdoptText) \
CPP(V8BreakIteratorInternalFirst) \
CPP(V8BreakIteratorPrototypeFirst) \
CPP(V8BreakIteratorInternalNext) \
CPP(V8BreakIteratorPrototypeNext) \
CPP(V8BreakIteratorInternalCurrent) \
CPP(V8BreakIteratorPrototypeCurrent) \
CPP(V8BreakIteratorInternalBreakType) \
CPP(V8BreakIteratorPrototypeBreakType) \
CPP(V8BreakIteratorConstructor) \
CPP(V8BreakIteratorPrototypeResolvedOptions)
#else
#define BUILTIN_LIST_INTL(CPP, TFJ, TFS) \
/* no-op fallback version */ \
......
src/builtins/builtins-intl.cc
View file @ 8f8f074f
......@@ -365,7 +365,7 @@ MaybeHandle<JSObject> SupportedLocalesOfCommon(Isolate* isolate,
} // namespace
BUILTIN(v8BreakIteratorSupportedLocalesOf) {
BUILTIN(V8BreakIteratorSupportedLocalesOf) {
HandleScope scope(isolate);
// 1. If NewTarget is defined, throw a TypeError exception.
if (!args.new_target()->IsUndefined(isolate)) { // [[Call]]
......@@ -1207,7 +1207,7 @@ BUILTIN(CollatorInternalCompare) {
return *Intl::CompareStrings(isolate, collator_holder, string_x, string_y);
}
BUILTIN(BreakIteratorConstructor) {
BUILTIN(V8BreakIteratorConstructor) {
HandleScope scope(isolate);
Handle<JSReceiver> new_target;
......@@ -1234,14 +1234,14 @@ BUILTIN(BreakIteratorConstructor) {
isolate, break_iterator, locales, options));
}
BUILTIN(BreakIteratorPrototypeResolvedOptions) {
BUILTIN(V8BreakIteratorPrototypeResolvedOptions) {
HandleScope scope(isolate);
CHECK_RECEIVER(JSV8BreakIterator, break_iterator,
"Intl.v8BreakIterator.prototype.resolvedOptions");
return *JSV8BreakIterator::ResolvedOptions(isolate, break_iterator);
}
BUILTIN(BreakIteratorPrototypeAdoptText) {
BUILTIN(V8BreakIteratorPrototypeAdoptText) {
const char* const method = "get Intl.v8BreakIterator.prototype.adoptText";
HandleScope scope(isolate);
......@@ -1254,12 +1254,12 @@ BUILTIN(BreakIteratorPrototypeAdoptText) {
}
Handle<JSFunction> new_bound_adopt_text_function = CreateBoundFunction(
isolate, break_iterator, Builtins::kBreakIteratorInternalAdoptText, 1);
isolate, break_iterator, Builtins::kV8BreakIteratorInternalAdoptText, 1);
break_iterator->set_bound_adopt_text(*new_bound_adopt_text_function);
return *new_bound_adopt_text_function;
}
BUILTIN(BreakIteratorInternalAdoptText) {
BUILTIN(V8BreakIteratorInternalAdoptText) {
HandleScope scope(isolate);
Handle<Context> context = Handle<Context>(isolate->context(), isolate);
......@@ -1277,7 +1277,7 @@ BUILTIN(BreakIteratorInternalAdoptText) {
return ReadOnlyRoots(isolate).undefined_value();
}
BUILTIN(BreakIteratorPrototypeFirst) {
BUILTIN(V8BreakIteratorPrototypeFirst) {
const char* const method = "get Intl.v8BreakIterator.prototype.first";
HandleScope scope(isolate);
......@@ -1289,13 +1289,14 @@ BUILTIN(BreakIteratorPrototypeFirst) {
return *bound_first;
}
Handle<JSFunction> new_bound_first_function = CreateBoundFunction(
isolate, break_iterator_holder, Builtins::kBreakIteratorInternalFirst, 0);
Handle<JSFunction> new_bound_first_function =
CreateBoundFunction(isolate, break_iterator_holder,
Builtins::kV8BreakIteratorInternalFirst, 0);
break_iterator_holder->set_bound_first(*new_bound_first_function);
return *new_bound_first_function;
}
BUILTIN(BreakIteratorInternalFirst) {
BUILTIN(V8BreakIteratorInternalFirst) {
HandleScope scope(isolate);
Handle<Context> context = Handle<Context>(isolate->context(), isolate);
......@@ -1311,7 +1312,7 @@ BUILTIN(BreakIteratorInternalFirst) {
return *isolate->factory()->NewNumberFromInt(break_iterator->first());
}
BUILTIN(BreakIteratorPrototypeNext) {
BUILTIN(V8BreakIteratorPrototypeNext) {
const char* const method = "get Intl.v8BreakIterator.prototype.next";
HandleScope scope(isolate);
......@@ -1323,13 +1324,14 @@ BUILTIN(BreakIteratorPrototypeNext) {
return *bound_next;
}
Handle<JSFunction> new_bound_next_function = CreateBoundFunction(
isolate, break_iterator_holder, Builtins::kBreakIteratorInternalNext, 0);
Handle<JSFunction> new_bound_next_function =
CreateBoundFunction(isolate, break_iterator_holder,
Builtins::kV8BreakIteratorInternalNext, 0);
break_iterator_holder->set_bound_next(*new_bound_next_function);
return *new_bound_next_function;
}
BUILTIN(BreakIteratorInternalNext) {
BUILTIN(V8BreakIteratorInternalNext) {
HandleScope scope(isolate);
Handle<Context> context = Handle<Context>(isolate->context(), isolate);
......@@ -1345,7 +1347,7 @@ BUILTIN(BreakIteratorInternalNext) {
return *isolate->factory()->NewNumberFromInt(break_iterator->next());
}
BUILTIN(BreakIteratorPrototypeCurrent) {
BUILTIN(V8BreakIteratorPrototypeCurrent) {
const char* const method = "get Intl.v8BreakIterator.prototype.current";
HandleScope scope(isolate);
......@@ -1359,12 +1361,12 @@ BUILTIN(BreakIteratorPrototypeCurrent) {
Handle<JSFunction> new_bound_current_function =
CreateBoundFunction(isolate, break_iterator_holder,
Builtins::kBreakIteratorInternalCurrent, 0);
Builtins::kV8BreakIteratorInternalCurrent, 0);
break_iterator_holder->set_bound_current(*new_bound_current_function);
return *new_bound_current_function;
}
BUILTIN(BreakIteratorInternalCurrent) {
BUILTIN(V8BreakIteratorInternalCurrent) {
HandleScope scope(isolate);
Handle<Context> context = Handle<Context>(isolate->context(), isolate);
......@@ -1380,7 +1382,7 @@ BUILTIN(BreakIteratorInternalCurrent) {
return *isolate->factory()->NewNumberFromInt(break_iterator->current());
}
BUILTIN(BreakIteratorPrototypeBreakType) {
BUILTIN(V8BreakIteratorPrototypeBreakType) {
const char* const method = "get Intl.v8BreakIterator.prototype.breakType";
HandleScope scope(isolate);
......@@ -1395,12 +1397,12 @@ BUILTIN(BreakIteratorPrototypeBreakType) {
Handle<JSFunction> new_bound_break_type_function =
CreateBoundFunction(isolate, break_iterator_holder,
Builtins::kBreakIteratorInternalBreakType, 0);
Builtins::kV8BreakIteratorInternalBreakType, 0);
break_iterator_holder->set_bound_break_type(*new_bound_break_type_function);
return *new_bound_break_type_function;
}
BUILTIN(BreakIteratorInternalBreakType) {
BUILTIN(V8BreakIteratorInternalBreakType) {
HandleScope scope(isolate);
Handle<Context> context = Handle<Context>(isolate->context(), isolate);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment