Commit 8f8348d9 authored by Mythri A's avatar Mythri A Committed by Commit Bot

Fix DecideToPretenureDuringCompilation to work with --no-lazy-feedback

DecideToPretenureDuringCompilation expects a particular number of
allocation sites. So enable lazy feedback allocation always in the test.
It is possible to make the test work for --no-lazy-feedback-allocation
too, but the test already runs in a controlled environment by setting
various flags so it is OK to enable lazy feeedback allocation to keep
test simple

Bug: v8:10219
Change-Id: I8b979b6df7e7cc27299704823ab691f96abe5431
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2521591Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#71000}
parent bd6cb8b8
......@@ -197,12 +197,6 @@
'test-streaming-compilation/AsyncTestDeserializationBypassesCompilation': [SKIP],
}], # variant == nooptimization
##############################################################################
['variant == no_lfa', {
# https://crbug.com/v8/10219
'test-compiler/DecideToPretenureDuringCompilation': [SKIP],
}], # variant == no_lfa
##############################################################################
['asan == True', {
# Skip tests not suitable for ASAN.
......
......@@ -957,6 +957,9 @@ TEST(DecideToPretenureDuringCompilation) {
FLAG_allow_natives_syntax = true;
FLAG_allocation_site_pretenuring = true;
FLAG_flush_bytecode = false;
// Turn on lazy feedback allocation, so we create exactly one allocation site.
// Without lazy feedback allocation, we create two allocation sites.
FLAG_lazy_feedback_allocation = true;
// We want to trigger exactly 1 optimization.
FLAG_use_osr = false;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment