Commit 8f7e9158 authored by Santiago Aboy Solanes's avatar Santiago Aboy Solanes Committed by Commit Bot

[debugger] Try to trigger pause-on-oom flakes with an extra printf

We have an issue that we can't repro locally. Enable back the
pause-on-oom tests with an extra printf with DEBUG. We will be able to
better assess the failures when they appear on the bot.

Bug: v8:10876
Change-Id: I066539c4b5865ecb6f2e589e9543e8c9ebd4830b
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2474782Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#70558}
parent dcf467a8
......@@ -502,6 +502,10 @@ size_t HeapLimitForDebugging(size_t initial_heap_limit) {
size_t V8Debugger::nearHeapLimitCallback(void* data, size_t current_heap_limit,
size_t initial_heap_limit) {
V8Debugger* thisPtr = static_cast<V8Debugger*>(data);
// TODO(solanes, v8:10876): Remove when bug is solved.
#if DEBUG
printf("nearHeapLimitCallback\n");
#endif
thisPtr->m_originalHeapLimit = current_heap_limit;
thisPtr->m_scheduledOOMBreak = true;
v8::Local<v8::Context> context =
......
Check pause on OOM
nearHeapLimitCallback
reason: OOM
Check pause on OOM
nearHeapLimitCallback
reason: OOM
......@@ -22,11 +22,12 @@
}], # ALWAYS
##############################################################################
['arch == x64 and mode == debug', {
# Flaky tests: https://crbug.com/v8/10876
'debugger/pause-on-oom-extrawide': [PASS, FAIL],
'debugger/pause-on-oom-wide': [PASS, FAIL],
}], # 'arch == x64 and mode == debug'
['mode != debug', {
# Investigating flaky tests: https://crbug.com/v8/10876. Enable only on debug.
'debugger/pause-on-oom': [SKIP],
'debugger/pause-on-oom-wide': [SKIP],
'debugger/pause-on-oom-extrawide': [SKIP],
}], # 'mode != debug'
##############################################################################
['system == android', {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment