Remove flag to disable microtasks scope consistency checks

Bug: chromium:728583
Change-Id: Ie7a46ff884ae9474d342c50e5c6cdcf5c0c0e46a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2874397Reviewed-by: Camillo Bruni <cbruni@chromium.org>
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74434}

BUILD.gn

@@ -211,10 +211,6 @@ declare_args() {
                       (is_linux || is_chromeos || is_mac)) ||
                      (v8_current_cpu == "ppc64" && (is_linux || is_chromeos))
 
-  # Temporary flag to allow embedders to update their microtasks scopes
-  # while rolling in a new version of V8.
-  v8_check_microtasks_scopes_consistency = ""
-
   # Enable mitigations for executing untrusted code.
   # Disabled by default on ia32 due to conflicting requirements with embedded
   # builtins. Enabled by default on Android since it doesn't support
@@ -348,10 +344,6 @@ if (v8_enable_snapshot_code_comments) {
 if (v8_enable_debug_code == "") {
   v8_enable_debug_code = v8_enable_debugging_features
 }
-if (v8_check_microtasks_scopes_consistency == "") {
-  v8_check_microtasks_scopes_consistency =
-      v8_enable_debugging_features || dcheck_always_on
-}
 if (v8_enable_snapshot_native_code_counters == "") {
   v8_enable_snapshot_native_code_counters = v8_enable_debugging_features
 }
@@ -802,9 +794,6 @@ config("features") {
   if (v8_enable_lazy_source_positions) {
     defines += [ "V8_ENABLE_LAZY_SOURCE_POSITIONS" ]
   }
-  if (v8_check_microtasks_scopes_consistency) {
-    defines += [ "V8_CHECK_MICROTASKS_SCOPES_CONSISTENCY" ]
-  }
   if (v8_use_multi_snapshots) {
     defines += [ "V8_MULTI_SNAPSHOTS" ]
   }

src/api/api-inl.h

@@ -175,8 +175,7 @@ class V8_NODISCARD CallDepthScope {
     }
     if (!escaped_) isolate_->thread_local_top()->DecrementCallDepth(this);
     if (do_callback) isolate_->FireCallCompletedCallback(microtask_queue);
-// TODO(jochen): This should be #ifdef DEBUG
-#ifdef V8_CHECK_MICROTASKS_SCOPES_CONSISTENCY
+#ifdef DEBUG
     if (do_callback) {
       if (microtask_queue && microtask_queue->microtasks_policy() ==
                                  v8::MicrotasksPolicy::kScoped) {

src/api/api-macros.h

@@ -126,7 +126,3 @@
   EXCEPTION_BAILOUT_CHECK_SCOPED_DO_NOT_USE(isolate, Nothing<T>())
 
 #define RETURN_ESCAPED(value) return handle_scope.Escape(value);
-
-// TODO(jochen): This should be #ifdef DEBUG
-#ifdef V8_CHECK_MICROTASKS_SCOPES_CONSISTENCY
-#endif