Commit 8e3d776d authored by machenbach's avatar machenbach Committed by Commit bot

Revert of [V8] Use previous token location as EOS token location (patchset #2...

Revert of [V8] Use previous token location as EOS token location (patchset #2 id:20001 of https://codereview.chromium.org/1100993003/)

Reason for revert:
[Sheriff] Speculative revert. This seems to block the current roll:
https://codereview.chromium.org/1124463003/

This bisect also points at this CL:
https://codereview.chromium.org/1124523002/

Please prepare the chromium side tests before a reland.

Original issue's description:
> [V8] Use previous token location as EOS token location
>
> EOS token location is useless for users and messages.js are not ready for its location.
> With this CL we use location of token before EOS for it.
>
> LOG=Y
> BUG=chromium:480652
> R=yurys@chromium.org,yangguo@chromium.org
>
> Committed: https://crrev.com/81afc9313ce84350bcba9f84b255a77e97cd3726
> Cr-Commit-Position: refs/heads/master@{#28164}

TBR=yangguo@chromium.org,yurys@chromium.org,kozyatinskiy@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:480652

Review URL: https://codereview.chromium.org/1116233004

Cr-Commit-Position: refs/heads/master@{#28187}
parent 4beb17b7
...@@ -225,10 +225,6 @@ static const byte one_char_tokens[] = { ...@@ -225,10 +225,6 @@ static const byte one_char_tokens[] = {
Token::Value Scanner::Next() { Token::Value Scanner::Next() {
if (next_.token == Token::EOS) {
next_.location.beg_pos = current_.location.beg_pos;
next_.location.end_pos = current_.location.end_pos;
}
current_ = next_; current_ = next_;
has_line_terminator_before_next_ = false; has_line_terminator_before_next_ = false;
has_multiline_comment_before_next_ = false; has_multiline_comment_before_next_ = false;
......
...@@ -12565,18 +12565,6 @@ THREADED_TEST(TryCatchSourceInfo) { ...@@ -12565,18 +12565,6 @@ THREADED_TEST(TryCatchSourceInfo) {
} }
THREADED_TEST(TryCatchSourceInfoForEOSError) {
LocalContext context;
v8::HandleScope scope(context->GetIsolate());
v8::TryCatch try_catch;
v8::Script::Compile(v8_str("!\n"));
CHECK(try_catch.HasCaught());
v8::Handle<v8::Message> message = try_catch.Message();
CHECK_EQ(1, message->GetLineNumber());
CHECK_EQ(0, message->GetStartColumn());
}
THREADED_TEST(CompilationCache) { THREADED_TEST(CompilationCache) {
LocalContext context; LocalContext context;
v8::HandleScope scope(context->GetIsolate()); v8::HandleScope scope(context->GetIsolate());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment