Commit 8de3a2ca authored by Jakob Gruber's avatar Jakob Gruber Committed by Commit Bot

Reland "[nojit] Check that --jitless is disabled when creating wasm code"

This is a reland of 0befa6d4

Original change's description:
> [nojit] Check that --jitless is disabled when creating wasm code
>
> Drive-by: Amend wasm test skips for lite mode.
>
> Bug: v8:7777
> Change-Id: I23e13b65e548c19d6b24a26e0b962a9978f54ed7
> Reviewed-on: https://chromium-review.googlesource.com/c/1449616
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Commit-Queue: Jakob Gruber <jgruber@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#59314}

Tbr: mstarzinger@chromium.org
Bug: v8:7777
Change-Id: I0a076b36bb2e69b612df89b0f35067f299f27a7e
Reviewed-on: https://chromium-review.googlesource.com/c/1451819
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59325}
parent 9023013f
...@@ -445,6 +445,8 @@ WasmCode* NativeModule::AddOwnedCode( ...@@ -445,6 +445,8 @@ WasmCode* NativeModule::AddOwnedCode(
OwnedVector<const byte> reloc_info, OwnedVector<const byte> reloc_info,
OwnedVector<const byte> source_position_table, WasmCode::Kind kind, OwnedVector<const byte> source_position_table, WasmCode::Kind kind,
WasmCode::Tier tier) { WasmCode::Tier tier) {
CHECK(!FLAG_jitless); // TODO(jgruber): Support wasm in jitless mode.
WasmCode* code; WasmCode* code;
{ {
// Both allocation and insertion in owned_code_ happen in the same critical // Both allocation and insertion in owned_code_ happen in the same critical
......
...@@ -528,6 +528,7 @@ ...@@ -528,6 +528,7 @@
'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [SKIP], 'test-heap/IncrementalMarkingStepMakesBigProgressWithLargeObjects': [SKIP],
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode. # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
'test-api/WasmStreamingFinishWithSuccess': [SKIP],
'test-c-wasm-entry/*': [SKIP], 'test-c-wasm-entry/*': [SKIP],
'test-jump-table-assembler/*': [SKIP], 'test-jump-table-assembler/*': [SKIP],
'test-run-wasm-64/*': [SKIP], 'test-run-wasm-64/*': [SKIP],
...@@ -535,6 +536,7 @@ ...@@ -535,6 +536,7 @@
'test-run-wasm-atomics64/*': [SKIP], 'test-run-wasm-atomics64/*': [SKIP],
'test-run-wasm-atomics/*': [SKIP], 'test-run-wasm-atomics/*': [SKIP],
'test-run-wasm/*': [SKIP], 'test-run-wasm/*': [SKIP],
'test-run-wasm-exceptions/*': [SKIP],
'test-run-wasm-interpreter/*': [SKIP], 'test-run-wasm-interpreter/*': [SKIP],
'test-run-wasm-js/*': [SKIP], 'test-run-wasm-js/*': [SKIP],
'test-run-wasm-module/*': [SKIP], 'test-run-wasm-module/*': [SKIP],
......
...@@ -127,6 +127,7 @@ ...@@ -127,6 +127,7 @@
['lite_mode', { ['lite_mode', {
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode. # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
'debug/wasm/*': [SKIP], 'debug/wasm/*': [SKIP],
'regress/regress-crbug-840288': [SKIP],
'wasm-*': [SKIP], 'wasm-*': [SKIP],
}], # lite_mode }], # lite_mode
......
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode. # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
'multi_return/*': [SKIP], 'multi_return/*': [SKIP],
'wasm_async/*': [SKIP], 'wasm_async/*': [SKIP],
'wasm_code/*': [SKIP],
'wasm_compile/*': [SKIP], 'wasm_compile/*': [SKIP],
}], # lite_mode }], # lite_mode
......
...@@ -56,6 +56,7 @@ ...@@ -56,6 +56,7 @@
############################################################################## ##############################################################################
['lite_mode', { ['lite_mode', {
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode. # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
'mjsunit/fail/assert-promise-result-wasm-compile-fail': [SKIP],
'fail/wasm-*': [SKIP], 'fail/wasm-*': [SKIP],
'wasm-*': [SKIP], 'wasm-*': [SKIP],
......
...@@ -349,6 +349,11 @@ ...@@ -349,6 +349,11 @@
'spread-large-array': [SKIP], 'spread-large-array': [SKIP],
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode. # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
'regress/regress-5888': [SKIP],
'regress/regress-5911': [SKIP],
'regress/regress-813440': [SKIP],
'regress/regress-crbug-746835': [SKIP],
'regress/regress-crbug-772056': [SKIP],
'regress/wasm/*': [SKIP], 'regress/wasm/*': [SKIP],
'tools/compiler-trace-flags': [SKIP], 'tools/compiler-trace-flags': [SKIP],
'wasm/*': [SKIP], 'wasm/*': [SKIP],
......
...@@ -25,6 +25,7 @@ ...@@ -25,6 +25,7 @@
['lite_mode', { ['lite_mode', {
# TODO(v8:7777): Re-enable once wasm is supported in jitless mode. # TODO(v8:7777): Re-enable once wasm is supported in jitless mode.
'ValueSerializerTestWithWasm.*': [SKIP], 'ValueSerializerTestWithWasm.*': [SKIP],
'Parameterized/WasmCodeManagerTest.*': [SKIP],
}], # lite_mode }], # lite_mode
] ]
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment