Commit 8dd5b65e authored by Dominik Inführ's avatar Dominik Inführ Committed by V8 LUCI CQ

Disable DCHECK for map packing in other configurations

The DCHECK seems to fail with MSVC on x86 builds. This CL disables this
DCHECK when map packing isn't enabled until we have a proper fix.

Bug: v8:11748, v8:11624
Change-Id: Iec98d161c5cd2b6a910c29287b54c8e3de017e83
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2878735Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#74430}
parent edd27c77
...@@ -178,7 +178,7 @@ class V8_EXPORT_PRIVATE RawMachineAssembler { ...@@ -178,7 +178,7 @@ class V8_EXPORT_PRIVATE RawMachineAssembler {
MachineType type, Node* base, Node* offset, MachineType type, Node* base, Node* offset,
LoadSensitivity needs_poisoning = LoadSensitivity::kSafe) { LoadSensitivity needs_poisoning = LoadSensitivity::kSafe) {
CHECK_EQ(needs_poisoning, LoadSensitivity::kSafe); CHECK_EQ(needs_poisoning, LoadSensitivity::kSafe);
DCHECK_IMPLIES(IsMapOffsetConstantMinusTag(offset), DCHECK_IMPLIES(V8_MAP_PACKING_BOOL && IsMapOffsetConstantMinusTag(offset),
type == MachineType::MapInHeader()); type == MachineType::MapInHeader());
ObjectAccess access = {type, WriteBarrierKind::kNoWriteBarrier}; ObjectAccess access = {type, WriteBarrierKind::kNoWriteBarrier};
Node* load = AddNode(simplified()->LoadFromObject(access), base, offset); Node* load = AddNode(simplified()->LoadFromObject(access), base, offset);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment