Commit 8d6f2b47 authored by Mythri A's avatar Mythri A Committed by Commit Bot

[cleanup][ic] TNodify last few occurences in accessor-assembler.cc


Bug: v8:9810
Change-Id: I6d7b9099a53badfdfdfa6b57211931b39ae72124
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1917154Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65034}
parent 386e7dd2
...@@ -142,8 +142,7 @@ void AccessorAssembler::HandleLoadICHandlerCase( ...@@ -142,8 +142,7 @@ void AccessorAssembler::HandleLoadICHandlerCase(
TVARIABLE(Object, var_holder, p->holder()); TVARIABLE(Object, var_holder, p->holder());
TVARIABLE(Object, var_smi_handler, handler); TVARIABLE(Object, var_smi_handler, handler);
Variable* vars[] = {&var_holder, &var_smi_handler}; Label if_smi_handler(this, {&var_holder, &var_smi_handler});
Label if_smi_handler(this, 2, vars);
Label try_proto_handler(this, Label::kDeferred), Label try_proto_handler(this, Label::kDeferred),
call_handler(this, Label::kDeferred); call_handler(this, Label::kDeferred);
...@@ -234,7 +233,7 @@ void AccessorAssembler::HandleLoadAccessor( ...@@ -234,7 +233,7 @@ void AccessorAssembler::HandleLoadAccessor(
void AccessorAssembler::HandleLoadField(TNode<JSObject> holder, void AccessorAssembler::HandleLoadField(TNode<JSObject> holder,
TNode<WordT> handler_word, TNode<WordT> handler_word,
Variable* var_double_value, TVariable<Float64T>* var_double_value,
Label* rebox_double, Label* miss, Label* rebox_double, Label* miss,
ExitPoint* exit_point) { ExitPoint* exit_point) {
Comment("field_load"); Comment("field_load");
...@@ -254,8 +253,7 @@ void AccessorAssembler::HandleLoadField(TNode<JSObject> holder, ...@@ -254,8 +253,7 @@ void AccessorAssembler::HandleLoadField(TNode<JSObject> holder,
BIND(&is_double); BIND(&is_double);
if (FLAG_unbox_double_fields) { if (FLAG_unbox_double_fields) {
var_double_value->Bind( *var_double_value = LoadObjectField<Float64T>(holder, offset);
LoadObjectField(holder, offset, MachineType::Float64()));
} else { } else {
TNode<Object> heap_number = LoadObjectField(holder, offset); TNode<Object> heap_number = LoadObjectField(holder, offset);
// This is not an "old" Smi value from before a Smi->Double transition. // This is not an "old" Smi value from before a Smi->Double transition.
...@@ -263,7 +261,7 @@ void AccessorAssembler::HandleLoadField(TNode<JSObject> holder, ...@@ -263,7 +261,7 @@ void AccessorAssembler::HandleLoadField(TNode<JSObject> holder,
// field transitioned to a Tagged field, and was then assigned a Smi. // field transitioned to a Tagged field, and was then assigned a Smi.
GotoIf(TaggedIsSmi(heap_number), miss); GotoIf(TaggedIsSmi(heap_number), miss);
GotoIfNot(IsHeapNumber(CAST(heap_number)), miss); GotoIfNot(IsHeapNumber(CAST(heap_number)), miss);
var_double_value->Bind(LoadHeapNumberValue(CAST(heap_number))); *var_double_value = LoadHeapNumberValue(CAST(heap_number));
} }
Goto(rebox_double); Goto(rebox_double);
} }
...@@ -284,7 +282,7 @@ void AccessorAssembler::HandleLoadField(TNode<JSObject> holder, ...@@ -284,7 +282,7 @@ void AccessorAssembler::HandleLoadField(TNode<JSObject> holder,
GotoIf(TaggedIsSmi(value), miss); GotoIf(TaggedIsSmi(value), miss);
GotoIfNot(IsHeapNumber(CAST(value)), miss); GotoIfNot(IsHeapNumber(CAST(value)), miss);
} }
var_double_value->Bind(LoadHeapNumberValue(CAST(value))); *var_double_value = LoadHeapNumberValue(CAST(value));
Goto(rebox_double); Goto(rebox_double);
} }
} }
...@@ -459,7 +457,7 @@ void AccessorAssembler::HandleLoadICSmiHandlerCase( ...@@ -459,7 +457,7 @@ void AccessorAssembler::HandleLoadICSmiHandlerCase(
void AccessorAssembler::HandleLoadICSmiHandlerLoadNamedCase( void AccessorAssembler::HandleLoadICSmiHandlerLoadNamedCase(
const LazyLoadICParameters* p, TNode<Object> holder, const LazyLoadICParameters* p, TNode<Object> holder,
TNode<IntPtrT> handler_kind, TNode<WordT> handler_word, Label* rebox_double, TNode<IntPtrT> handler_kind, TNode<WordT> handler_word, Label* rebox_double,
Variable* var_double_value, TNode<Object> handler, Label* miss, TVariable<Float64T>* var_double_value, TNode<Object> handler, Label* miss,
ExitPoint* exit_point, ICMode ic_mode, OnNonExistent on_nonexistent, ExitPoint* exit_point, ICMode ic_mode, OnNonExistent on_nonexistent,
ElementSupport support_elements) { ElementSupport support_elements) {
Label constant(this), field(this), normal(this, Label::kDeferred), Label constant(this), field(this), normal(this, Label::kDeferred),
...@@ -1984,7 +1982,7 @@ TNode<PropertyArray> AccessorAssembler::ExtendPropertiesBackingStore( ...@@ -1984,7 +1982,7 @@ TNode<PropertyArray> AccessorAssembler::ExtendPropertiesBackingStore(
GotoIf(UintPtrLessThan(index, ParameterToIntPtr(var_length.value(), mode)), GotoIf(UintPtrLessThan(index, ParameterToIntPtr(var_length.value(), mode)),
&done); &done);
Node* delta = IntPtrOrSmiConstant(JSObject::kFieldsAdded, mode); TNode<BInt> delta = BIntConstant(JSObject::kFieldsAdded);
Node* new_capacity = IntPtrOrSmiAdd(var_length.value(), delta, mode); Node* new_capacity = IntPtrOrSmiAdd(var_length.value(), delta, mode);
// Grow properties array. // Grow properties array.
...@@ -2468,8 +2466,7 @@ void AccessorAssembler::GenericPropertyLoad(TNode<HeapObject> receiver, ...@@ -2468,8 +2466,7 @@ void AccessorAssembler::GenericPropertyLoad(TNode<HeapObject> receiver,
TVARIABLE(Map, var_holder_map); TVARIABLE(Map, var_holder_map);
TVARIABLE(Int32T, var_holder_instance_type); TVARIABLE(Int32T, var_holder_instance_type);
Label return_undefined(this), is_private_symbol(this); Label return_undefined(this), is_private_symbol(this);
Variable* merged_variables[] = {&var_holder_map, &var_holder_instance_type}; Label loop(this, {&var_holder_map, &var_holder_instance_type});
Label loop(this, arraysize(merged_variables), merged_variables);
var_holder_map = receiver_map; var_holder_map = receiver_map;
var_holder_instance_type = instance_type; var_holder_instance_type = instance_type;
......
...@@ -286,8 +286,8 @@ class V8_EXPORT_PRIVATE AccessorAssembler : public CodeStubAssembler { ...@@ -286,8 +286,8 @@ class V8_EXPORT_PRIVATE AccessorAssembler : public CodeStubAssembler {
TNode<IntPtrT> handler_kind, ExitPoint* exit_point); TNode<IntPtrT> handler_kind, ExitPoint* exit_point);
void HandleLoadField(TNode<JSObject> holder, TNode<WordT> handler_word, void HandleLoadField(TNode<JSObject> holder, TNode<WordT> handler_word,
Variable* var_double_value, Label* rebox_double, TVariable<Float64T>* var_double_value,
Label* miss, ExitPoint* exit_point); Label* rebox_double, Label* miss, ExitPoint* exit_point);
void EmitAccessCheck(TNode<Context> expected_native_context, void EmitAccessCheck(TNode<Context> expected_native_context,
TNode<Context> context, TNode<Object> receiver, TNode<Context> context, TNode<Object> receiver,
...@@ -296,8 +296,8 @@ class V8_EXPORT_PRIVATE AccessorAssembler : public CodeStubAssembler { ...@@ -296,8 +296,8 @@ class V8_EXPORT_PRIVATE AccessorAssembler : public CodeStubAssembler {
void HandleLoadICSmiHandlerLoadNamedCase( void HandleLoadICSmiHandlerLoadNamedCase(
const LazyLoadICParameters* p, TNode<Object> holder, const LazyLoadICParameters* p, TNode<Object> holder,
TNode<IntPtrT> handler_kind, TNode<WordT> handler_word, TNode<IntPtrT> handler_kind, TNode<WordT> handler_word,
Label* rebox_double, Variable* var_double_value, TNode<Object> handler, Label* rebox_double, TVariable<Float64T>* var_double_value,
Label* miss, ExitPoint* exit_point, ICMode ic_mode, TNode<Object> handler, Label* miss, ExitPoint* exit_point, ICMode ic_mode,
OnNonExistent on_nonexistent, ElementSupport support_elements); OnNonExistent on_nonexistent, ElementSupport support_elements);
void HandleLoadICSmiHandlerHasNamedCase(const LazyLoadICParameters* p, void HandleLoadICSmiHandlerHasNamedCase(const LazyLoadICParameters* p,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment