Reland "[cleanup] Remove harmony-intl-dateformat-day-period"

This is a reland of 5e041b82

Original change's description:
> [cleanup] Remove harmony-intl-dateformat-day-period
>
> harmony-intl-dateformat-day-period is shipped in M92
>
> Bug: v8:12109
> Change-Id: I7d24463c0cc353c4baf52326159beb04592b81b5
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3099087
> Reviewed-by: Shu-yu Guo <syg@chromium.org>
> Commit-Queue: Frank Tang <ftang@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#76468}

Bug: v8:12109
Change-Id: Iff4a9c706d0b0092f077d67e4e840292bd8024a9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3276921Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77909}

src/flags/flag-definitions.h

@@ -346,8 +346,6 @@ DEFINE_BOOL(harmony_shipping, true, "enable all shipped harmony features")
 #ifdef V8_INTL_SUPPORT
 #define HARMONY_SHIPPING(V)                               \
   HARMONY_SHIPPING_BASE(V)                                \
-  V(harmony_intl_dateformat_day_period,                   \
-    "Add dayPeriod option to DateTimeFormat")             \
   V(harmony_intl_displaynames_v2, "Intl.DisplayNames v2") \
   V(harmony_intl_more_timezone,                           \
     "Extend Intl.DateTimeFormat timeZoneName Option")

src/init/bootstrapper.cc

@@ -4381,7 +4381,6 @@ EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_error_cause)
 #ifdef V8_INTL_SUPPORT
 EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_intl_best_fit_matcher)
 EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_intl_displaynames_v2)
-EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_intl_dateformat_day_period)
 EMPTY_INITIALIZE_GLOBAL_FOR_FEATURE(harmony_intl_more_timezone)
 #endif  // V8_INTL_SUPPORT
 

src/objects/js-date-time-format.cc

@@ -145,16 +145,14 @@ static std::vector<PatternItem> BuildPatternItems() {
                               kNarrowLongShort2DigitNumeric));
   items.push_back(PatternItem("day", {{"dd", "2-digit"}, {"d", "numeric"}},
                               k2DigitNumeric));
-  if (FLAG_harmony_intl_dateformat_day_period) {
-    items.push_back(PatternItem("dayPeriod",
-                                {{"BBBBB", "narrow"},
-                                 {"bbbbb", "narrow"},
-                                 {"BBBB", "long"},
-                                 {"bbbb", "long"},
-                                 {"B", "short"},
-                                 {"b", "short"}},
-                                kNarrowLongShort));
-  }
+  items.push_back(PatternItem("dayPeriod",
+                              {{"BBBBB", "narrow"},
+                               {"bbbbb", "narrow"},
+                               {"BBBB", "long"},
+                               {"bbbb", "long"},
+                               {"B", "short"},
+                               {"b", "short"}},
+                              kNarrowLongShort));
   items.push_back(PatternItem("hour",
                               {{"HH", "2-digit"},
                                {"H", "numeric"},
@@ -929,9 +927,7 @@ MaybeHandle<JSObject> JSDateTimeFormat::ToDateTimeOptions(
     // a. For each of the property names "dayPeriod", "hour", "minute",
     // "second", "fractionalSecondDigits", do
     std::vector<Handle<String>> list;
-    if (FLAG_harmony_intl_dateformat_day_period) {
-      list.push_back(factory->dayPeriod_string());
-    }
+    list.push_back(factory->dayPeriod_string());
     list.push_back(factory->hour_string());
     list.push_back(factory->minute_string());
     list.push_back(factory->second_string());

test/test262/testcfg.py

@@ -44,7 +44,6 @@ from testrunner.outproc import test262
 
 # TODO(littledan): move the flag mapping into the status file
 FEATURE_FLAGS = {
-  'Intl.DateTimeFormat-dayPeriod': '--harmony-intl-dateformat-day-period',
   'Intl.Locale-info': '--harmony_intl_locale_info',
   'Intl.DateTimeFormat-extend-timezonename': '--harmony_intl_more_timezone',
   'Intl.DisplayNames-v2': '--harmony_intl_displaynames_v2',