Commit 8a41a706 authored by Hidehiko Abe's avatar Hidehiko Abe Committed by Commit Bot

v8: Expand is_linux to is_linux || is_chromeos.

Currently is_linux GN variable is set to true on building Chrome OS
but it is planned to be set false. This CL is the preparation to
keep the compatibility.

Bug: chromium:1110266
Test: Built locally.
Change-Id: Ibb9a57269f5a147e372fd33a473d9514379e1c68
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2405847Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#69870}
parent 949a8174
......@@ -187,9 +187,9 @@ declare_args() {
# Controls the threshold for on-heap/off-heap Typed Arrays.
v8_typed_array_max_size_in_heap = 64
v8_enable_gdbjit =
((v8_current_cpu == "x86" || v8_current_cpu == "x64") &&
(is_linux || is_mac)) || (v8_current_cpu == "ppc64" && is_linux)
v8_enable_gdbjit = ((v8_current_cpu == "x86" || v8_current_cpu == "x64") &&
(is_linux || is_chromeos || is_mac)) ||
(v8_current_cpu == "ppc64" && (is_linux || is_chromeos))
# Temporary flag to allow embedders to update their microtasks scopes
# while rolling in a new version of V8.
......@@ -342,7 +342,7 @@ assert(v8_current_cpu == "arm64" || !v8_control_flow_integrity,
if (v8_enable_shared_ro_heap && v8_enable_pointer_compression) {
assert(
is_linux || is_android,
is_linux || is_chromeos || is_android,
"Sharing read-only heap with pointer compression is only supported on Linux or Android")
}
......@@ -861,7 +861,7 @@ config("toolchain") {
# TODO(jochen): Add support for compiling with simulators.
if (v8_enable_debugging_features) {
if (is_linux && v8_enable_backtrace) {
if ((is_linux || is_chromeos) && v8_enable_backtrace) {
ldflags += [ "-rdynamic" ]
}
......@@ -1303,9 +1303,9 @@ template("run_torque") {
action("run_torque" + suffix) {
visibility = [
":*",
"test/cctest/:*",
"tools/debug_helper/:*",
"tools/gcmole/:*",
"test/cctest/:*",
]
deps = [ ":torque($toolchain)" ]
......@@ -3477,7 +3477,7 @@ v8_source_set("v8_base_without_compiler") {
# iOS Xcode simulator builds run on an x64 target. iOS and macOS are both
# based on Darwin and thus POSIX-compliant to a similar degree.
if (is_linux || is_mac || is_ios || target_os == "freebsd") {
if (is_linux || is_chromeos || is_mac || is_ios || target_os == "freebsd") {
sources += [
"src/trap-handler/handler-inside-posix.cc",
"src/trap-handler/handler-inside-posix.h",
......@@ -3822,7 +3822,7 @@ v8_source_set("v8_base_without_compiler") {
libs += [ "atomic" ]
}
if (v8_enable_vtunetracemark && (is_linux || is_win)) {
if (v8_enable_vtunetracemark && (is_linux || is_chromeos || is_win)) {
sources += [
"src/extensions/vtunedomain-support-extension.cc",
"src/extensions/vtunedomain-support-extension.h",
......@@ -4067,7 +4067,7 @@ v8_component("v8_libbase") {
}
}
if (is_linux) {
if (is_linux || is_chromeos) {
sources += [
"src/base/debug/stack_trace_posix.cc",
"src/base/platform/platform-linux.cc",
......
......@@ -221,7 +221,7 @@ template("v8_executable") {
configs -= invoker.remove_configs
}
configs += invoker.configs
if (is_linux) {
if (is_linux || is_chromeos) {
# For enabling ASLR.
ldflags = [ "-pie" ]
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment