Commit 891bbe2c authored by yangguo's avatar yangguo Committed by Commit bot

[inspector] correctly test more variants.

This flushed out a number of bugs.

To reproduce, remove the inspector.status file entries, build with GN,
and run `tools/run-tests.py --gn --exhaustive-variants inspector`.

R=mstarzinger@chromium.org
BUG=v8:6165,v8:6166,v8:6167,v8:6168,v8:6170,v8:6171

Review-Url: https://codereview.chromium.org/2777413005
Cr-Commit-Position: refs/heads/master@{#44242}
parent 367d646a
......@@ -686,7 +686,8 @@ int main(int argc, char* argv[]) {
task_runners.push_back(&backend_runner);
for (int i = 1; i < argc; ++i) {
if (argv[i][0] == '-') break;
// Ignore unknown flags.
if (argv[i][0] == '-') continue;
bool exists = false;
v8::internal::Vector<const char> chars =
......
......@@ -3,6 +3,30 @@
# found in the LICENSE file.
[
['mode == debug', {
# Issue 6168. Crash.
'runtime/await-promise': [SKIP],
}],
##############################################################################
['variant != default', {
# Issue 6165.
'cpu-profiler/coverage': [PASS, FAIL],
# Issue 6166.
'debugger/asm-js-breakpoint-during-exec': [PASS, FAIL],
'debugger/asm-js-stack': [PASS, FAIL],
# Issue 6167.
'debugger/eval-scopes': [PASS, FAIL],
'debugger/scope-skip-variables-with-empty-name': [PASS, FAIL],
'debugger/update-call-frame-scopes': [PASS, FAIL],
'debugger/side-effect-free-debug-evaluate': [PASS, FAIL],
# Issue 6170. Crash.
'cpu-profiler/console-profile': [SKIP],
'cpu-profiler/console-profile-end-parameterless-crash': [SKIP],
# Issue 6171. Timeout.
'debugger/set-blackbox-patterns': [SKIP],
'debugger/suspended-generator-scopes': [SKIP],
}], # variant != default
##############################################################################
['variant == wasm_traps', {
......
......@@ -40,14 +40,14 @@ class InspectorProtocolTestSuite(testsuite.TestSuite):
def GetFlagsForTestCase(self, testcase, context):
source = self.GetSourceForTest(testcase)
flags = [] + context.mode_flags
flags_match = re.findall(FLAGS_PATTERN, source)
flags = []
for match in flags_match:
flags += match.strip().split()
testname = testcase.path.split(os.path.sep)[-1]
testfilename = os.path.join(self.root, testcase.path + self.suffix())
protocoltestfilename = os.path.join(self.root, PROTOCOL_TEST_JS)
return [ protocoltestfilename, testfilename ] + flags
return testcase.flags + flags + [ protocoltestfilename, testfilename ]
def GetSourceForTest(self, testcase):
filename = os.path.join(self.root, testcase.path + self.suffix())
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment