Commit 88e02e7d authored by Clemens Hammacher's avatar Clemens Hammacher Committed by Commit Bot

[wasm] Slightly simplify deadline computation

Avoiding the helper function to get the time in milliseconds avoids
redundantly getting the current platform and simplifies code.

R=mstarzinger@chromium.org

Bug: v8:8916
Change-Id: Ie7214f896a14f45aef359ea095a4b0532aeccf77
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561070
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#60744}
parent 58ed098e
...@@ -676,11 +676,6 @@ void RecordStats(const Code code, Counters* counters) { ...@@ -676,11 +676,6 @@ void RecordStats(const Code code, Counters* counters) {
counters->wasm_reloc_size()->Increment(code->relocation_info()->length()); counters->wasm_reloc_size()->Increment(code->relocation_info()->length());
} }
double MonotonicallyIncreasingTimeInMs() {
return V8::GetCurrentPlatform()->MonotonicallyIncreasingTime() *
base::Time::kMillisecondsPerSecond;
}
// Run by the main thread to take part in compilation. Only used for synchronous // Run by the main thread to take part in compilation. Only used for synchronous
// compilation. // compilation.
bool FetchAndExecuteCompilationUnit(CompilationEnv* env, bool FetchAndExecuteCompilationUnit(CompilationEnv* env,
...@@ -890,7 +885,12 @@ class BackgroundCompileTask : public CancelableTask { ...@@ -890,7 +885,12 @@ class BackgroundCompileTask : public CancelableTask {
TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.wasm"), TRACE_EVENT0(TRACE_DISABLED_BY_DEFAULT("v8.wasm"),
"BackgroundCompileTask::RunInternal"); "BackgroundCompileTask::RunInternal");
double deadline = MonotonicallyIncreasingTimeInMs() + 50.0; Platform* platform = V8::GetCurrentPlatform();
// Deadline is in 50ms from now.
static constexpr double kBackgroundCompileTimeLimit =
50.0 / base::Time::kMillisecondsPerSecond;
const double deadline =
platform->MonotonicallyIncreasingTime() + kBackgroundCompileTimeLimit;
// These fields are initialized in a {BackgroundCompileScope} before // These fields are initialized in a {BackgroundCompileScope} before
// starting compilation. // starting compilation.
...@@ -934,7 +934,6 @@ class BackgroundCompileTask : public CancelableTask { ...@@ -934,7 +934,6 @@ class BackgroundCompileTask : public CancelableTask {
bool compilation_failed = false; bool compilation_failed = false;
while (true) { while (true) {
// (asynchronous): Execute the compilation. // (asynchronous): Execute the compilation.
WasmCompilationResult result = unit->ExecuteCompilation( WasmCompilationResult result = unit->ExecuteCompilation(
&env.value(), wire_bytes, async_counters_.get(), &detected_features); &env.value(), wire_bytes, async_counters_.get(), &detected_features);
results_to_publish.emplace_back(std::move(result)); results_to_publish.emplace_back(std::move(result));
...@@ -957,7 +956,7 @@ class BackgroundCompileTask : public CancelableTask { ...@@ -957,7 +956,7 @@ class BackgroundCompileTask : public CancelableTask {
} }
// Get next unit. // Get next unit.
if (deadline < MonotonicallyIncreasingTimeInMs()) { if (deadline < platform->MonotonicallyIncreasingTime()) {
unit = nullptr; unit = nullptr;
} else { } else {
unit = compile_scope.compilation_state()->GetNextCompilationUnit( unit = compile_scope.compilation_state()->GetNextCompilationUnit(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment