Remove the --ignition-generators flag.

This flag has been enabled by default for over a month now.

R=mstarzinger@chromium.org, rmcilroy@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2176143002
Cr-Commit-Position: refs/heads/master@{#38020}

src/compiler.cc

@@ -450,11 +450,6 @@ bool ShouldUseIgnition(CompilationInfo* info) {
     return info->shared_info()->HasBytecodeArray();
   }
 
-  // For generator or async functions we might avoid Ignition wholesale.
-  if (info->shared_info()->is_resumable() && !FLAG_ignition_generators) {
-    return false;
-  }
-
   // Since we can't OSR from Ignition, skip Ignition for asm.js functions.
   if (info->shared_info()->asm_function()) {
     return false;

src/flag-definitions.h

@@ -297,8 +297,6 @@ DEFINE_BOOL(string_slices, true, "use string slices")
 // Flags for Ignition.
 DEFINE_BOOL(ignition, false, "use ignition interpreter")
 DEFINE_BOOL(ignition_eager, false, "eagerly compile and parse with ignition")
-DEFINE_BOOL(ignition_generators, true,
-            "enable experimental ignition support for generators")
 DEFINE_STRING(ignition_filter, "*", "filter for ignition interpreter")
 DEFINE_BOOL(ignition_deadcode, true,
             "use ignition dead code elimination optimizer")

test/cctest/interpreter/generate-bytecode-expectations.cc

@@ -44,7 +44,6 @@ class ProgramOptions final {
         execute_(true),
         top_level_(false),
         do_expressions_(false),
-        ignition_generators_(false),
         verbose_(false),
         const_pool_type_(
             BytecodeExpectationsPrinter::ConstantPoolType::kMixed) {}
@@ -65,7 +64,6 @@ class ProgramOptions final {
   bool execute() const { return execute_; }
   bool top_level() const { return top_level_; }
   bool do_expressions() const { return do_expressions_; }
-  bool ignition_generators() const { return ignition_generators_; }
   bool verbose() const { return verbose_; }
   bool suppress_runtime_errors() const { return rebaseline_ && !verbose_; }
   BytecodeExpectationsPrinter::ConstantPoolType const_pool_type() const {
@@ -85,7 +83,6 @@ class ProgramOptions final {
   bool execute_;
   bool top_level_;
   bool do_expressions_;
-  bool ignition_generators_;
   bool verbose_;
   BytecodeExpectationsPrinter::ConstantPoolType const_pool_type_;
   std::vector<std::string> input_filenames_;
@@ -205,8 +202,6 @@ ProgramOptions ProgramOptions::FromCommandLine(int argc, char** argv) {
       options.top_level_ = true;
     } else if (strcmp(argv[i], "--do-expressions") == 0) {
       options.do_expressions_ = true;
-    } else if (strcmp(argv[i], "--ignition-generators") == 0) {
-      options.ignition_generators_ = true;
     } else if (strcmp(argv[i], "--verbose") == 0) {
       options.verbose_ = true;
     } else if (strncmp(argv[i], "--output=", 9) == 0) {
@@ -311,8 +306,6 @@ void ProgramOptions::UpdateFromHeader(std::istream& stream) {
       top_level_ = ParseBoolean(line.c_str() + 11);
     } else if (line.compare(0, 16, "do expressions: ") == 0) {
       do_expressions_ = ParseBoolean(line.c_str() + 16);
-    } else if (line.compare(0, 21, "ignition generators: ") == 0) {
-      ignition_generators_ = ParseBoolean(line.c_str() + 21);
     } else if (line == "---") {
       break;
     } else if (line.empty()) {
@@ -337,7 +330,6 @@ void ProgramOptions::PrintHeader(std::ostream& stream) const {  // NOLINT
 
   if (top_level_) stream << "\ntop level: yes";
   if (do_expressions_) stream << "\ndo expressions: yes";
-  if (ignition_generators_) stream << "\nignition generators: yes";
 
   stream << "\n\n";
 }
@@ -443,7 +435,6 @@ void GenerateExpectationsFile(std::ostream& stream,  // NOLINT
   }
 
   if (options.do_expressions()) i::FLAG_harmony_do_expressions = true;
-  if (options.ignition_generators()) i::FLAG_ignition_generators = true;
 
   stream << "#\n# Autogenerated by generate-bytecode-expectations.\n#\n\n";
   options.PrintHeader(stream);
@@ -496,7 +487,6 @@ void PrintUsage(const char* exec_path) {
          "Specify the name of the test function.\n"
          "  --top-level   Process top level code, not the top-level function.\n"
          "  --do-expressions  Enable harmony_do_expressions flag.\n"
-         "  --ignition-generators  Enable ignition_generators flag.\n"
          "  --output=file.name\n"
          "      Specify the output file. If not specified, output goes to "
          "stdout.\n"

test/cctest/interpreter/test-bytecode-generator.cc

@@ -2224,9 +2224,6 @@ TEST(ClassAndSuperClass) {
 }
 
 TEST(Generators) {
-  bool old_flag = FLAG_ignition_generators;
-  FLAG_ignition_generators = true;
-
   InitializedIgnitionHandleScope scope;
   BytecodeExpectationsPrinter printer(CcTest::isolate(),
                                       ConstantPoolType::kMixed);
@@ -2246,8 +2243,6 @@ TEST(Generators) {
 
   CHECK(CompareTexts(BuildActual(printer, snippets),
                      LoadGolden("Generators.golden")));
-
-  FLAG_ignition_generators = old_flag;
 }
 
 }  // namespace interpreter

test/cctest/interpreter/test-interpreter.cc

@@ -4183,9 +4183,6 @@ TEST(InterpreterIllegalConstDeclaration) {
 }
 
 TEST(InterpreterGenerators) {
-  bool old_flag = FLAG_ignition_generators;
-  FLAG_ignition_generators = true;
-
   HandleAndZoneScope handles;
   i::Isolate* isolate = handles.main_isolate();
   i::Factory* factory = isolate->factory();
@@ -4207,8 +4204,6 @@ TEST(InterpreterGenerators) {
     Handle<i::Object> return_value = callable().ToHandleChecked();
     CHECK(return_value->SameValue(*tests[i].second));
   }
-
-  FLAG_ignition_generators = old_flag;
 }
 
 }  // namespace interpreter

test/js-perf-test/JSTests.json

@@ -23,8 +23,7 @@
       "resources": ["generators.js"],
       "flags": [
         "--harmony-function-sent",
-        "--ignition",
-        "--ignition-generators"
+        "--ignition"
       ],
       "results_regexp": "^Generators\\-Generators\\(Score\\): (.+)$"
     },
@@ -36,7 +35,6 @@
       "flags": [
         "--harmony-function-sent",
         "--ignition",
-        "--ignition-generators",
         "--turbo",
         "--turbo-from-bytecode"
       ],

test/message/generators-throw1.js

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-//
-// Flags: --ignition-generators
 
 function* f() { yield }
 

test/message/generators-throw1.out

-*%(basename)s:7: 42
+*%(basename)s:5: 42
 function* f() { yield }
            ^

test/message/generators-throw2.js

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-//
-// Flags: --ignition-generators
 
 function* f() { yield }
 

test/message/generators-throw2.out

-*%(basename)s:7: 42
+*%(basename)s:5: 42
 function* f() { yield }
                 ^

test/mjsunit/debug-generator-break-on-stack.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-debug-as debug --ignition-generators
+// Flags: --expose-debug-as debug
 
 var Debug = debug.Debug;
 

test/mjsunit/debug-generator-break.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-debug-as debug --ignition-generators
+// Flags: --expose-debug-as debug
 
 var Debug = debug.Debug;
 

test/mjsunit/es6/debug-stepin-generators.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-debug-as debug --ignition-generators
+// Flags: --expose-debug-as debug
 
 Debug = debug.Debug
 var exception = null;

test/mjsunit/es6/generators-debug-liveedit.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-debug-as debug --allow-natives-syntax --ignition-generators
+// Flags: --expose-debug-as debug --allow-natives-syntax
 
 var Debug = debug.Debug;
 var LiveEdit = Debug.LiveEdit;

test/mjsunit/es6/generators-debug-scopes.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-debug-as debug --ignition-generators
+// Flags: --expose-debug-as debug
 
 var Debug = debug.Debug;
 

test/mjsunit/es6/generators-iteration.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --expose-gc --ignition-generators
+// Flags: --expose-gc
 
 // Test generator iteration.
 

test/mjsunit/es6/generators-mirror.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-debug-as debug --ignition-generators
+// Flags: --expose-debug-as debug
 // Test the mirror object for functions.
 
 function *generator(f) {

test/mjsunit/es6/generators-objects.js

@@ -25,7 +25,7 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --allow-natives-syntax --ignition-generators
+// Flags: --allow-natives-syntax
 
 // Test instantations of generators.
 

test/mjsunit/es6/generators-parsing.js

@@ -25,8 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --ignition-generators
-
 // Test basic generator syntax.
 
 // Yield statements.

test/mjsunit/es6/generators-poisoned-properties.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --ignition-generators
-
 (function testRestrictedPropertiesStrict() {
   function* generator() { "use strict"; }
   assertFalse(generator.hasOwnProperty("arguments"));

test/mjsunit/es6/generators-relocation.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --expose-debug-as debug --ignition-generators
+// Flags: --expose-debug-as debug
 
 var Debug = debug.Debug;
 

test/mjsunit/es6/generators-runtime.js

@@ -25,8 +25,6 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-// Flags: --ignition-generators
-
 // Test aspects of the generator runtime.
 
 // See:

test/mjsunit/es6/generators-states.js

@@ -2,8 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --ignition-generators
-
 // Test generator states.
 
 function Foo() {}

test/mjsunit/harmony/debug-async-liveedit.js

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 // Flags: --harmony-async-await
-// Flags: --expose-debug-as debug --allow-natives-syntax --ignition-generators
+// Flags: --expose-debug-as debug --allow-natives-syntax
 
 var Debug = debug.Debug;
 var LiveEdit = Debug.LiveEdit;

test/mjsunit/harmony/generators-turbo.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --ignition --ignition-generators --harmony-do-expressions
+// Flags: --ignition --harmony-do-expressions
 // Flags: --allow-natives-syntax --turbo --turbo-from-bytecode
 
 

test/mjsunit/harmony/generators.js

@@ -2,8 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --ignition-generators --harmony-do-expressions
-// Flags: --allow-natives-syntax
+// Flags: --harmony-do-expressions --allow-natives-syntax
 
 
 function MaybeOptimizeOrDeoptimize(f) {

test/mjsunit/harmony/regress/regress-618603.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --harmony-async-await --ignition-generators
+// Flags: --harmony-async-await
 
 try {
 } catch(e) {; }

test/mjsunit/regress/regress-618657.js

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-// Flags: --ignition --ignition-generators --ignition-filter=-foo
+// Flags: --ignition --ignition-filter=-foo
 
 function* foo() { yield 42 }
 function* goo() { yield 42 }