Commit 87e7fc94 authored by Adam Klein's avatar Adam Klein Committed by Commit Bot

[parser cleanup] Remove a few impl() calls, replace a CHECK with DCHECK

Bug: v8:6092
Change-Id: I518516d3600458faba5ace1eee1e5b5c3cc560ce
Reviewed-on: https://chromium-review.googlesource.com/784127Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49645}
parent c1e9b34f
...@@ -4624,7 +4624,7 @@ typename ParserBase<Impl>::ExpressionT ParserBase<Impl>::ParseTemplateLiteral( ...@@ -4624,7 +4624,7 @@ typename ParserBase<Impl>::ExpressionT ParserBase<Impl>::ParseTemplateLiteral(
// //
// When parsing a TemplateLiteral, we must have scanned either an initial // When parsing a TemplateLiteral, we must have scanned either an initial
// TEMPLATE_SPAN, or a TEMPLATE_TAIL. // TEMPLATE_SPAN, or a TEMPLATE_TAIL.
CHECK(peek() == Token::TEMPLATE_SPAN || peek() == Token::TEMPLATE_TAIL); DCHECK(peek() == Token::TEMPLATE_SPAN || peek() == Token::TEMPLATE_TAIL);
bool forbid_illegal_escapes = !allow_harmony_template_escapes() || !tagged; bool forbid_illegal_escapes = !allow_harmony_template_escapes() || !tagged;
...@@ -5832,7 +5832,7 @@ ParserBase<Impl>::ParseForEachStatementWithoutDeclarations( ...@@ -5832,7 +5832,7 @@ ParserBase<Impl>::ParseForEachStatementWithoutDeclarations(
ForInfo* for_info, ZoneList<const AstRawString*>* labels, bool* ok) { ForInfo* for_info, ZoneList<const AstRawString*>* labels, bool* ok) {
// Initializer is reference followed by in/of. // Initializer is reference followed by in/of.
if (!expression->IsArrayLiteral() && !expression->IsObjectLiteral()) { if (!expression->IsArrayLiteral() && !expression->IsObjectLiteral()) {
expression = impl()->CheckAndRewriteReferenceExpression( expression = CheckAndRewriteReferenceExpression(
expression, lhs_beg_pos, lhs_end_pos, MessageTemplate::kInvalidLhsInFor, expression, lhs_beg_pos, lhs_end_pos, MessageTemplate::kInvalidLhsInFor,
kSyntaxError, CHECK_OK); kSyntaxError, CHECK_OK);
} }
...@@ -6033,7 +6033,7 @@ typename ParserBase<Impl>::StatementT ParserBase<Impl>::ParseForAwaitStatement( ...@@ -6033,7 +6033,7 @@ typename ParserBase<Impl>::StatementT ParserBase<Impl>::ParseForAwaitStatement(
ValidateAssignmentPattern(CHECK_OK); ValidateAssignmentPattern(CHECK_OK);
} else { } else {
impl()->RewriteNonPattern(CHECK_OK); impl()->RewriteNonPattern(CHECK_OK);
each_variable = impl()->CheckAndRewriteReferenceExpression( each_variable = CheckAndRewriteReferenceExpression(
lhs, lhs_beg_pos, lhs_end_pos, MessageTemplate::kInvalidLhsInFor, lhs, lhs_beg_pos, lhs_end_pos, MessageTemplate::kInvalidLhsInFor,
kSyntaxError, CHECK_OK); kSyntaxError, CHECK_OK);
} }
......
...@@ -2590,8 +2590,7 @@ FunctionLiteral* Parser::ParseFunctionLiteral( ...@@ -2590,8 +2590,7 @@ FunctionLiteral* Parser::ParseFunctionLiteral(
const bool is_lazy = const bool is_lazy =
eager_compile_hint == FunctionLiteral::kShouldLazyCompile; eager_compile_hint == FunctionLiteral::kShouldLazyCompile;
const bool is_top_level = const bool is_top_level = AllowsLazyParsingWithoutUnresolvedVariables();
impl()->AllowsLazyParsingWithoutUnresolvedVariables();
const bool is_lazy_top_level_function = is_lazy && is_top_level; const bool is_lazy_top_level_function = is_lazy && is_top_level;
const bool is_lazy_inner_function = is_lazy && !is_top_level; const bool is_lazy_inner_function = is_lazy && !is_top_level;
const bool is_expression = const bool is_expression =
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment