[turbofan] rename GraphAssembler::ToNumber

Rename ToNumber to PlainPrimitiveToNumber since it must only be used on
primitives, as we assume that it never throws and has no side effects.

Change-Id: I78880545e58e46d38712f5ab75fe0b627ad178c5
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002394
Auto-Submit: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#65796}

src/compiler/effect-control-linearizer.cc

@@ -4540,7 +4540,7 @@ Node* EffectControlLinearizer::SmiShiftBitsConstant() {
 
 Node* EffectControlLinearizer::LowerPlainPrimitiveToNumber(Node* node) {
   Node* value = node->InputAt(0);
-  return __ ToNumber(TNode<Object>::UncheckedCast(value));
+  return __ PlainPrimitiveToNumber(TNode<Object>::UncheckedCast(value));
 }
 
 Node* EffectControlLinearizer::LowerPlainPrimitiveToWord32(Node* node) {
@@ -4555,7 +4555,8 @@ Node* EffectControlLinearizer::LowerPlainPrimitiveToWord32(Node* node) {
   __ Goto(&done, ChangeSmiToInt32(value));
 
   __ Bind(&if_not_smi);
-  Node* to_number = __ ToNumber(TNode<Object>::UncheckedCast(value));
+  Node* to_number =
+      __ PlainPrimitiveToNumber(TNode<Object>::UncheckedCast(value));
 
   Node* check1 = ObjectIsSmi(to_number);
   __ GotoIf(check1, &if_to_number_smi);
@@ -4582,7 +4583,8 @@ Node* EffectControlLinearizer::LowerPlainPrimitiveToFloat64(Node* node) {
   __ Goto(&done, __ ChangeInt32ToFloat64(from_smi));
 
   __ Bind(&if_not_smi);
-  Node* to_number = __ ToNumber(TNode<Object>::UncheckedCast(value));
+  Node* to_number =
+      __ PlainPrimitiveToNumber(TNode<Object>::UncheckedCast(value));
   Node* check1 = ObjectIsSmi(to_number);
   __ GotoIf(check1, &if_to_number_smi);
 

src/compiler/graph-assembler.cc

@@ -695,8 +695,8 @@ Node* GraphAssembler::UnsafePointerAdd(Node* base, Node* external) {
                                   effect(), control()));
 }
 
-TNode<Number> JSGraphAssembler::ToNumber(TNode<Object> value) {
-  return AddNode<Number>(graph()->NewNode(ToNumberOperator(),
+TNode<Number> JSGraphAssembler::PlainPrimitiveToNumber(TNode<Object> value) {
+  return AddNode<Number>(graph()->NewNode(PlainPrimitiveToNumberOperator(),
                                           ToNumberBuiltinConstant(), value,
                                           NoContextConstant(), effect()));
 }
@@ -874,7 +874,7 @@ void GraphAssembler::InitializeEffectControl(Node* effect, Node* control) {
   control_ = control;
 }
 
-Operator const* JSGraphAssembler::ToNumberOperator() {
+Operator const* JSGraphAssembler::PlainPrimitiveToNumberOperator() {
   if (!to_number_operator_.is_set()) {
     Callable callable = Builtins::CallableFor(isolate(), Builtins::kToNumber);
     CallDescriptor::Flags flags = CallDescriptor::kNoFlags;

src/compiler/graph-assembler.h

@@ -703,7 +703,7 @@ class V8_EXPORT_PRIVATE JSGraphAssembler : public GraphAssembler {
                                  TNode<Object> value);
   TNode<Number> StringLength(TNode<String> string);
   TNode<Boolean> ReferenceEqual(TNode<Object> lhs, TNode<Object> rhs);
-  TNode<Number> ToNumber(TNode<Object> value);
+  TNode<Number> PlainPrimitiveToNumber(TNode<Object> value);
   TNode<Number> NumberMin(TNode<Number> lhs, TNode<Number> rhs);
   TNode<Number> NumberMax(TNode<Number> lhs, TNode<Number> rhs);
   TNode<Boolean> NumberLessThan(TNode<Number> lhs, TNode<Number> rhs);
@@ -731,7 +731,7 @@ class V8_EXPORT_PRIVATE JSGraphAssembler : public GraphAssembler {
   }
 
  protected:
-  Operator const* ToNumberOperator();
+  Operator const* PlainPrimitiveToNumberOperator();
 
  private:
   JSGraph* jsgraph_;