Commit 870ef6bd authored by sgjesse@chromium.org's avatar sgjesse@chromium.org

Remove the flag --debug-info

This flag has not bees set to false for years, and even when building without debugging support the position information is required for stack traces.

R=ager@chromium.org

BUG=none
TEST=none

Review URL: http://codereview.chromium.org//7046078

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8252 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
parent 2481f0fc
...@@ -770,7 +770,7 @@ void LCodeGen::RecordSafepointWithRegistersAndDoubles( ...@@ -770,7 +770,7 @@ void LCodeGen::RecordSafepointWithRegistersAndDoubles(
void LCodeGen::RecordPosition(int position) { void LCodeGen::RecordPosition(int position) {
if (!FLAG_debug_info || position == RelocInfo::kNoPosition) return; if (position == RelocInfo::kNoPosition) return;
masm()->positions_recorder()->RecordPosition(position); masm()->positions_recorder()->RecordPosition(position);
} }
......
...@@ -199,7 +199,6 @@ DEFINE_bool(opt, true, "use adaptive optimizations") ...@@ -199,7 +199,6 @@ DEFINE_bool(opt, true, "use adaptive optimizations")
DEFINE_bool(opt_eagerly, false, "be more eager when adaptively optimizing") DEFINE_bool(opt_eagerly, false, "be more eager when adaptively optimizing")
DEFINE_bool(always_opt, false, "always try to optimize functions") DEFINE_bool(always_opt, false, "always try to optimize functions")
DEFINE_bool(prepare_always_opt, false, "prepare for turning on always opt") DEFINE_bool(prepare_always_opt, false, "prepare for turning on always opt")
DEFINE_bool(debug_info, true, "add debug information to compiled functions")
DEFINE_bool(deopt, true, "support deoptimization") DEFINE_bool(deopt, true, "support deoptimization")
DEFINE_bool(trace_deopt, false, "trace deoptimization") DEFINE_bool(trace_deopt, false, "trace deoptimization")
......
...@@ -572,21 +572,16 @@ void FullCodeGenerator::VisitDeclarations( ...@@ -572,21 +572,16 @@ void FullCodeGenerator::VisitDeclarations(
void FullCodeGenerator::SetFunctionPosition(FunctionLiteral* fun) { void FullCodeGenerator::SetFunctionPosition(FunctionLiteral* fun) {
if (FLAG_debug_info) {
CodeGenerator::RecordPositions(masm_, fun->start_position()); CodeGenerator::RecordPositions(masm_, fun->start_position());
}
} }
void FullCodeGenerator::SetReturnPosition(FunctionLiteral* fun) { void FullCodeGenerator::SetReturnPosition(FunctionLiteral* fun) {
if (FLAG_debug_info) {
CodeGenerator::RecordPositions(masm_, fun->end_position() - 1); CodeGenerator::RecordPositions(masm_, fun->end_position() - 1);
}
} }
void FullCodeGenerator::SetStatementPosition(Statement* stmt) { void FullCodeGenerator::SetStatementPosition(Statement* stmt) {
if (FLAG_debug_info) {
#ifdef ENABLE_DEBUGGER_SUPPORT #ifdef ENABLE_DEBUGGER_SUPPORT
if (!isolate()->debugger()->IsDebuggerActive()) { if (!isolate()->debugger()->IsDebuggerActive()) {
CodeGenerator::RecordPositions(masm_, stmt->statement_pos()); CodeGenerator::RecordPositions(masm_, stmt->statement_pos());
...@@ -609,12 +604,10 @@ void FullCodeGenerator::SetStatementPosition(Statement* stmt) { ...@@ -609,12 +604,10 @@ void FullCodeGenerator::SetStatementPosition(Statement* stmt) {
#else #else
CodeGenerator::RecordPositions(masm_, stmt->statement_pos()); CodeGenerator::RecordPositions(masm_, stmt->statement_pos());
#endif #endif
}
} }
void FullCodeGenerator::SetExpressionPosition(Expression* expr, int pos) { void FullCodeGenerator::SetExpressionPosition(Expression* expr, int pos) {
if (FLAG_debug_info) {
#ifdef ENABLE_DEBUGGER_SUPPORT #ifdef ENABLE_DEBUGGER_SUPPORT
if (!isolate()->debugger()->IsDebuggerActive()) { if (!isolate()->debugger()->IsDebuggerActive()) {
CodeGenerator::RecordPositions(masm_, pos); CodeGenerator::RecordPositions(masm_, pos);
...@@ -641,19 +634,16 @@ void FullCodeGenerator::SetExpressionPosition(Expression* expr, int pos) { ...@@ -641,19 +634,16 @@ void FullCodeGenerator::SetExpressionPosition(Expression* expr, int pos) {
#else #else
CodeGenerator::RecordPositions(masm_, pos); CodeGenerator::RecordPositions(masm_, pos);
#endif #endif
}
} }
void FullCodeGenerator::SetStatementPosition(int pos) { void FullCodeGenerator::SetStatementPosition(int pos) {
if (FLAG_debug_info) {
CodeGenerator::RecordPositions(masm_, pos); CodeGenerator::RecordPositions(masm_, pos);
}
} }
void FullCodeGenerator::SetSourcePosition(int pos) { void FullCodeGenerator::SetSourcePosition(int pos) {
if (FLAG_debug_info && pos != RelocInfo::kNoPosition) { if (pos != RelocInfo::kNoPosition) {
masm_->positions_recorder()->RecordPosition(pos); masm_->positions_recorder()->RecordPosition(pos);
} }
} }
......
...@@ -693,7 +693,7 @@ void LCodeGen::RecordSafepointWithRegisters(LPointerMap* pointers, ...@@ -693,7 +693,7 @@ void LCodeGen::RecordSafepointWithRegisters(LPointerMap* pointers,
void LCodeGen::RecordPosition(int position) { void LCodeGen::RecordPosition(int position) {
if (!FLAG_debug_info || position == RelocInfo::kNoPosition) return; if (position == RelocInfo::kNoPosition) return;
masm()->positions_recorder()->RecordPosition(position); masm()->positions_recorder()->RecordPosition(position);
} }
......
...@@ -692,7 +692,7 @@ void LCodeGen::RecordSafepointWithRegisters(LPointerMap* pointers, ...@@ -692,7 +692,7 @@ void LCodeGen::RecordSafepointWithRegisters(LPointerMap* pointers,
void LCodeGen::RecordPosition(int position) { void LCodeGen::RecordPosition(int position) {
if (!FLAG_debug_info || position == RelocInfo::kNoPosition) return; if (position == RelocInfo::kNoPosition) return;
masm()->positions_recorder()->RecordPosition(position); masm()->positions_recorder()->RecordPosition(position);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment