Commit 85e25df6 authored by Pierre Langlois's avatar Pierre Langlois Committed by Commit Bot

[csa] Transform multiplications into left shifts

Turn cases where we are multiplying with a power of two into a left shift. We
hit this optimisation roughly 500 times in the snapshot.

Bug: 
Change-Id: Ibd3104a3dbe49f247a2d84db94891f6e3a897026
Reviewed-on: https://chromium-review.googlesource.com/763229Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
Cr-Commit-Position: refs/heads/master@{#49306}
parent b73ee334
...@@ -465,12 +465,12 @@ TNode<WordT> CodeAssembler::IntPtrMul(SloppyTNode<WordT> left, ...@@ -465,12 +465,12 @@ TNode<WordT> CodeAssembler::IntPtrMul(SloppyTNode<WordT> left,
if (is_right_constant) { if (is_right_constant) {
return IntPtrConstant(left_constant * right_constant); return IntPtrConstant(left_constant * right_constant);
} }
if (left_constant == 1) { if (base::bits::IsPowerOfTwo(left_constant)) {
return right; return WordShl(right, WhichPowerOf2(left_constant));
} }
} else if (is_right_constant) { } else if (is_right_constant) {
if (right_constant == 1) { if (base::bits::IsPowerOfTwo(right_constant)) {
return left; return WordShl(left, WhichPowerOf2(right_constant));
} }
} }
return UncheckedCast<IntPtrT>(raw_assembler()->IntPtrMul(left, right)); return UncheckedCast<IntPtrT>(raw_assembler()->IntPtrMul(left, right));
......
...@@ -109,6 +109,20 @@ TARGET_TEST_F(CodeAssemblerTest, IntPtrMul) { ...@@ -109,6 +109,20 @@ TARGET_TEST_F(CodeAssemblerTest, IntPtrMul) {
Node* c = m.IntPtrMul(a, b); Node* c = m.IntPtrMul(a, b);
EXPECT_THAT(c, IsIntPtrConstant(500)); EXPECT_THAT(c, IsIntPtrConstant(500));
} }
// x * 2^CONST => x << CONST
{
Node* a = m.Parameter(0);
Node* b = m.IntPtrConstant(1 << 3);
Node* c = m.IntPtrMul(a, b);
EXPECT_THAT(c, IsWordShl(a, IsIntPtrConstant(3)));
}
// 2^CONST * x => x << CONST
{
Node* a = m.IntPtrConstant(1 << 3);
Node* b = m.Parameter(0);
Node* c = m.IntPtrMul(a, b);
EXPECT_THAT(c, IsWordShl(b, IsIntPtrConstant(3)));
}
} }
TARGET_TEST_F(CodeAssemblerTest, WordShl) { TARGET_TEST_F(CodeAssemblerTest, WordShl) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment